Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rCqXA-00HUMo-U9 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Dec 2023 00:22:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rCqX9-000Dto-IM for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Dec 2023 00:21:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rCqX9-000Dsn-8M for pgsql-hackers@lists.postgresql.org; Tue, 12 Dec 2023 00:21:59 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rCqX1-009x0J-EY for pgsql-hackers@postgresql.org; Tue, 12 Dec 2023 00:21:58 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 4F39E2FCF7EF for ; Tue, 12 Dec 2023 01:21:48 +0100 (CET) Received: from s980.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 408CA2E270BD; Tue, 12 Dec 2023 01:21:48 +0100 (CET) Received: from s472.loopia.se (unknown [172.22.191.5]) by s980.loopia.se (Postfix) with ESMTP id 3EA9C2201608; Tue, 12 Dec 2023 01:21:48 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.01 X-Spam-Level: X-Spam-Status: No, score=-1.01 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=disabled Received: from s980.loopia.se ([172.22.191.6]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with LMTP id jU_gzbccVxt2; Tue, 12 Dec 2023 01:21:47 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s980.loopia.se (Postfix) with ESMTPSA id B14D6220160C; Tue, 12 Dec 2023 01:21:47 +0100 (CET) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Daniel Gustafsson Mime-Version: 1.0 (1.0) Subject: Re: Add --check option to pgindent Date: Tue, 12 Dec 2023 01:21:36 +0100 Message-Id: References: Cc: pgsql-hackers@postgresql.org In-Reply-To: To: Tristan Partin X-Mailer: iPhone Mail (20D67) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 12 Dec 2023, at 01:09, Tristan Partin wrote: >=20 > =EF=BB=BFNot sold on the name, but --check is a combination of --silent-di= ff and --show-diff. I envision --check mostly being used in CI environments.= I recently came across a situation where this behavior would have been usef= ul. Without --check, you're left to capture the output of --show-diff and ex= it 2 if the output isn't empty by yourself. I haven=E2=80=99t studied the patch but I can see that being useful. ./daniel=