Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wBChH-000pys-2Z for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 14:19:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wBChG-00CVVL-0g for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 14:18:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wBCgA-00CSgW-3B for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 14:17:52 +0000 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wBCg8-00000000MmN-2qO6 for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 14:17:51 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0991E14001C5; Fri, 10 Apr 2026 10:17:46 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Fri, 10 Apr 2026 10:17:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1775830666; x=1775917066; bh=xzBsmu4ayrcNgCnzvLY+6bQhjS+aDTlHXFzQ7xvOY9M=; b= avmW1E2HH2kxt10AFyX5/r/kZ/QUOa7RaKPAJAvV7CtsFeYnC1oOQPX0E52D/WdH q3Sa2D7t68X+ctOILQVP8IhhkGOehx3gfCNjU8q0jcV61HUUTEyB1zFCgC+3HO8O phfhjgnGJiMG9mHOZo5tkAu/su/6lzbXtSMPe2FzYn4HIU2RpPBd4DZNpECxCwpt RlS1K4tRbPzu2J/9HxRQhWwcRm65F9MYzOatgz2o5ka9D9wMxP1sm7Mt/DKBAv61 TCd3ptwiEDjbDg0VUrRWzwfhnYY/PmFE+YMECNIZSXDnh7j7T3uv6GgHoQd4XFRc xxlLR2wc2S6dSZNFsFcaHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1775830666; x= 1775917066; bh=xzBsmu4ayrcNgCnzvLY+6bQhjS+aDTlHXFzQ7xvOY9M=; b=t IYOBzPQuxv34ge+5LQ//q7892hPfL2DW7lHZEg9nBDT26XjJwa0IA6sSrJnFb4Mk Ov7LYN4DFTMtrMTGhSM/1d3z6eUknKKrl4z/oO/OfG9dVCmhN895qAeuFtUyUisO EBMi6XKLVcMDWvK1X1groX0UlpyL4dFIhY6lFYUsM/1e4o8c3xR0sK58CIXy5n0+ gsFMTm7hFcuJIaQGHH4ysDjofqmElALtCWWE9jzAcJ7FWM+5lUdCXoKAk+SXCJWr E/5joaxMoksf+rsk2LNibFIeAmVBwEQGAcVGgt8MOyxytCO1IsDRuy4JqZ7UG9hH vUtjmLiRjMxYbyXhGgc7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvleeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefufggjfhfkgggtgfesthhqmhdttderjeenucfhrhhomheptehnughrvghs ucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrfgrth htvghrnhephffgkeehtedtgeevvedttdfhleeuheejvdetveffhffgjeduieegjeegkeei tdffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnughrvghssegrnhgrrhgriigvlhdruggvpdhnsggprhgtphhtthhopeduhedpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepthhhohhmrghsrdhmuhhnrhhosehgmhgrihhlrd gtohhmpdhrtghpthhtohepsgihrghvuhiikedusehgmhgrihhlrdgtohhmpdhrtghpthht ohepshgrmhhimhhsvghihhesghhmrghilhdrtghomhdprhgtphhtthhopehtghhlsehssh hsrdhpghhhrdhprgdruhhspdhrtghpthhtohepthhomhgrshesvhhonhgurhgrrdhmvgdp rhgtphhtthhopehmihgthhgrvghlsehprghquhhivghrrdighiiipdhrtghpthhtoheprg hnughrvgifseguuhhnshhlrghnvgdrnhgvthdprhgtphhtthhopehsuhhlrghmuhhlsehg mhgrihhlrdgtohhmpdhrtghpthhtohepiihsohhlthdrphgrrhhrrghgihesphgvrhgtoh hnrgdrtghomh X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Apr 2026 10:17:45 -0400 (EDT) Date: Fri, 10 Apr 2026 10:17:44 -0400 From: Andres Freund To: Thomas Munro , Nazir Bilal Yavuz CC: Sami Imseih , Tom Lane , Tomas Vondra , Michael Paquier , Andrew Dunstan , Amul Sul , Zsolt Parragi , Robert Haas , Chao Li , Anthonin Bonnefoy , Fujii Masao , Jakub Wartak , PostgreSQL Hackers Subject: Documenting coding style User-Agent: K-9 Mail for Android In-Reply-To: References: <2250061.1774104346@sss.pgh.pa.us> <1873141.1774823011@sss.pgh.pa.us> <3049460.1775067940@sss.pgh.pa.us> <3118179.1775092964@sss.pgh.pa.us> <3565835.1775147392@sss.pgh.pa.us> <3579709.1775151816@sss.pgh.pa.us> <63de1553-829a-488d-8ee0-976afb8dd32c@vondra.me> <3586483.1775155672@sss.pgh.pa.us> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi,=20 On April 10, 2026 3:57:56 AM EDT, Thomas Munro wrote: >Nitpicking code review for commit b15c1513: > >+read_archive_wal_page(XLogDumpPrivate *privateInfo, XLogRecPtr targetPag= ePtr, >+ Size count, char *readBuff) > >I thought we agreed to stop using Size for new code? size_t has been >around since C89=2E We really need to start documenting some of this stuff somewhere=2E Decidi= ng something a few years ago, deep in a thread, won't actually help anyone = but the participants (and maybe not even them) to know about it=2E=20 I wonder if we should move the coding style section out of sgml into a top= -level CODING_STYLE=2Emd or something like that=2E And then obviously add things like Size being deprecated=2E=20 Greetings,=20 Andres=20 --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E