From: Mark Dilger <mark.dilger@enterprisedb.com>
Message-Id: <C37D28BA-3BA3-4776-B812-17F05F3472D8@enterprisedb.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_60E42CBD-912F-4CCE-94FD-BE54336E2B0D"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Subject: Re: pg_amcheck contrib application
Date: Fri, 12 Mar 2021 20:41:50 -0800
In-Reply-To: 
 <CA+TgmoYoW2NNQC5qzEfsR9cYWpigqQgP_h5MZCLVt1XRbsXTXQ@mail.gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>,
 Thomas Munro <thomas.munro@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Stephen Frost <sfrost@snowman.net>,
 Michael Paquier <michael@paquier.xyz>,
 Amul Sul <sulamul@gmail.com>,
 Dilip Kumar <dilipbalaut@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
To: Robert Haas <robertmhaas@gmail.com>
References: <BA592F2D-F928-46FF-9516-2B827F067F57@enterprisedb.com>
 <CA+TgmoZtTZRE6Mzmwt8VEZD0G5NVbhiJEsHW2YGmmqzJUR_KwA@mail.gmail.com>
 <130B2AED-8322-47E6-AD3F-1263E5E18C80@enterprisedb.com>
 <CA+TgmoZgdsVo9ji_Bc7GVvEqGMapC1Hqyuy6CLV-3oyE7HapRA@mail.gmail.com>
 <BC7728FA-C21D-4E25-A266-E94873637354@enterprisedb.com>
 <CA+TgmobwDwvqbpc0OF8MNzQuwAJ2X1D0qEMdBEXXbmmFfzP9+Q@mail.gmail.com>
 <E8A89327-C1B1-4AE2-AEC6-871D39843627@enterprisedb.com>
 <CA+TgmoakvqTJNCSXQ0Y+pMBa33Gmf2o53WGg816eFC7ju3MWRQ@mail.gmail.com>
 <CA+TgmoZGk-mmV1xz=qOcxQ5fGtdK0_HVB2c8pVDUbMSaK8dM9A@mail.gmail.com>
 <53F089E8-F0E5-4FC9-A9DE-3D6377FA39C4@enterprisedb.com>
 <CA+TgmobrSJCx3PgUAYqOcqDjAN+SCjOJfJ6umGgkpp9sqQauSQ@mail.gmail.com>
 <E9EE1C23-9C17-45DF-8C0B-D6BE16CF18AF@enterprisedb.com>
 <CA+TgmobTsaZxiyqb3On-nYcS+TKXebb2sHMUAoyn-vviT8kevA@mail.gmail.com>
 <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
 <CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
 <CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
 <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
 <A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
 <CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
 <9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
 <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
 <CA+TgmoYoW2NNQC5qzEfsR9cYWpigqQgP_h5MZCLVt1XRbsXTXQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/C37D28BA-3BA3-4776-B812-17F05F3472D8%40enterprisedb.com>
Precedence: bulk


--Apple-Mail=_60E42CBD-912F-4CCE-94FD-BE54336E2B0D
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii


> On Mar 12, 2021, at 5:16 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> Gah, tests are so annoying. :-)

There is another problem of non-portable option ordering in the tests.


--Apple-Mail=_60E42CBD-912F-4CCE-94FD-BE54336E2B0D
Content-Disposition: attachment;
	filename=v4-0001-pg_amcheck-Keep-trying-to-fix-the-tests.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="v4-0001-pg_amcheck-Keep-trying-to-fix-the-tests.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=201f6cb42bd8edfee3f1770cb760ccb8b6ee9429ee=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Mark=20Dilger=20<mark.dilger@enterprisedb.com>=0A=
Date:=20Fri,=2012=20Mar=202021=2020:33:16=20-0800=0ASubject:=20[PATCH=20=
v4]=20pg_amcheck:=20Keep=20trying=20to=20fix=20the=20tests.=0A=0AFix=20=
another=20example=20of=20non-portable=20option=20ordering=20in=20the=20=
tests.=0A---=0A=20src/bin/pg_amcheck/t/003_check.pl=20|=202=20+-=0A=201=20=
file=20changed,=201=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20=
a/src/bin/pg_amcheck/t/003_check.pl=20=
b/src/bin/pg_amcheck/t/003_check.pl=0Aindex=200a7795bb64..54b2b86a49=20=
100644=0A---=20a/src/bin/pg_amcheck/t/003_check.pl=0A+++=20=
b/src/bin/pg_amcheck/t/003_check.pl=0A@@=20-468,7=20+468,7=20@@=20=
command_fails_like(=0A=20=09'pg_amcheck=20rejects=20garbage=20=
startblock');=0A=20=0A=20command_fails_like(=0A-=09[=20@cmd,=20'db1',=20=
'-s',=20's5',=20'--endblock',=20'1234junk'=20],=0A+=09[=20@cmd,=20'-s',=20=
's5',=20'--endblock',=20'1234junk',=20'db1'=20],=0A=20=09qr/invalid=20=
end=20block/,=0A=20=09'pg_amcheck=20rejects=20garbage=20endblock');=0A=20=
=0A--=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A=

--Apple-Mail=_60E42CBD-912F-4CCE-94FD-BE54336E2B0D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--Apple-Mail=_60E42CBD-912F-4CCE-94FD-BE54336E2B0D--