Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: postgres_fdw: fix cumulative stats after imported foreign-table
 stats
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAPmGK16=f7F8vadOF_iiYmxG5N1E+jfY1jX39mYbV=H8md_Phg@mail.gmail.com>
Date: Tue, 7 Jul 2026 07:22:45 -0700
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Corey Huinker <corey.huinker@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C423F4B5-55B8-44AE-AB7A-7FC6B8EC1BA7@gmail.com>
References: <6ED81190-B398-44C9-A1E9-8EFE4ED183AF@gmail.com>
 <CAPmGK17uDi89_D16UHrcct5_JwbtY_ojFtkd5gXsvJNiVJDg5Q@mail.gmail.com>
 <9FFB81DF-3F7F-42B5-915D-904F22B508C1@gmail.com>
 <CAPmGK17n6vKYa6q+ap+cLD-NpDby+s0mRh0SRc+XgiWbqWSd1Q@mail.gmail.com>
 <65F7302E-EFE3-4BF6-AA7F-9A41C82F6FBF@gmail.com>
 <CAPmGK16=f7F8vadOF_iiYmxG5N1E+jfY1jX39mYbV=H8md_Phg@mail.gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/C423F4B5-55B8-44AE-AB7A-7FC6B8EC1BA7%40gmail.com>
Precedence: bulk


> On Jul 7, 2026, at 02:50, Etsuro Fujita <etsuro.fujita@gmail.com> =
wrote:
>=20
> Hi Chao,
>=20
> On Mon, Jul 6, 2026 at 11:52=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>> @@ -230,7 +230,8 @@ analyze_rel(Oid relid, RangeVar *relation,
>>>       if (fdwroutine->ImportForeignStatistics !=3D NULL &&
>>>           fdwroutine->ImportForeignStatistics(onerel, va_cols, =
elevel))
>>>           stats_imported =3D true;
>>> -       else
>>> +
>>> +       if (!stats_imported)
>>>=20
>>> Is this a leftover?
>>=20
>> Ah, yes, that=E2=80=99s a leftover. Reverted that in v3.
>=20
> Ok, thanks for updating the patch!  Committed and back-patched.
>=20
> Best regards,
> Etsuro Fujita

Thanks for pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/