Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prxzR-0004zo-Hd for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Apr 2023 09:32:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1prxzQ-00055O-Cu for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Apr 2023 09:32:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prxzQ-00055E-3W for pgsql-hackers@lists.postgresql.org; Thu, 27 Apr 2023 09:32:36 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1prxzN-0029RN-Eg for pgsql-hackers@postgresql.org; Thu, 27 Apr 2023 09:32:34 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 188782F8957F for ; Thu, 27 Apr 2023 11:32:31 +0200 (CEST) Received: from s979.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 077272E28031; Thu, 27 Apr 2023 11:32:31 +0200 (CEST) Received: from s474.loopia.se (unknown [172.22.191.6]) by s979.loopia.se (Postfix) with ESMTP id 01BEF10BC455; Thu, 27 Apr 2023 11:32:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s899.loopia.se ([172.22.191.5]) by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024) with LMTP id 41hfnOoLizJx; Thu, 27 Apr 2023 11:32:30 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id 18D082C8BAD1; Thu, 27 Apr 2023 11:32:30 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: Should vacuum process config file reload more often From: Daniel Gustafsson In-Reply-To: Date: Thu, 27 Apr 2023 11:32:29 +0200 Cc: Melanie Plageman , Robert Haas , Andres Freund , Tom Lane , Masahiko Sawada , Kyotaro Horiguchi , PostgreSQL Hackers , Amit Kapila Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230329.132155.629765142788133576.horikyota.ntt@gmail.com> <20230329.173456.1185961934810139447.horikyota.ntt@gmail.com> <935191FB-083B-4060-89FC-466F61FAA391@yesql.se> <1252075.1680547394@sss.pgh.pa.us> <20230403190837.qubpnwugfe2k2g46@awork3.anarazel.de> <7E06F879-7E20-4A6A-862F-CA72CDC9A323@yesql.se> <5028847C-937A-4CC2-B127-AFF5F9FB79C5@yesql.se> <2B703533-102A-47E5-A4F7-C6A68C09BB27@yesql.se> To: John Naylor X-Mailer: Apple Mail (2.3696.120.41.1.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 27 Apr 2023, at 11:29, John Naylor = wrote: > On Fri, Apr 7, 2023 at 6:08=E2=80=AFAM Daniel Gustafsson = wrote: > > I had another read-through and test-through of this version, and = have applied > > it with some minor changes to comments and whitespace. Thanks for = the quick > > turnaround times on reviews in this thread! >=20 > - VacuumFailsafeActive =3D false; > + Assert(!VacuumFailsafeActive); >=20 > I can trigger this assert added in commit 7d71d3dd08. >=20 > First build with the patch in [1], then: Interesting, thanks for the report! I'll look into it directly. -- Daniel Gustafsson