Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: adding 'zstd' as a compression algorithm
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <CA+TgmoatQKGd+8SjcV+bzvw4XaoEwminHjU83yG12+NXtQzTTQ@mail.gmail.com>
Date: Thu, 17 Feb 2022 11:12:50 +0500
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C891A99F-513E-4103-9FB4-9F5A53DD6D32@yandex-team.ru>
References: <CA+TgmoatQKGd+8SjcV+bzvw4XaoEwminHjU83yG12+NXtQzTTQ@mail.gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/C891A99F-513E-4103-9FB4-9F5A53DD6D32%40yandex-team.ru>
Precedence: bulk


> 15 =D1=84=D0=B5=D0=B2=D1=80. 2022 =D0=B3., =D0=B2 23:20, Robert Haas =
<robertmhaas@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0)=
:
>=20
> Anyway, those are my thoughts. What are yours?

+1 for adding Zstd everywhere. Quite similar patches are already a part =
of "libpq compression" and "zstd for pg_dump" commitfest entries, so =
pushing this will simplify those entries IMV.

Also I like the idea of defaulting FPI compression to lz4 and adding =
Zstd as wal_compression option.
I don't think Zstd is obvious choice for default FPI compression: there =
are HW setups when disks are almost as fast as RAM. In this case lz4 can =
improve performance, while Zstd might make things slower.

Thanks!

Best regards, Andrey Borodin.=