MIME-Version: 1.0
From: Lakshmi N <lakshmin.jhs@gmail.com>
Date: Wed, 18 Mar 2026 00:17:40 -0700
Message-ID: 
 <CA+3i_M-+WVyrRcfnxa4gt+KQUzH-LTQ8D2JCGE_O0WzJJtZfUg@mail.gmail.com>
Subject: log XLogPrefetch stats at end of recovery
To: pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="000000000000137951064d47404e"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2B3i_M-%2BWVyrRcfnxa4gt%2BKQUzH-LTQ8D2JCGE_O0WzJJtZfUg%40mail.gmail.com>
Precedence: bulk

--000000000000137951064d47404e
Content-Type: multipart/alternative; boundary="00000000000013794f064d47404c"

--00000000000013794f064d47404c
Content-Type: text/plain; charset="UTF-8"

Hi,

While investigating a long recovery, I noticed that XLogPrefetch stats were
not logged at the end of recovery. This log message will be useful to
understand how effective XLogPrefetch was during recovery. Adding a patch
to address this.

Regards,
Lakshmi

--00000000000013794f064d47404c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>While investigating a long recovery=
, I noticed that XLogPrefetch stats were not logged at the end of recovery.=
 This log message will be useful to understand how effective XLogPrefetch w=
as during recovery. Adding a patch to address this.</div><div><br></div><di=
v>Regards,</div><div>Lakshmi</div></div>

--00000000000013794f064d47404c--

--000000000000137951064d47404e
Content-Type: application/octet-stream;
	name="0001-log-prefetch-stats-at-end-of-recovery.patch"
Content-Disposition: attachment;
	filename="0001-log-prefetch-stats-at-end-of-recovery.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmvpjuks0>
X-Attachment-Id: f_mmvpjuks0

RnJvbSBkYTM4NmE0ODc3NjRkOWJjYTEzNzNjMjVmN2I2NzNmOTBmNTdjZGJhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYWtzaG1pIE4gPGxha3NobWluLmpoc0BnbWFpbC5jb20+CkRh
dGU6IFdlZCwgMTggTWFyIDIwMjYgMDA6MDA6NTEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBsb2cg
WExvZ1ByZWZldGNoIHN0YXRzIGF0IGVuZCBvZiByZWNvdmVyeQoKQWRkIFhMb2dQcmVmZXRjaExv
Z1N0YXRzKCksIHdoaWNoIGVtaXRzIGEgTE9HIG1lc3NhZ2Ugc3VtbWFyaXppbmcgdGhlCnByZWZl
dGNoIGNvdW50ZXJzIChwcmVmZXRjaCwgaGl0LCBza2lwX2luaXQsIHNraXBfbmV3LCBza2lwX2Zw
dywKc2tpcF9yZXApIGFjY3VtdWxhdGVkIGR1cmluZyByZWNvdmVyeS4gVGhlIGZ1bmN0aW9uIGlz
IGNhbGxlZCBmcm9tClBlcmZvcm1XYWxSZWNvdmVyeSgpIGltbWVkaWF0ZWx5IGFmdGVyIHRoZSAi
cmVkbyBkb25lIiBtZXNzYWdlLCBnaXZpbmcKdmlzaWJpbGl0eSBpbnRvIGhvdyBlZmZlY3RpdmUg
V0FMIHByZWZldGNoaW5nIHdhcyBvdmVyIHRoZQpjb3Vyc2Ugb2YgdGhlIHJlY292ZXJ5LgoKTm8t
b3Agd2hlbiByZWNvdmVyeV9wcmVmZXRjaCA9IG9mZi4KLS0tCiBzcmMvYmFja2VuZC9hY2Nlc3Mv
dHJhbnNhbS94bG9ncHJlZmV0Y2hlci5jIHwgMTkgKysrKysrKysrKysrKysrKysrKwogc3JjL2Jh
Y2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMgICB8ICAyICsrCiBzcmMvaW5jbHVk
ZS9hY2Nlc3MveGxvZ3ByZWZldGNoZXIuaCAgICAgICAgIHwgIDIgKysKIDMgZmlsZXMgY2hhbmdl
ZCwgMjMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFu
c2FtL3hsb2dwcmVmZXRjaGVyLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncHJl
ZmV0Y2hlci5jCmluZGV4IGMyMzVlY2E3YzUxLi5kOWViYWZlMTJmOCAxMDA2NDQKLS0tIGEvc3Jj
L2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3ByZWZldGNoZXIuYworKysgYi9zcmMvYmFja2Vu
ZC9hY2Nlc3MvdHJhbnNhbS94bG9ncHJlZmV0Y2hlci5jCkBAIC0zMzUsNiArMzM1LDI1IEBAIFhM
b2dQcmVmZXRjaFNobWVtSW5pdCh2b2lkKQogCX0KIH0KIAorLyoKKyAqIExvZyBhIHN1bW1hcnkg
b2YgdGhlIFhMb2dQcmVmZXRjaGVyIHN0YXRzLiBJbnRlbmRlZCB0byBiZSBjYWxsZWQgCisgKiBh
dCB0aGUgZW5kIG9mIHJlY292ZXJ5IG9yIHdoZW4gYSBzdGFuZGJ5IGlzIHByb21vdGVkLgorICov
Cit2b2lkCitYTG9nUHJlZmV0Y2hMb2dTdGF0cyh2b2lkKQoreworCWlmIChyZWNvdmVyeV9wcmVm
ZXRjaCA9PSBSRUNPVkVSWV9QUkVGRVRDSF9PRkYpCisJCXJldHVybjsKKworCWVsb2coTE9HLCAi
WExvZ1ByZWZldGNoZXIgc3RhdHM6IHByZWZldGNoPSVsdSwgaGl0PSVsdSwgc2tpcF9pbml0PSVs
dSwgc2tpcF9uZXc9JWx1LCBza2lwX2Zwdz0lbHUsIHNraXBfcmVwPSVsdSIsCisJCSBwZ19hdG9t
aWNfcmVhZF91NjQoJlNoYXJlZFN0YXRzLT5wcmVmZXRjaCksCisJCSBwZ19hdG9taWNfcmVhZF91
NjQoJlNoYXJlZFN0YXRzLT5oaXQpLAorCQkgcGdfYXRvbWljX3JlYWRfdTY0KCZTaGFyZWRTdGF0
cy0+c2tpcF9pbml0KSwKKwkJIHBnX2F0b21pY19yZWFkX3U2NCgmU2hhcmVkU3RhdHMtPnNraXBf
bmV3KSwKKwkJIHBnX2F0b21pY19yZWFkX3U2NCgmU2hhcmVkU3RhdHMtPnNraXBfZnB3KSwKKwkJ
IHBnX2F0b21pY19yZWFkX3U2NCgmU2hhcmVkU3RhdHMtPnNraXBfcmVwKSk7Cit9CisKIC8qCiAg
KiBDYWxsZWQgd2hlbiBhbnkgR1VDIGlzIGNoYW5nZWQgdGhhdCBhZmZlY3RzIHByZWZldGNoaW5n
LgogICovCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3Zl
cnkuYyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dyZWNvdmVyeS5jCmluZGV4IDZk
MmM0YTg2Yjk2Li43NDJjYjkwZGE5YiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL3Ry
YW5zYW0veGxvZ3JlY292ZXJ5LmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxv
Z3JlY292ZXJ5LmMKQEAgLTE4NDUsNiArMTg0NSw4IEBAIFBlcmZvcm1XYWxSZWNvdmVyeSh2b2lk
KQogCQkJCWVycm1zZygicmVkbyBkb25lIGF0ICVYLyUwOFggc3lzdGVtIHVzYWdlOiAlcyIsCiAJ
CQkJCSAgIExTTl9GT1JNQVRfQVJHUyh4bG9ncmVhZGVyLT5SZWFkUmVjUHRyKSwKIAkJCQkJICAg
cGdfcnVzYWdlX3Nob3coJnJ1MCkpKTsKKwkJCisJCVhMb2dQcmVmZXRjaExvZ1N0YXRzKCk7CiAJ
CXh0aW1lID0gR2V0TGF0ZXN0WFRpbWUoKTsKIAkJaWYgKHh0aW1lKQogCQkJZXJlcG9ydChMT0cs
CmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9hY2Nlc3MveGxvZ3ByZWZldGNoZXIuaCBiL3NyYy9p
bmNsdWRlL2FjY2Vzcy94bG9ncHJlZmV0Y2hlci5oCmluZGV4IDdlYzQwYzRiNzhiLi5hODYyOTI0
Yzg5NSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvYWNjZXNzL3hsb2dwcmVmZXRjaGVyLmgKKysr
IGIvc3JjL2luY2x1ZGUvYWNjZXNzL3hsb2dwcmVmZXRjaGVyLmgKQEAgLTM3LDYgKzM3LDcgQEAg
ZXh0ZXJuIHZvaWQgWExvZ1ByZWZldGNoUmVjb25maWd1cmUodm9pZCk7CiBleHRlcm4gc2l6ZV90
IFhMb2dQcmVmZXRjaFNobWVtU2l6ZSh2b2lkKTsKIGV4dGVybiB2b2lkIFhMb2dQcmVmZXRjaFNo
bWVtSW5pdCh2b2lkKTsKIAorZXh0ZXJuIHZvaWQgWExvZ1ByZWZldGNoTG9nU3RhdHModm9pZCk7
CiBleHRlcm4gdm9pZCBYTG9nUHJlZmV0Y2hSZXNldFN0YXRzKHZvaWQpOwogCiBleHRlcm4gWExv
Z1ByZWZldGNoZXIgKlhMb2dQcmVmZXRjaGVyQWxsb2NhdGUoWExvZ1JlYWRlclN0YXRlICpyZWFk
ZXIpOwpAQCAtNTIsNCArNTMsNSBAQCBleHRlcm4gWExvZ1JlY29yZCAqWExvZ1ByZWZldGNoZXJS
ZWFkUmVjb3JkKFhMb2dQcmVmZXRjaGVyICpwcmVmZXRjaGVyLAogCiBleHRlcm4gdm9pZCBYTG9n
UHJlZmV0Y2hlckNvbXB1dGVTdGF0cyhYTG9nUHJlZmV0Y2hlciAqcHJlZmV0Y2hlcik7CiAKKwog
I2VuZGlmCgoK
--000000000000137951064d47404e--