public inbox for [email protected]  
help / color / mirror / Atom feed
From: Lakshmi N <[email protected]>
To: [email protected]
Subject: Add missing CHECK_FOR_INTERRUPTS calls in dblink module
Date: Tue, 10 Mar 2026 01:37:57 -0700
Message-ID: <CA+3i_M-fFb4cZ4SYToBft5VERvo0AZ22LRfzLE5axpGr9YsgPg@mail.gmail.com> (raw)

Hi All,

This is my first patch submission, please guide me if I made any mistakes.
I noticed that CHECK_FOR_INTERRUPTS is missing at two places in dblink.c.
Submitting a small patch to address this.

Regards,
Lakshmi


Attachments:

  [application/octet-stream] 0001-Add-missing-CHECK_FOR_INTERRUPTS-in-dblink-module.patch (591B, 3-0001-Add-missing-CHECK_FOR_INTERRUPTS-in-dblink-module.patch)
  download | inline diff:
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 8bf8fc8ea2f..d9e06915e3a 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -952,6 +952,8 @@ materializeResult(FunctionCallInfo fcinfo, PGconn *conn, PGresult *res)
 		{
 			HeapTuple	tuple;
 
+			CHECK_FOR_INTERRUPTS();
+
 			if (!is_sql_cmd)
 			{
 				int			i;
@@ -1894,6 +1896,8 @@ dblink_get_notify(PG_FUNCTION_ARGS)
 		Datum		values[DBLINK_NOTIFY_COLS];
 		bool		nulls[DBLINK_NOTIFY_COLS];
 
+		CHECK_FOR_INTERRUPTS();
+
 		memset(values, 0, sizeof(values));
 		memset(nulls, 0, sizeof(nulls));
 


view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Add missing CHECK_FOR_INTERRUPTS calls in dblink module
  In-Reply-To: <CA+3i_M-fFb4cZ4SYToBft5VERvo0AZ22LRfzLE5axpGr9YsgPg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox