MIME-Version: 1.0
From: Lakshmi N <lakshmin.jhs@gmail.com>
Date: Thu, 16 Apr 2026 01:19:44 -0700
Message-ID: 
 <CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com>
Subject: Reject invalid databases in pg_get_database_ddl()
To: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Cc: andrew@dunslane.net
Content-Type: multipart/mixed; boundary="00000000000061905c064f8f7f86"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2B3i_M8m1k2gFch%2BtU0JmAQh9FRV%2BpFrfTXDrJo%2BBqmwsTmOhg%40mail.gmail.com>
Precedence: bulk

--00000000000061905c064f8f7f86
Content-Type: multipart/alternative; boundary="00000000000061905b064f8f7f84"

--00000000000061905b064f8f7f84
Content-Type: text/plain; charset="UTF-8"

Hi,

pg_get_database_ddl() is not checking for databases in an invalid state
before producing ddl statements. This caused the function to emit
CONNECTION_LIMIT = -2, which is invalid SQL that Postgres rejects.
A database row can be in this inconsistent state longer, for example
server crashed during a drop database.

Attached patch to fix this issue by doing a database_is_invalid_form()
check early in pg_get_database_ddl_internal().

Regards,
Lakshmi

--00000000000061905b064f8f7f84
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>pg_get_database_ddl() is not checki=
ng for databases in an invalid state</div><div>before producing ddl stateme=
nts. This caused the function to emit</div><div>CONNECTION_LIMIT =3D -2, wh=
ich is invalid SQL that Postgres rejects.</div><div>A database row can be i=
n this inconsistent=C2=A0state longer, for=C2=A0example</div><div>server cr=
ashed during a drop database.</div><div><br></div><div>Attached patch to fi=
x this issue by doing a database_is_invalid_form()</div><div>check early in=
 pg_get_database_ddl_internal().</div><div><br></div><div>Regards,</div><di=
v>Lakshmi</div></div>

--00000000000061905b064f8f7f84--

--00000000000061905c064f8f7f86
Content-Type: application/octet-stream;
	name="0001-Reject-pg_get_database_ddl-for-invalid-databases.patch"
Content-Disposition: attachment;
	filename="0001-Reject-pg_get_database_ddl-for-invalid-databases.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo17d6wr0>
X-Attachment-Id: f_mo17d6wr0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9kZGx1dGlscy5jIGIvc3JjL2JhY2tl
bmQvdXRpbHMvYWR0L2RkbHV0aWxzLmMKaW5kZXggYzRmOWY4NmM0M2UuLjdmZmUyMzE0MTdhIDEw
MDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hZHQvZGRsdXRpbHMuYworKysgYi9zcmMvYmFj
a2VuZC91dGlscy9hZHQvZGRsdXRpbHMuYwpAQCAtODg3LDYgKzg4NywxNyBAQCBwZ19nZXRfZGF0
YWJhc2VfZGRsX2ludGVybmFsKE9pZCBkYmlkLCBib29sIHByZXR0eSwKIAlkYmZvcm0gPSAoRm9y
bV9wZ19kYXRhYmFzZSkgR0VUU1RSVUNUKHR1cGxlKTsKIAlkYm5hbWUgPSBwc3RyZHVwKE5hbWVT
dHIoZGJmb3JtLT5kYXRuYW1lKSk7CiAKKwkvKgorCSAqIFJlamVjdCBpbnZhbGlkIGRhdGFiYXNl
cy4gVGhpcyBpcyBhIHNhZmV0eSBtZWFzdXJlIHRvIGF2b2lkIGdlbmVyYXRpbmcgRERMCisJICog
dGhhdCBjYW4ndCBiZSBleGVjdXRlZC4gRm9yIGV4YW1wbGUsIGludmFsaWQgY29ubmVjdGlvbiBs
aW1pdC4KKwkgKi8KKwlpZiAoZGF0YWJhc2VfaXNfaW52YWxpZF9mb3JtKGRiZm9ybSkpCisJCWVy
ZXBvcnQoRVJST1IsCisJCQkJKGVycmNvZGUoRVJSQ09ERV9PQkpFQ1RfTk9UX0lOX1BSRVJFUVVJ
U0lURV9TVEFURSksCisJCQkJIGVycm1zZygiY2Fubm90IGdlbmVyYXRlIERETCBmb3IgaW52YWxp
ZCBkYXRhYmFzZSBcIiVzXCIiLAorCQkJCQkJZGJuYW1lKSwKKwkJCQkgZXJyaGludCgiVXNlIERS
T1AgREFUQUJBU0UgdG8gZHJvcCBpbnZhbGlkIGRhdGFiYXNlcy4iKSkpOworCiAJLyoKIAkgKiBX
ZSBkb24ndCBzdXBwb3J0IGdlbmVyYXRpbmcgRERMIGZvciBzeXN0ZW0gZGF0YWJhc2VzLiAgVGhl
IHByaW1hcnkKIAkgKiByZWFzb24gZm9yIHRoaXMgaXMgdGhhdCB1c2VycyBzaG91bGRuJ3QgYmUg
cmVjcmVhdGluZyB0aGVtLgo=
--00000000000061905c064f8f7f86--