MIME-Version: 1.0
From: Lakshmi N <lakshmin.jhs@gmail.com>
Date: Sun, 26 Apr 2026 22:33:00 -0700
Message-ID: 
 <CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com>
Subject: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION
To: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000005522ab06506a73cf"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2B3i_M98-XjE-_fw0p%2B8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg%40mail.gmail.com>
Precedence: bulk

--0000000000005522ab06506a73cf
Content-Type: multipart/alternative; boundary="0000000000005522a906506a73cd"

--0000000000005522a906506a73cd
Content-Type: text/plain; charset="UTF-8"

Hi hackers,

In CreateSubscription(), the subretentionactive catalog column (declared as
bool in pg_subscription.h) is populated using Int32GetDatum() instead of
BoolGetDatum():

This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().

The attached patch fixes this to use BoolGetDatum(), matching both the
catalog definition and the ALTER path.

Regards,
Lakshmi

--0000000000005522a906506a73cd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi hackers,<br><br>In CreateSubscription(), the subretenti=
onactive catalog column (declared as<br>bool in pg_subscription.h) is popul=
ated using Int32GetDatum() instead of<br>BoolGetDatum():<br><br>This writes=
 4 bytes into a 1-byte bool Datum. It is=C2=A0inconsistent with the=C2=A0<d=
iv>ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().<br><br>The =
attached patch fixes this to use BoolGetDatum(), matching both the<br>catal=
og definition and the ALTER path.</div><div><br></div><div>Regards,</div><d=
iv>Lakshmi</div></div>

--0000000000005522a906506a73cd--

--0000000000005522ab06506a73cf
Content-Type: application/octet-stream;
	name="subretentionactive-int32-to-bool.patch"
Content-Disposition: attachment;
	filename="subretentionactive-int32-to-bool.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mogrfh1z0>
X-Attachment-Id: f_mogrfh1z0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3N1YnNjcmlwdGlvbmNtZHMuYyBiL3Ny
Yy9iYWNrZW5kL2NvbW1hbmRzL3N1YnNjcmlwdGlvbmNtZHMuYwppbmRleCBkNTEyZTg3Yy4uMWUx
MGQ5ZDkgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3N1YnNjcmlwdGlvbmNtZHMu
YworKysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9zdWJzY3JpcHRpb25jbWRzLmMKQEAgLTc5Niw3
ICs3OTYsNyBAQCBDcmVhdGVTdWJzY3JpcHRpb24oUGFyc2VTdGF0ZSAqcHN0YXRlLCBDcmVhdGVT
dWJzY3JpcHRpb25TdG10ICpzdG10LAogCXZhbHVlc1tBbnVtX3BnX3N1YnNjcmlwdGlvbl9zdWJt
YXhyZXRlbnRpb24gLSAxXSA9CiAJCUludDMyR2V0RGF0dW0ob3B0cy5tYXhyZXRlbnRpb24pOwog
CXZhbHVlc1tBbnVtX3BnX3N1YnNjcmlwdGlvbl9zdWJyZXRlbnRpb25hY3RpdmUgLSAxXSA9Ci0J
CUludDMyR2V0RGF0dW0ob3B0cy5yZXRhaW5kZWFkdHVwbGVzKTsKKwkJQm9vbEdldERhdHVtKG9w
dHMucmV0YWluZGVhZHR1cGxlcyk7CiAJdmFsdWVzW0FudW1fcGdfc3Vic2NyaXB0aW9uX3N1YnNl
cnZlciAtIDFdID0gT2JqZWN0SWRHZXREYXR1bShzZXJ2ZXJpZCk7CiAJaWYgKCFPaWRJc1ZhbGlk
KHNlcnZlcmlkKSkKIAkJdmFsdWVzW0FudW1fcGdfc3Vic2NyaXB0aW9uX3N1YmNvbm5pbmZvIC0g
MV0gPQo=
--0000000000005522ab06506a73cf--