MIME-Version: 1.0
References: 
 <CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com>
 <CA+HiwqH+0rgMNQDog0AT9dVt0CGjXza_Li80njDhynWqzUwvZw@mail.gmail.com>
 <CA+3i_M8Mq7fr6mUspSa2rLik9+oY4sOeD1qsB_-dvnUB4NrYbg@mail.gmail.com>
 <CA+HiwqFW7uY3Jknf8VzjWoXa1bf0-U6-+JgM+o1ggJ+onyOHHA@mail.gmail.com>
 <976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com>
 <CA+HiwqFenEgD4W1QWnHM0whbzWYH=uS6qQzxvKNH7z503HWvxw@mail.gmail.com>
 <CAE4_qQacVuwviLN3qKMUp20e5B11hJ5rc5qUCLmHENixO1xWhQ@mail.gmail.com>
 <CA+HiwqGf_eQNK_bqJzL7YZvXKhpCWsbxxa6pwYVAhQLcPS0rAQ@mail.gmail.com>
In-Reply-To: 
 <CA+HiwqGf_eQNK_bqJzL7YZvXKhpCWsbxxa6pwYVAhQLcPS0rAQ@mail.gmail.com>
From: Lakshmi N <lakshmin.jhs@gmail.com>
Date: Thu, 16 Apr 2026 21:20:52 -0700
Message-ID: 
 <CA+3i_M_JzLyF14Uf8pbev8pZB6wOWjWnp1QerUz2REDr0PJrxQ@mail.gmail.com>
Subject: Re: Reject invalid databases in pg_get_database_ddl()
To: Amit Langote <amitlangote09@gmail.com>
Cc: Hu Xunqi <huxunqi.08@gmail.com>, Euler Taveira <euler@eulerto.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Type: multipart/alternative; boundary="000000000000ddff6d064fa046d4"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2B3i_M_JzLyF14Uf8pbev8pZB6wOWjWnp1QerUz2REDr0PJrxQ%40mail.gmail.com>
Precedence: bulk

--000000000000ddff6d064fa046d4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Apr 16, 2026 at 8:31=E2=80=AFPM Amit Langote <amitlangote09@gmail.c=
om>
wrote:

> Hi,
>
> On Fri, Apr 17, 2026 at 11:49=E2=80=AFAM Hu Xunqi <huxunqi.08@gmail.com> =
wrote:
> > On Fri, Apr 17, 2026 at 10:16=E2=80=AFAM Amit Langote <amitlangote09@gm=
ail.com>
> wrote:
> > +       /*
> > +        * Reject invalid databases: datconnlimit =3D -2 would be emitt=
ed
> as
> > +        * CONNECTION LIMIT =3D -2, which cannot be executed.
> > +        */
> >
> > This comment looks a bit too centered on datconnlimit=3D-2, but the rea=
l
> issue is that an invalid pg_database row should not be deparsed into DDL.
> So, maybe rephrase like:
> >
> > /*
> > * Reject invalid databases. Deparsing a pg_database row in invalid stat=
e
> > * can produce SQL that is not executable, such as CONNECTION LIMIT =3D =
-2.
> > */
>
> I was trying to be precise about datconnlimit =3D -2 being the thing
> that produces invalid SQL. But your version covers that with the "such
> as CONNECTION LIMIT =3D -2" example, and it's closer to the original,
> which was on the right track, just needed to be more precise. Let's go
> with it.
>

This looks good to me. Thank you for reviewing and making the changes!

Regards,
Lakshmi

--000000000000ddff6d064fa046d4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,</div><br><div class=3D"gmail_quote gm=
ail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Apr 16, =
2026 at 8:31=E2=80=AFPM Amit Langote &lt;<a href=3D"mailto:amitlangote09@gm=
ail.com">amitlangote09@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Hi,<br>
<br>
On Fri, Apr 17, 2026 at 11:49=E2=80=AFAM Hu Xunqi &lt;<a href=3D"mailto:hux=
unqi.08@gmail.com" target=3D"_blank">huxunqi.08@gmail.com</a>&gt; wrote:<br=
>
&gt; On Fri, Apr 17, 2026 at 10:16=E2=80=AFAM Amit Langote &lt;<a href=3D"m=
ailto:amitlangote09@gmail.com" target=3D"_blank">amitlangote09@gmail.com</a=
>&gt; wrote:<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0/*<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Reject invalid databases: datconnlimit =
=3D -2 would be emitted as<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 * CONNECTION LIMIT =3D -2, which cannot b=
e executed.<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 */<br>
&gt;<br>
&gt; This comment looks a bit too centered on datconnlimit=3D-2, but the re=
al issue is that an invalid pg_database row should not be deparsed into DDL=
. So, maybe rephrase like:<br>
&gt;<br>
&gt; /*<br>
&gt; * Reject invalid databases. Deparsing a pg_database row in invalid sta=
te<br>
&gt; * can produce SQL that is not executable, such as CONNECTION LIMIT =3D=
 -2.<br>
&gt; */<br>
<br>
I was trying to be precise about datconnlimit =3D -2 being the thing<br>
that produces invalid SQL. But your version covers that with the &quot;such=
<br>
as CONNECTION LIMIT =3D -2&quot; example, and it&#39;s closer to the origin=
al,<br>
which was on the right track, just needed to be more precise. Let&#39;s go<=
br>
with it.<br></blockquote><div><br></div><div>This looks good to me. Thank y=
ou for=C2=A0reviewing and making the changes!</div><div>=C2=A0</div><div>Re=
gards,</div><div>Lakshmi</div></div></div>

--000000000000ddff6d064fa046d4--