MIME-Version: 1.0
From: Sravan Kumar <sravanvcybage@gmail.com>
Date: Fri, 10 Mar 2023 13:41:07 +0530
Message-ID: <CA+=NbjguiQy-MbVqfQ-jQ=2Fcmx3Zs36OkKb-vjt28jMTG0OOg@mail.gmail.com>
Subject: Compilation error after redesign of the archive modules
To: michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000e6cf7405f6874ffb"
Archived-At: <https://www.postgresql.org/message-id/CA%2B%3DNbjguiQy-MbVqfQ-jQ%3D2Fcmx3Zs36OkKb-vjt28jMTG0OOg%40mail.gmail.com>
Precedence: bulk

--000000000000e6cf7405f6874ffb
Content-Type: text/plain; charset="UTF-8"

Hi,
    With the redesign of the archive modules:
35739b87dcfef9fc0186aca659f262746fecd778 - Redesign archive modules
   if we were to compile basic_archive module with USE_PGXS=1, we get
compilation error:

[]$ make USE_PGXS=1
gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -g -g -O0 -fPIC
-fvisibility=hidden -I. -I./
-I/home/sravanv/work/workspaces/PGdevel_test/include/postgresql/server
-I/home/sravanv/work/workspaces/PGdevel_test/include/postgresql/internal
 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o basic_archive.o
basic_archive.c -MMD -MP -MF .deps/basic_archive.Po
basic_archive.c:33:36: fatal error: archive/archive_module.h: No such
file or directory
 #include "archive/archive_module.h"
                                    ^
compilation terminated.
make: *** [basic_archive.o] Error 1

I have attached a patch that fixes the problem. Can you please review
if it makes sense to push this patch?

-- 
Thanks & Regards,
Sravan Velagandula
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000e6cf7405f6874ffb
Content-Type: application/octet-stream; 
	name="v1-0001-fix-archive-module-compilation-error.patch"
Content-Disposition: attachment; 
	filename="v1-0001-fix-archive-module-compilation-error.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lf29764t0>
X-Attachment-Id: f_lf29764t0

RnJvbSA0OWJmZTY3NTBkNmIxNzA5MjI2NzA4ODA4ODMwMjUxZGRkZjkzNDE0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTcmF2YW4gVmVsYWdhbmR1bGEgPHNyYXZhbi52ZWxhZ2FuZHVs
YUBlbnRlcnByaXNlZGIuY29tPgpEYXRlOiBUaHUsIDkgTWFyIDIwMjMgMDg6MTg6NDMgLTA1MDAK
U3ViamVjdDogW1BBVENIIHYxXSBmaXggYXJjaGl2ZSBtb2R1bGUgY29tcGlsYXRpb24gZXJyb3IK
Ci0tLQogc3JjL2luY2x1ZGUvTWFrZWZpbGUgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl
cnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9NYWtlZmls
ZSBiL3NyYy9pbmNsdWRlL01ha2VmaWxlCmluZGV4IDc0NzJjZDVlMDEuLjU2NTc2ZGNmNWMgMTAw
NjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL01ha2VmaWxlCisrKyBiL3NyYy9pbmNsdWRlL01ha2VmaWxl
CkBAIC0xNyw3ICsxNyw3IEBAIGFsbDogcGdfY29uZmlnLmggcGdfY29uZmlnX2V4dC5oIHBnX2Nv
bmZpZ19vcy5oCiAKIAogIyBTdWJkaXJlY3RvcmllcyBjb250YWluaW5nIGluc3RhbGxhYmxlIGhl
YWRlcnMKLVNVQkRJUlMgPSBhY2Nlc3MgYm9vdHN0cmFwIGNhdGFsb2cgY29tbWFuZHMgY29tbW9u
IGRhdGF0eXBlIFwKK1NVQkRJUlMgPSBhY2Nlc3MgYXJjaGl2ZSBib290c3RyYXAgY2F0YWxvZyBj
b21tYW5kcyBjb21tb24gZGF0YXR5cGUgXAogCWV4ZWN1dG9yIGZlX3V0aWxzIGZvcmVpZ24gaml0
IFwKIAlsaWIgbGlicHEgbWIgbm9kZXMgb3B0aW1pemVyIHBhcnNlciBwYXJ0aXRpb25pbmcgcG9z
dG1hc3RlciBcCiAJcmVnZXggcmVwbGljYXRpb24gcmV3cml0ZSBcCi0tIAoyLjM4LjEKCg==
--000000000000e6cf7405f6874ffb--