Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uHgb2-007Qmp-MT for pgsql-hackers@arkaria.postgresql.org; Wed, 21 May 2025 10:22:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uHgb1-005Q45-I6 for pgsql-hackers@arkaria.postgresql.org; Wed, 21 May 2025 10:22:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uHgb1-005Q3s-8r for pgsql-hackers@lists.postgresql.org; Wed, 21 May 2025 10:22:47 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uHgay-0007Ci-26 for pgsql-hackers@postgresql.org; Wed, 21 May 2025 10:22:46 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-7424ccbef4eso6577236b3a.2 for ; Wed, 21 May 2025 03:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747822963; x=1748427763; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6Xvow/sdi+G7iJPH1BG2W5DoZjw8CZtIlmwy+1kGSUs=; b=fF8RVh9uidyTMbLLYdwZjqAEcszYhXXWHR3Ff32Wh1HDKGPh48g4lU73iocn5oQGgR kGZih0kKvFc2IHcRRTST00Cm4shV+2ECc5Ixv1Whnko8FYLT65c8f+jsdqy6TBr8wqKr qfIdlruBV8JKllcRyoDsOT5ISTQi/Jd7ZCzpgYNZBvSemnsbT0x9PRUY8JZX458En1FF PDf4BzBQ7xm6T1EMm2oHLb1MlMkYPag74uYj13UPQkWwwb/8WcYtO7LYTihw4LwWyeaW v35xLNVXdElacJOLa4qKkZELoGwd9Fxl/LAB8J4+TZYZHLgXEElyqWZGw7VCmquCFL+J sUEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747822963; x=1748427763; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Xvow/sdi+G7iJPH1BG2W5DoZjw8CZtIlmwy+1kGSUs=; b=tXqSTSFqdNEM7n1dW5geZjaG2FSNu0dVmCWhHf+yzACDOfQ0t0o6XvOOAKur+aopHe CR1+DtjTv8BNfMnuHqMoTxQehPX90PdD49OAGiZVcpdU+nyXuKI4n/Ds/HyJIj5099jt XTK+HNzrBWfeQVc6eEY6v9YMc4cPfGrHKoAyw8Wg7FRnmRPlWn+yqfqWM8S4JS3HD0cV 3b3kt4Du1S0/QIytXIt/Ib/TRnVHLpPHLS6YsuxIaZlna9D8Nsx0pCFD6gPPUmGWTnG3 D9tw66JRIT2Kj8gTwwCTuqGsu+eJ7M/wD1Ob1iwgw9jLsV+R/4Og6n0ljf3MFfn3ebYn X3mw== X-Forwarded-Encrypted: i=1; AJvYcCUnWcsXZGE8qp0JqaqYfE22xjAle5XcZ1S9vQ/5t0HO7YdP2fWMQh04fiddt7TJuee1zxgDsuoIJOTANCnq@postgresql.org X-Gm-Message-State: AOJu0YyXWd+9sBeT39EYaegrEDW9aXhsZQvSlpIlNY9YAEoIzwl/7+H0 bzqn737LCz1W03TSQWpLCophximLj35z9yNYK7rhhHaj77zvQhwiffglzR7PiV5eaXqEAEzjp0K dCSiXYpZ1aBYtpl9OTOCGbh5juSaiNjU= X-Gm-Gg: ASbGnctFNOMFX55LCERoZrqLkY65PGAHVhVWBJmwv+VrPJM6Otr8X388eNxlP4XMW04 S8VSZTwpk9b3lMrAbsuP0Xx3IvFqZlEofpO3LDSfxwDpS/Z/pWWBAjtYaSTlNFoQW3qH8mF2SE3 zTcsuGF0tZ6RwAJGKbnvKjluI6fz4v0FW2iQ== X-Google-Smtp-Source: AGHT+IGNlETBfUG1wV7Wsf+E6GLaXiXBj8u7LVG0P5740GVtvbOoF953bOigUfo+12iN/3LYyFTyOthzWSc7JVKSsOY= X-Received: by 2002:a17:90a:d40d:b0:30a:883a:ea5b with SMTP id 98e67ed59e1d1-30e7d545032mr38856991a91.17.1747822962911; Wed, 21 May 2025 03:22:42 -0700 (PDT) MIME-Version: 1.0 References: <605328.1747710381@sss.pgh.pa.us> <668eb809-cf43-4d93-b1a7-04d9f865960b@vondra.me> In-Reply-To: <668eb809-cf43-4d93-b1a7-04d9f865960b@vondra.me> From: Amit Langote Date: Wed, 21 May 2025 19:22:26 +0900 X-Gm-Features: AX0GCFv4G2fMYejhJL3HPHwL0iTkPZogCciIT11M0wM_1_jEQ5dfdy32xBXmjHk Message-ID: Subject: Re: generic plans and "initial" pruning To: Tomas Vondra Cc: Tom Lane , Tender Wang , Alexander Lakhin , Robert Haas , Alvaro Herrera , Andres Freund , Daniel Gustafsson , David Rowley , PostgreSQL Hackers , Thom Brown Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 21, 2025 at 3:44=E2=80=AFAM Tomas Vondra wrot= e: > On 5/20/25 05:06, Tom Lane wrote: > > Amit Langote writes: > >> Pushed after some tweaks to comments and the test case. > > > > My attention was drawn to commit 525392d57 after observing that > > Valgrind complained about a memory leak in some code that commit added > > to BuildCachedPlan(). I tried to make sense of said code so I could > > remove the leak, and eventually arrived at the attached patch, which > > is part of a series of leak-fixing things hence the high sequence > > number. > > > > Unfortunately, the bad things I speculated about in the added comments > > seem to be reality. The second attached file is a test case that > > triggers > > > > ... > > FYI I added this as a PG18 open item: > > https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items Thanks Tomas. --=20 Thanks, Amit Langote