public inbox for [email protected]  

help / color / mirror / Atom feed
From: Amit Langote <[email protected]>
To: Sandro Santilli <[email protected]>
To: Amit Langote <[email protected]>
To: Tomas Vondra <[email protected]>
To: Junwang Zhao <[email protected]>
To: Pavel Stehule <[email protected]>
To: PostgreSQL-development <[email protected]>
Subject: Re: Eliminating SPI / SQL from some RI triggers - take 3
Date: Fri, 10 Apr 2026 13:14:11 +0900
Message-ID: <CA+HiwqEdaCZMsLeLowxYpkWGZJgiVXW3vA3H+syDguCtj06ziw@mail.gmail.com> (raw)
In-Reply-To: <adfNduaufvWpIqbN@oli>
References: <CA+HiwqGA5Ay_MR0eJEEbt4j6WrVh4F+AasTp8yCbs5aJLOJn6Q@mail.gmail.com>
	<CAEG8a3JM=NoqiTK0V6S9FNxZPvy1+C5F7rfafTtPKBVWnunL-g@mail.gmail.com>
	<CA+HiwqEyiLCY6MTLbOJXDdLNNQLaURYHvdW797MQgbjEK9od4Q@mail.gmail.com>
	<CAEG8a3+VBpwPf1Rm-ECD90whM9b3YnGhux5CVXdsL6khiBfzRQ@mail.gmail.com>
	<CA+HiwqF2UHzF0sKCp-F2a-U29rqh_9ZPy=f1h+Fh_=M8efj3pg@mail.gmail.com>
	<[email protected]>
	<CA+HiwqE9O6i-h4TUr4A15m06vFedsQROooYgQ69Hx+DR-f+-ug@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+HiwqHN0FQbyndiB4bApV8gEZ_tQBC_jr836HL=Mv_ZxK1+Pg@mail.gmail.com>
	<adfNduaufvWpIqbN@oli>

Hi Sandro,

On Fri, Apr 10, 2026 at 1:02 AM Sandro Santilli <[email protected]> wrote:
> On Thu, Apr 09, 2026 at 08:55:01PM +0900, Amit Langote wrote:
> > Hi Sandro,
> >
> > On Thu, Apr 9, 2026 at 8:07 PM Sandro Santilli <[email protected]> wrote:
> > > On Mon, Mar 02, 2026 at 01:34:41PM +0100, Tomas Vondra wrote:
> > > >
> > > > TBH I haven't noticed the memory context issue myself, I only noticed
> > > > because the builds with index prefetch started crashing.
> > >
> > > We're getting a crash in PostGIS too, since that commit was merged into
> > > the master branch, see https://trac.osgeo.org/postgis/ticket/6066
> > >
> > > The crash is triggered a C function using SPI.
> >
> > Evan Montgomery-Recht posted a report of the same issue on this thread
> > a couple of days ago.
>
> I confirm the patch attached in Evan's email [1] fixes the crash for us.
>
> [1] https://www.postgresql.org/message-id/CAEg7pwcKf01FmDqFAf-Hzu_pYnMYScY_Otid-pe9uw3BJ6gq9g%40mail.gma...
>
> > I have posted a patch to fix the issue, which I will commit tomorrow
> > after a bit more testing.
>
> I also confirm your patch v4-0001-Fix-RI-fast-path-crash-under-nested-C-level-SPI.patch
> fixes the crash for us. Thank you !

Thanks for confirming that.

> Let me know when it is time to test again against master.

I have just pushed 0001 which you'll find in master as 34a3078629.

-- 
Thanks, Amit Langote





view thread (63+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Eliminating SPI / SQL from some RI triggers - take 3
  In-Reply-To: <CA+HiwqEdaCZMsLeLowxYpkWGZJgiVXW3vA3H+syDguCtj06ziw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox