MIME-Version: 1.0
References: 
 <CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com>
 <CA+HiwqH+0rgMNQDog0AT9dVt0CGjXza_Li80njDhynWqzUwvZw@mail.gmail.com>
 <CA+3i_M8Mq7fr6mUspSa2rLik9+oY4sOeD1qsB_-dvnUB4NrYbg@mail.gmail.com>
 <CA+HiwqFW7uY3Jknf8VzjWoXa1bf0-U6-+JgM+o1ggJ+onyOHHA@mail.gmail.com>
 <976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com>
 <CA+HiwqFenEgD4W1QWnHM0whbzWYH=uS6qQzxvKNH7z503HWvxw@mail.gmail.com>
 <CAE4_qQacVuwviLN3qKMUp20e5B11hJ5rc5qUCLmHENixO1xWhQ@mail.gmail.com>
 <CA+HiwqGf_eQNK_bqJzL7YZvXKhpCWsbxxa6pwYVAhQLcPS0rAQ@mail.gmail.com>
 <CA+3i_M_JzLyF14Uf8pbev8pZB6wOWjWnp1QerUz2REDr0PJrxQ@mail.gmail.com>
In-Reply-To: 
 <CA+3i_M_JzLyF14Uf8pbev8pZB6wOWjWnp1QerUz2REDr0PJrxQ@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Fri, 17 Apr 2026 13:22:19 +0900
Message-ID: 
 <CA+HiwqFLfgoPGdCAiG-Txbbv9WduyQ9UoVDa14U5Mj1XMAqaQA@mail.gmail.com>
Subject: Re: Reject invalid databases in pg_get_database_ddl()
To: Lakshmi N <lakshmin.jhs@gmail.com>
Cc: Hu Xunqi <huxunqi.08@gmail.com>, Euler Taveira <euler@eulerto.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqFLfgoPGdCAiG-Txbbv9WduyQ9UoVDa14U5Mj1XMAqaQA%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 17, 2026 at 1:21=E2=80=AFPM Lakshmi N <lakshmin.jhs@gmail.com> =
wrote:
> On Thu, Apr 16, 2026 at 8:31=E2=80=AFPM Amit Langote <amitlangote09@gmail=
.com> wrote:
>> On Fri, Apr 17, 2026 at 11:49=E2=80=AFAM Hu Xunqi <huxunqi.08@gmail.com>=
 wrote:
>> > On Fri, Apr 17, 2026 at 10:16=E2=80=AFAM Amit Langote <amitlangote09@g=
mail.com> wrote:
>> > +       /*
>> > +        * Reject invalid databases: datconnlimit =3D -2 would be emit=
ted as
>> > +        * CONNECTION LIMIT =3D -2, which cannot be executed.
>> > +        */
>> >
>> > This comment looks a bit too centered on datconnlimit=3D-2, but the re=
al issue is that an invalid pg_database row should not be deparsed into DDL=
. So, maybe rephrase like:
>> >
>> > /*
>> > * Reject invalid databases. Deparsing a pg_database row in invalid sta=
te
>> > * can produce SQL that is not executable, such as CONNECTION LIMIT =3D=
 -2.
>> > */
>>
>> I was trying to be precise about datconnlimit =3D -2 being the thing
>> that produces invalid SQL. But your version covers that with the "such
>> as CONNECTION LIMIT =3D -2" example, and it's closer to the original,
>> which was on the right track, just needed to be more precise. Let's go
>> with it.
>
> This looks good to me. Thank you for reviewing and making the changes!

Pushed.

--=20
Thanks, Amit Langote