MIME-Version: 1.0
References: 
 <CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com>
 <CA+HiwqH+0rgMNQDog0AT9dVt0CGjXza_Li80njDhynWqzUwvZw@mail.gmail.com>
 <CA+3i_M8Mq7fr6mUspSa2rLik9+oY4sOeD1qsB_-dvnUB4NrYbg@mail.gmail.com>
 <CA+HiwqFW7uY3Jknf8VzjWoXa1bf0-U6-+JgM+o1ggJ+onyOHHA@mail.gmail.com>
 <976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com>
In-Reply-To: <976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Fri, 17 Apr 2026 11:15:39 +0900
Message-ID: 
 <CA+HiwqFenEgD4W1QWnHM0whbzWYH=uS6qQzxvKNH7z503HWvxw@mail.gmail.com>
Subject: Re: Reject invalid databases in pg_get_database_ddl()
To: Euler Taveira <euler@eulerto.com>
Cc: Lakshmi N <lakshmin.jhs@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Type: multipart/mixed; boundary="0000000000007d7389064f9e87da"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqFenEgD4W1QWnHM0whbzWYH%3DuS6qQzxvKNH7z503HWvxw%40mail.gmail.com>
Precedence: bulk

--0000000000007d7389064f9e87da
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 17, 2026 at 10:47=E2=80=AFAM Euler Taveira <euler@eulerto.com> =
wrote:
> On Thu, Apr 16, 2026, at 8:46 PM, Amit Langote wrote:
> >
> > Thanks.  Will push the attached shortly.
>
> I think the errhint() is excessive in this context. It makes sense if you=
 are
> executing ALTER DATABASE, for example.

Yeah, agreed.

> I suggest a message like
>
>   database \"%s\" is an invalid database

Or just drop it, because the errmsg already says "invalid database %s".

> Regarding the test case suggested by Japin Li, I don't think it is worth =
because
> it is a transient state (unless something bad happened and pg_database co=
ntains
> a dangling row.)

Agreed.

Patch updated.

--=20
Thanks, Amit Langote

--0000000000007d7389064f9e87da
Content-Type: application/octet-stream;
	name="v3-0001-Reject-invalid-databases-in-pg_get_database_ddl.patch"
Content-Disposition: attachment;
	filename="v3-0001-Reject-invalid-databases-in-pg_get_database_ddl.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo29ymdd0>
X-Attachment-Id: f_mo29ymdd0

RnJvbSAzNjA3ZjYwNTA5NDdhZTk4NmRjMTg2MjQzNjg1ZWIxZGNmYzg1MzBlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWl0IExhbmdvdGUgPGFtaXRsYW5AcG9zdGdyZXNxbC5vcmc+
CkRhdGU6IEZyaSwgMTcgQXByIDIwMjYgMTE6MTE6MDQgKzA5MDAKU3ViamVjdDogW1BBVENIIHYz
XSBSZWplY3QgaW52YWxpZCBkYXRhYmFzZXMgaW4gcGdfZ2V0X2RhdGFiYXNlX2RkbCgpCgpBbiBp
bnZhbGlkIGRhdGFiYXNlIGhhcyBkYXRjb25ubGltaXQgc2V0IHRvIC0yLiAgcGdfZ2V0X2RhdGFi
YXNlX2RkbCgpCmVtaXRzIHRoaXMgdmVyYmF0aW0gYXMgQ09OTkVDVElPTiBMSU1JVCA9IC0yLCB3
aGljaCBBTFRFUiBEQVRBQkFTRQpyZWplY3RzLiAgRXJyb3Igb3V0IGVhcmx5IGluc3RlYWQuCgpS
ZXBvcnRlZC1ieTogTGFrc2htaSBOIDxsYWtzaG1pbi5qaHNAZ21haWwuY29tPgpBdXRob3I6IExh
a3NobWkgTiA8bGFrc2htaW4uamhzQGdtYWlsLmNvbT4KUmV2aWV3ZWQtYnk6IEFtaXQgTGFuZ290
ZSA8YW1pdGxhbmdvdGUwOUBnbWFpbC5jb20+ClJldmlld2VkLWJ5OiBFdWxlciBUYXZlaXJhIDxl
dWxlckBldWxlcnRvLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9DQSszaV9N
OG0xazJnRmNoK3RVMEptQVFoOUZSVitwRnJmVFhEckpvK0JxbXdzVG1PaGdAbWFpbC5nbWFpbC5j
b20KLS0tCiBzcmMvYmFja2VuZC91dGlscy9hZHQvZGRsdXRpbHMuYyB8IDEwICsrKysrKysrKysK
IDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tl
bmQvdXRpbHMvYWR0L2RkbHV0aWxzLmMgYi9zcmMvYmFja2VuZC91dGlscy9hZHQvZGRsdXRpbHMu
YwppbmRleCBjNGY5Zjg2YzQzZS4uZmUzODExNzIxM2IgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5k
L3V0aWxzL2FkdC9kZGx1dGlscy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9kZGx1dGls
cy5jCkBAIC04ODcsNiArODg3LDE2IEBAIHBnX2dldF9kYXRhYmFzZV9kZGxfaW50ZXJuYWwoT2lk
IGRiaWQsIGJvb2wgcHJldHR5LAogCWRiZm9ybSA9IChGb3JtX3BnX2RhdGFiYXNlKSBHRVRTVFJV
Q1QodHVwbGUpOwogCWRibmFtZSA9IHBzdHJkdXAoTmFtZVN0cihkYmZvcm0tPmRhdG5hbWUpKTsK
IAorCS8qCisJICogUmVqZWN0IGludmFsaWQgZGF0YWJhc2VzOiBkYXRjb25ubGltaXQgPSAtMiB3
b3VsZCBiZSBlbWl0dGVkIGFzCisJICogQ09OTkVDVElPTiBMSU1JVCA9IC0yLCB3aGljaCBjYW5u
b3QgYmUgZXhlY3V0ZWQuCisJICovCisJaWYgKGRhdGFiYXNlX2lzX2ludmFsaWRfZm9ybShkYmZv
cm0pKQorCQllcmVwb3J0KEVSUk9SLAorCQkJCShlcnJjb2RlKEVSUkNPREVfT0JKRUNUX05PVF9J
Tl9QUkVSRVFVSVNJVEVfU1RBVEUpLAorCQkJCSBlcnJtc2coImNhbm5vdCBnZW5lcmF0ZSBEREwg
Zm9yIGludmFsaWQgZGF0YWJhc2UgXCIlc1wiIiwKKwkJCQkJCWRibmFtZSkpKTsKKwogCS8qCiAJ
ICogV2UgZG9uJ3Qgc3VwcG9ydCBnZW5lcmF0aW5nIERETCBmb3Igc3lzdGVtIGRhdGFiYXNlcy4g
IFRoZSBwcmltYXJ5CiAJICogcmVhc29uIGZvciB0aGlzIGlzIHRoYXQgdXNlcnMgc2hvdWxkbid0
IGJlIHJlY3JlYXRpbmcgdGhlbS4KLS0gCjIuNDcuMwoK
--0000000000007d7389064f9e87da--