Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rPgFj-00DLGl-2F for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jan 2024 10:01:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rPgFh-002li3-JI for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jan 2024 10:01:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rPgFh-002lhv-A3 for pgsql-hackers@lists.postgresql.org; Tue, 16 Jan 2024 10:01:01 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rPgFa-0025wZ-0U for pgsql-hackers@postgresql.org; Tue, 16 Jan 2024 10:01:00 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5ce10b5ee01so6945044a12.1 for ; Tue, 16 Jan 2024 02:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705399251; x=1706004051; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d+b5BiT7ayG46DSIfDZXHb18SwutZ/TP5d3UfPWsbY4=; b=HvTRA6tb1PwQjZ3KDxhvPILP35gUfzJutONqfw+7O4py1IALAR6K4VoJ4122BZJQvF G4iYaEwtcEj8vQTvcnfCEf90JuG0cQkd6Aym9tp9SpaqBaOEp1siGvXnS2NZgeIQWZq6 5OHBPWYRyHzbZPrIwFfp+7FREM8IpJJ0Z05301I8U5UFQRqIgz1wXGqajfLi4cQmvqj0 2+T/JBAeZnadf9TgqKewOlD/kdHN8F88Z9ZcPTz0bU6xeiUOJjWawZblT40Swfb4xjPu 5+LzGGO1As0xSAiI7Yz3pOeFVIaP+s6drhTH1bDyC7xnRib4sjwXJFotYA+lOynhZ9/u K0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705399251; x=1706004051; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d+b5BiT7ayG46DSIfDZXHb18SwutZ/TP5d3UfPWsbY4=; b=LWoWogZeh65KBHdMAig51L1z9Ikf/c/w6Afjzvv/s/+alV0BZ7V7254ukgl1SbaBMY 8P+/lkdUnGOzgr+VV3AtGTaWovvmNkxncaqEoE3fLlU/rrITy3eDYBOWaQ7i3jACMRma dudUkIuKpfjh4YUUzdfH4z0hq/f93fRTzTDjM+bUi15q3izoZHSFi+gl4/ltMhNzFLDg GtkPplab0oTBO+k0b37BL/5214XYqKn10oqss+q6welkgDaRDbR+OuCCV8W5DC5ptkn8 /Bv2GcPsDuyXqqmn/0N1/DRtKeyfqcTXSHlC+2/6Tzfx8tQE1LFB9GilV+NQOhpC5dtt 7i7w== X-Gm-Message-State: AOJu0YwMq9Lk+VbqTYFIoPrL49scKsbppNd5mqIDNdNlY94C2d5+0xMC 5tTyYmyNHhXOMcvO8QbR5hj2RYXo3s+UuHihX9U= X-Google-Smtp-Source: AGHT+IF3jsWjG5tux6DMBoKvusoYLXMzbW1jUhhy/NCKdSWVMQykL411qWj/flEiFzWZfL8ppvnwuyXuzCXUGOp3OWM= X-Received: by 2002:a17:90b:11c5:b0:28b:d560:d44a with SMTP id gv5-20020a17090b11c500b0028bd560d44amr10941830pjb.44.1705399251395; Tue, 16 Jan 2024 02:00:51 -0800 (PST) MIME-Version: 1.0 References: <202312071051.cpxujwos4tlj@alvherre.pgsql> <20231208173014.2qycwc6kjqf6zlck@awork3.anarazel.de> In-Reply-To: From: Amit Langote Date: Tue, 16 Jan 2024 19:00:29 +0900 Message-ID: Subject: Re: remaining sql/json patches To: jian he Cc: Andres Freund , Alvaro Herrera , Erik Rijkers , Andrew Dunstan , PostgreSQL-development Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, Thought I'd share an update. I've been going through Jian He's comments (thanks for the reviews!), most of which affect the last JSON_TABLE() patch and in some cases the query functions patch (0007). It seems I'll need to spend a little more time, especially on the JSON_TABLE() patch, as I'm finding things to improve other than those mentioned in the comments. As for the preliminary patches 0001-0006, I'm thinking that it would be a good idea to get them out of the way sooner rather than waiting till the main patches are in perfect shape. I'd like to get them committed by next week after a bit of polishing, so if anyone would like to take a look, please let me know. I'll post a new set tomorrow. 0007, the query functions patch, also looks close to ready, though I might need to change a few things in it as I work through the JSON_TABLE() changes. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com