MIME-Version: 1.0
References: 
 <CA+HiwqGA5Ay_MR0eJEEbt4j6WrVh4F+AasTp8yCbs5aJLOJn6Q@mail.gmail.com>
 <CAEG8a3JM=NoqiTK0V6S9FNxZPvy1+C5F7rfafTtPKBVWnunL-g@mail.gmail.com>
 <CA+HiwqEyiLCY6MTLbOJXDdLNNQLaURYHvdW797MQgbjEK9od4Q@mail.gmail.com>
 <CAEG8a3+VBpwPf1Rm-ECD90whM9b3YnGhux5CVXdsL6khiBfzRQ@mail.gmail.com>
 <CA+HiwqF2UHzF0sKCp-F2a-U29rqh_9ZPy=f1h+Fh_=M8efj3pg@mail.gmail.com>
 <43b56e3b-80d6-4a45-a313-cb1caa587b22@vondra.me>
 <CA+HiwqE9O6i-h4TUr4A15m06vFedsQROooYgQ69Hx+DR-f+-ug@mail.gmail.com>
 <1290fac7-8430-4d2c-bfcb-00c65adff5e5@vondra.me>
 <adeIhgpWq22E5kwW@hst.kbt.io>
 <CA+HiwqHN0FQbyndiB4bApV8gEZ_tQBC_jr836HL=Mv_ZxK1+Pg@mail.gmail.com>
 <adfNduaufvWpIqbN@oli>
 <CA+HiwqEdaCZMsLeLowxYpkWGZJgiVXW3vA3H+syDguCtj06ziw@mail.gmail.com>
 <C0DB373C-F9E2-4204-BCAC-4256FCAA498B@gmail.com>
In-Reply-To: <C0DB373C-F9E2-4204-BCAC-4256FCAA498B@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Fri, 10 Apr 2026 13:21:37 +0900
Message-ID: 
 <CA+HiwqGGUiR2SX==YD3Xb18q81A5hHGvr+Rm5Ljzo4-kUO0rRA@mail.gmail.com>
Subject: Re: Eliminating SPI / SQL from some RI triggers - take 3
To: Chao Li <li.evan.chao@gmail.com>
Cc: Sandro Santilli <strk@kbt.io>, Tomas Vondra <tomas@vondra.me>,
 Junwang Zhao <zhjwpku@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
 jie wang <jugierwang@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqGGUiR2SX%3D%3DYD3Xb18q81A5hHGvr%2BRm5Ljzo4-kUO0rRA%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 10, 2026 at 1:21=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:
> > On Apr 10, 2026, at 12:14, Amit Langote <amitlangote09@gmail.com> wrote=
:
> >
> > Hi Sandro,
> >
> > On Fri, Apr 10, 2026 at 1:02=E2=80=AFAM Sandro Santilli <strk@kbt.io> w=
rote:
> >> On Thu, Apr 09, 2026 at 08:55:01PM +0900, Amit Langote wrote:
> >>> Hi Sandro,
> >>>
> >>> On Thu, Apr 9, 2026 at 8:07=E2=80=AFPM Sandro Santilli <strk@kbt.io> =
wrote:
> >>>> On Mon, Mar 02, 2026 at 01:34:41PM +0100, Tomas Vondra wrote:
> >>>>>
> >>>>> TBH I haven't noticed the memory context issue myself, I only notic=
ed
> >>>>> because the builds with index prefetch started crashing.
> >>>>
> >>>> We're getting a crash in PostGIS too, since that commit was merged i=
nto
> >>>> the master branch, see https://trac.osgeo.org/postgis/ticket/6066
> >>>>
> >>>> The crash is triggered a C function using SPI.
> >>>
> >>> Evan Montgomery-Recht posted a report of the same issue on this threa=
d
> >>> a couple of days ago.
> >>
> >> I confirm the patch attached in Evan's email [1] fixes the crash for u=
s.
> >>
> >> [1] https://www.postgresql.org/message-id/CAEg7pwcKf01FmDqFAf-Hzu_pYnM=
YScY_Otid-pe9uw3BJ6gq9g%40mail.gmail.com
> >>
> >>> I have posted a patch to fix the issue, which I will commit tomorrow
> >>> after a bit more testing.
> >>
> >> I also confirm your patch v4-0001-Fix-RI-fast-path-crash-under-nested-=
C-level-SPI.patch
> >> fixes the crash for us. Thank you !
> >
> > Thanks for confirming that.
> >
> >> Let me know when it is time to test again against master.
> >
> > I have just pushed 0001 which you'll find in master as 34a3078629.
> >
> > --
> > Thanks, Amit Langote
>
> Hi Amit, looks like you missed to fix the typo that Jie pointed out. In 3=
4a307862930056e1976471d6d81a5e2efc148df,
> ```
> + bool firing_batch_callbacks; /* true when in
> + * FireAfterTriggersBatchCallbacks() */
> ```
> The typo is still there.

Yep, my bad.  Will push a fix shortly.

--=20
Thanks, Amit Langote