Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sl2I5-004f7U-OK for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Sep 2024 08:20:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sl2I4-00ADTU-UR for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Sep 2024 08:20:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sl2I4-00ADTM-Ki for pgsql-hackers@lists.postgresql.org; Mon, 02 Sep 2024 08:20:00 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sl2I2-000GZ7-Iw for pgsql-hackers@postgresql.org; Mon, 02 Sep 2024 08:20:00 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2d88edf1340so1051283a91.1 for ; Mon, 02 Sep 2024 01:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725265196; x=1725869996; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RWVJt83/iJyqQThufHUZmp4mK9nxWlrgdZ0GT5HWlL4=; b=fEjSNdCt0Yw7SbNq0xCcPAcUXtjACPUmh8sPRUjC33ALH3NqBXyT/qebgGkBtyzxFn IFihwhNye+rcj9AN/2Ym3OM3PyJr8RV3Rje7CI65iN83K16KpTZOBocezq3kF+tinj+g GcEG22SyffPMmxJtOHuuLxDNupcIcfgZPywNnotayuZB6XOy5wBiV54ZL/U8u1vd5TKi Aeql9nigi4XTEhQfkFJSJIhUJkBPHJHSM3ITZV0dteF2igLCq/gzp/FJ38kwrwUxNmbO g6iNSDkqRIsRBQaDUAEA2yjwF5pNrGIJ8zbVV5H9d8q8VQpgy0cUjDZEy1/6QJWg/e1s Qw1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725265196; x=1725869996; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RWVJt83/iJyqQThufHUZmp4mK9nxWlrgdZ0GT5HWlL4=; b=ujUTg5h8ZPq0LM2FgX7Dq6xu6zj1wkSrPDoItOAlgoeOMKhHaVvgFnhWAmCC+XO4dA 7hGBSl3nyAOT/yZtBLlfdF7HtmLBxN8oFqKj1IoHj5xA3MeIfA30rEONRBhC0fvK+pCn LoOoJbrhf8PIFnqqol7Zhlzy2Xc5H4kt1rU3Ia9iHaWAd1PZD78iRdeXequq3WCAoMW9 j+qdbkrV1oAsfteS0oXHqxni1bRjna6JeUji7wB/oiCjBXPcAsfiblrGG0QebHDT4TJ+ G7jGWKEOvN82FqN70aLfipL0/YxP/0rAL2Sh8F94NL34ASAMnLbcF1QLkVnH6/qRXHYA GOLQ== X-Forwarded-Encrypted: i=1; AJvYcCXJIpvw3AxqG91X9EE5l9Q/qD/nDsyUi7zGTpB/YqvJzMZ05Tp0Splvt1K/9CWf2b8oQSmxyNiYmuy+WB3Y@postgresql.org X-Gm-Message-State: AOJu0YyHNMd08pRDQVXxFh2KQtLPa/awX20ajStakQJhF4itBe7ous6f AzDvNtqT3Lo/OrBci/CRtVYnGsnhqM1PLbJjXLdJdby+TFqjr5Z+1SVqvqEeZdY/z2MHYfmtmnK NQSi8Mb0JMHnGT/bDNwJ9TA2k/ro= X-Google-Smtp-Source: AGHT+IGIG1X+QtHcKszOl1eoro9vUggTF0+zpCEKm3UlP8Mep+ai+bb8dl0Sp1t3mCUr0J3drLW+ftn3s9t+WyLk5Po= X-Received: by 2002:a17:90a:178d:b0:2d8:f12f:6bed with SMTP id 98e67ed59e1d1-2d8f12f6c3fmr815284a91.3.1725265196180; Mon, 02 Sep 2024 01:19:56 -0700 (PDT) MIME-Version: 1.0 References: <202406191709.jbvpf7d7hl6g@alvherre.pgsql> In-Reply-To: From: Amit Langote Date: Mon, 2 Sep 2024 17:19:39 +0900 Message-ID: Subject: Re: generic plans and "initial" pruning To: Junwang Zhao Cc: Robert Haas , Alvaro Herrera , Andres Freund , Daniel Gustafsson , David Rowley , PostgreSQL Hackers , Thom Brown , Tom Lane Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Aug 31, 2024 at 9:30=E2=80=AFPM Junwang Zhao wr= ote: > @@ -1241,7 +1244,7 @@ GetCachedPlan(CachedPlanSource *plansource, > ParamListInfo boundParams, > if (customplan) > { > /* Build a custom plan */ > - plan =3D BuildCachedPlan(plansource, qlist, boundParams, queryEnv); > + plan =3D BuildCachedPlan(plansource, qlist, boundParams, queryEnv, true= ); > > Is the *true* here a typo? Seems it should be *false* for custom plan? That's correct, thanks for catching that. Will fix. --=20 Thanks, Amit Langote