MIME-Version: 1.0
References: 
 <CAHg+QDdDrdqMr98a_OBYDYmK3RaT7XwCEShZfvDYKZpZTfOEjQ@mail.gmail.com>
 <CA+HiwqFMboUmHtoGjpLfNAWKitjA4T=jnfca9QrYvoBWrrmY0g@mail.gmail.com>
In-Reply-To: 
 <CA+HiwqFMboUmHtoGjpLfNAWKitjA4T=jnfca9QrYvoBWrrmY0g@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Thu, 16 Apr 2026 14:17:08 +0900
Message-ID: 
 <CA+HiwqGLK2QzHFZcwJ-+CbNy7BFB2=G_Ce0eSfPzCOGg6+=USw@mail.gmail.com>
Subject: Re: pg_overexplain produces invalid JSON with RANGE_TABLE option
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqGLK2QzHFZcwJ-%2BCbNy7BFB2%3DG_Ce0eSfPzCOGg6%2B%3DUSw%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 16, 2026 at 9:06=E2=80=AFAM Amit Langote <amitlangote09@gmail.c=
om> wrote:
> On Thu, Apr 16, 2026 at 6:36=E2=80=AFAM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> >
> > Hi Hackers,
> >
> > It appears that pg_overexplain produces invalid JSON output when
> > EXPLAIN (FORMAT JSON, RANGE_TABLE) is used. The "Unprunable RTIs" and
> > "Result RTIs" properties are emitted as key:value pairs directly inside
> > the "Range Table" JSON array, which is structurally invalid.
>
> Thanks for the report and the patch.  That makes sense.
>
> > Attempted to fix this by moving ExplainCloseGroup() before the two over=
explain_bitmapset()
> > calls, so the properties are emitted as siblings of "Range Table" in th=
e parent object rather
> > than inside the array.
> >
> > Attached a patch to address this which also includes a test.
>
> I have added a commit message.  Will commit shortly to master and v18.

Pushed.

--=20
Thanks, Amit Langote