MIME-Version: 1.0
References: <CA+HiwqFpZ80UJKr4tZus4Omgg7YESzFXKSwSHRW2Ap2=XSVyUA@mail.gmail.com>
 <CA+HiwqH45ZCQkWoLzjOyS6bQ9QsF7yDCKVwiEUtB_RwPFwLmQg@mail.gmail.com>
 <CA+HiwqHRRFQN6yZ54fBydOTM6ncqZBCmewZ6n519RjRdDsO44g@mail.gmail.com>
 <54c35fb9-da3a-4754-ab8c-46ed0b612465@vondra.me> <CA+HiwqH8N-SxEB6SysEBsYNgV_KJs66k9Z2SNmqVzbBP-60yWg@mail.gmail.com>
 <684c70d7-180e-461d-9377-600c2db581ba@vondra.me> <CA+HiwqEmG9YCQvG6uux7sO=jKFSAW6hA4Ea-ymfD+JhJAe4PWQ@mail.gmail.com>
 <CA+HiwqE2FfJfH=siLiR3kJ13tmXZORAGTWsZc2r52o1_5BDv+g@mail.gmail.com>
 <bfcc1b78-aa39-4356-8f42-b8cfb9733d6e@vondra.me> <CA+HiwqFhkpXHAA=4NY5SqYXX08uq=nYtXcSByNZF=2MAy1UA7A@mail.gmail.com>
 <CA+HiwqHCcSoYfpMjFshaU1bj6NjreiDvMSDpVSeBmqk-kbWrPw@mail.gmail.com>
 <CA+HiwqHOejJk0_qMuM5g38h70hY_JvHMAKwnH3k=urfTXauPQA@mail.gmail.com>
 <CA+HiwqFsGKM82oaMby3VWYXf_XFpDAMeT+6SXgj-45HpTrS1dA@mail.gmail.com>
 <CA+HiwqFA5hUWYktt3VMh4zQOYMxqH-MpdX8eemfM+o-9dY-zbQ@mail.gmail.com>
 <CA+HiwqEn7bbUXaXO=SmUujBjJSHfS31cwQroHRBwT0sR=66bgg@mail.gmail.com>
 <e72c94d9-e5f9-4753-9bc1-69d72bd54b8a@gmail.com> <CA+HiwqG=gZZCmpR5VMnXYCm0JDxH3dOwiPngnMLCYTj1unWh0w@mail.gmail.com>
 <CAEG8a3LN1EWQ2c9Qh2-AHAUKbnXYGforhDg_-OBdxGiZpp7+BQ@mail.gmail.com>
In-Reply-To: <CAEG8a3LN1EWQ2c9Qh2-AHAUKbnXYGforhDg_-OBdxGiZpp7+BQ@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Mon, 17 Feb 2025 16:15:33 +0900
Message-ID: <CA+HiwqGaR1jszN7=0sc8A-eHretkK7Jf9trDJE5FWT9H957zNw@mail.gmail.com>
Subject: Re: generic plans and "initial" pruning
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>, Tomas Vondra <tomas@vondra.me>, 
	Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Andres Freund <andres@anarazel.de>, Daniel Gustafsson <daniel@yesql.se>, 
	David Rowley <dgrowleyml@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, 
	Thom Brown <thom@linux.com>, Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BHiwqGaR1jszN7%3D0sc8A-eHretkK7Jf9trDJE5FWT9H957zNw%40mail.gmail.com>
Precedence: bulk

Hi Junwang,

On Sun, Feb 16, 2025 at 1:37=E2=80=AFPM Junwang Zhao <zhjwpku@gmail.com> wr=
ote:
> On Sat, Feb 15, 2025 at 3:51=E2=80=AFPM Amit Langote <amitlangote09@gmail=
.com> wrote:
> > Thanks! It looks like I missed updating the MERGE-related lists in Modi=
fyTable.
> >
> > I've attached a fix with a test added based on your example. I plan to
> > push this on Monday.
> >
>
> I applied the patch and the problem solved,

Thanks for checking.

> I have a small question that
> should the following line
>
> ```
> if (node->mergeActionLists =3D=3D NIL)
> ```
>
> be changed to
>
> ```
> if (mtstate->mt_mergeActionLists =3D=3D NIL)
> ```
>
> ISTM that if we have pruned all the merge actions, there is no harm we
> omit setting mtstate->mt_merge_subcommands to 0.

Yeah, that seems harmless, so done.

I have pushed the fix now.

--=20
Thanks, Amit Langote