From cef620d80a764fa0787d074c3cc4dacba73ed190 Mon Sep 17 00:00:00 2001 From: Amit Langote Date: Wed, 6 Sep 2023 17:53:46 +0900 Subject: [PATCH v50 4/6] Preparations to allow executor to take locks in some cases This does two things on the executor side: * Make the executor take locks on the child tables if the plan comes from a CachedPlan. To determine that a given range table relation is a child table, ExecGetRangeTableRelation() now examines RangeTblEntry.inFromCl. To that end, the planner now sets inFromCl to false in the child tables' RTEs. Also, the to deal with the cases where an unlocked child table might have been concurrently dropped, ExecGetRangeTableRelation() is now made to use try_table_open() replacing the existing table_open(). * Add checks at various points during the executor's initialization of the plan tree to determine whether the originating CachedPlan has become invalid as a result of taking locks on the relations referenced in the plan. This includes addding the check after every call to ExecOpenScanRelation() / ExecGetRangeTableRelation() and to ExecInitNode(), including the recursive ones to initialize child nodes. If a given ExecInit*() function or any function called by it detects that the plan has become invalid, it should return immediately even if the PlanState node it's building may only be partially valid. That is crucial for two reasons depending on where the check is: * The checks following ExecOpenScanRelation() / ExecGetRangeTableRelation() may find that the relation being opened has been dropped concurrently or that the plan has become invalid. In this case, some operations in the code that follows may no longer be safe to do. For example, it might try to dereference a NULL pointer in the case where the relation was dropped. * For the checks following ExecInitNode(), the returned child PlanState node might be only partially invalid. The code that follows may misbehave if it depends on inspecting the child PlanState. Note that this commit adds the check following all calls of ExecInitNode() that exist in the code base, even at sites where there is no code that might misbehave today, because it might misbehave in the future. It seems like a good idea to put the guards in place today rather than in the future when the need arises. To pass the CachedPlan that the executor will use for these checks, ExecutorStart() (and ExecutorStart_hook) now gets a new parameter CachedPlan *cplan. Changes on the side of the callers of ExecutorStart(): ExecutorStart() (and ExecutorStart_hook()) now return a Boolean telling the caller if the plan initialization failed. When it returns false due to the CachedPlan becoming invalid, the execution should be reattempted using a fresh CachedPlan. Actually, a new function TryExecutorStart() is added to use by the call sites that supply the PlannedStmt to execute from a CachedPlan, which takes care of cleaning up the partially initialized execution state including planstate tree. For the replan loop in that context, it makes more sense to have ExecutorStart() either in the same scope or closer to where GetCachedPlan() is invoked. So this commit modifies the following sites: * ExplainOnePlan() now returns a Boolean to tell the caller that TryExecutorStart() failed, so the caller should retry with a new plan. * The ExecutorStart() call in _SPI_pquery() is moved to its caller _SPI_execute_plan() and replaced by TryExecutorStart(). * The ExecutorStart() call in PortalRunMulti() is moved to PortalStart() and replaced by TryExecutorStart(). This requires a new List field in PortalData to store the QueryDescs created in PortalStart() and a new memory context for those. One unintended consequence is that CommandCounterIncrement() between queries in the PORTAL_MULTI_QUERY case is now done in the loop in PortalStart() and not in PortalRunMulti(). That still works because the Snapshot registered in QueryDesc/EState is updated to account for the CCI(). This commit also adds a new flag to EState called es_canceled that complements es_finished to denote the new scenario where ExecutorStart() returns with a partially setup planstate tree. Also, to reset the AFTER trigger state that would have been set up in the ExecutorStart(), this adds a new function AfterTriggerCancelQuery() which is called from ExecutorEnd() (not ExecutorFinish()) when es_canceled is true. Note that this commit by itself doesn't make any functional change, because ExecutorStart() currently always returns true. The changes to make it check if the CachedPlan has become invalid will be added in the upcoming patches. Reviewed-by: Robert Haas Discussion: https://postgr.es/m/CA+HiwqFGkMSge6TgC9KQzde0ohpAycLQuV7ooitEEpbKB0O_mg@mail.gmail.comk --- contrib/auto_explain/auto_explain.c | 15 +- .../pg_stat_statements/pg_stat_statements.c | 15 +- contrib/postgres_fdw/postgres_fdw.c | 10 +- src/backend/commands/copyto.c | 5 +- src/backend/commands/createas.c | 9 +- src/backend/commands/explain.c | 42 ++- src/backend/commands/extension.c | 6 +- src/backend/commands/matview.c | 10 +- src/backend/commands/portalcmds.c | 6 +- src/backend/commands/prepare.c | 30 +- src/backend/commands/trigger.c | 13 + src/backend/executor/README | 36 ++- src/backend/executor/execMain.c | 144 ++++++++-- src/backend/executor/execParallel.c | 7 +- src/backend/executor/execPartition.c | 2 + src/backend/executor/execProcnode.c | 7 + src/backend/executor/execUtils.c | 98 ++++++- src/backend/executor/functions.c | 8 +- src/backend/executor/nodeAgg.c | 2 + src/backend/executor/nodeAppend.c | 24 +- src/backend/executor/nodeBitmapAnd.c | 2 + src/backend/executor/nodeBitmapHeapscan.c | 4 + src/backend/executor/nodeBitmapIndexscan.c | 6 +- src/backend/executor/nodeBitmapOr.c | 2 + src/backend/executor/nodeCustom.c | 2 + src/backend/executor/nodeForeignscan.c | 4 + src/backend/executor/nodeGather.c | 2 + src/backend/executor/nodeGatherMerge.c | 2 + src/backend/executor/nodeGroup.c | 2 + src/backend/executor/nodeHash.c | 2 + src/backend/executor/nodeHashjoin.c | 4 + src/backend/executor/nodeIncrementalSort.c | 2 + src/backend/executor/nodeIndexonlyscan.c | 6 +- src/backend/executor/nodeIndexscan.c | 8 +- src/backend/executor/nodeLimit.c | 2 + src/backend/executor/nodeLockRows.c | 2 + src/backend/executor/nodeMaterial.c | 2 + src/backend/executor/nodeMemoize.c | 2 + src/backend/executor/nodeMergeAppend.c | 18 +- src/backend/executor/nodeMergejoin.c | 4 + src/backend/executor/nodeModifyTable.c | 13 + src/backend/executor/nodeNestloop.c | 4 + src/backend/executor/nodeProjectSet.c | 2 + src/backend/executor/nodeRecursiveunion.c | 4 + src/backend/executor/nodeResult.c | 2 + src/backend/executor/nodeSamplescan.c | 3 + src/backend/executor/nodeSeqscan.c | 3 + src/backend/executor/nodeSetOp.c | 2 + src/backend/executor/nodeSort.c | 2 + src/backend/executor/nodeSubqueryscan.c | 2 + src/backend/executor/nodeTidrangescan.c | 2 + src/backend/executor/nodeTidscan.c | 2 + src/backend/executor/nodeUnique.c | 2 + src/backend/executor/nodeWindowAgg.c | 2 + src/backend/executor/spi.c | 46 ++- src/backend/optimizer/util/inherit.c | 7 + src/backend/parser/analyze.c | 7 +- src/backend/tcop/postgres.c | 17 +- src/backend/tcop/pquery.c | 263 ++++++++++-------- src/backend/utils/mmgr/portalmem.c | 9 + src/include/commands/explain.h | 4 +- src/include/commands/trigger.h | 1 + src/include/executor/executor.h | 21 +- src/include/nodes/execnodes.h | 5 + src/include/nodes/parsenodes.h | 8 +- src/include/tcop/pquery.h | 5 +- src/include/utils/plancache.h | 14 + src/include/utils/portal.h | 2 + 68 files changed, 804 insertions(+), 217 deletions(-) diff --git a/contrib/auto_explain/auto_explain.c b/contrib/auto_explain/auto_explain.c index 677c135f59..1b4b8ad8b6 100644 --- a/contrib/auto_explain/auto_explain.c +++ b/contrib/auto_explain/auto_explain.c @@ -78,7 +78,8 @@ static ExecutorRun_hook_type prev_ExecutorRun = NULL; static ExecutorFinish_hook_type prev_ExecutorFinish = NULL; static ExecutorEnd_hook_type prev_ExecutorEnd = NULL; -static void explain_ExecutorStart(QueryDesc *queryDesc, int eflags); +static bool explain_ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, + int eflags); static void explain_ExecutorRun(QueryDesc *queryDesc, ScanDirection direction, uint64 count, bool execute_once); @@ -258,9 +259,11 @@ _PG_init(void) /* * ExecutorStart hook: start up logging if needed */ -static void -explain_ExecutorStart(QueryDesc *queryDesc, int eflags) +static bool +explain_ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags) { + bool plan_valid; + /* * At the beginning of each top-level statement, decide whether we'll * sample this statement. If nested-statement explaining is enabled, @@ -296,9 +299,9 @@ explain_ExecutorStart(QueryDesc *queryDesc, int eflags) } if (prev_ExecutorStart) - prev_ExecutorStart(queryDesc, eflags); + plan_valid = prev_ExecutorStart(queryDesc, cplan, eflags); else - standard_ExecutorStart(queryDesc, eflags); + plan_valid = standard_ExecutorStart(queryDesc, cplan, eflags); if (auto_explain_enabled()) { @@ -316,6 +319,8 @@ explain_ExecutorStart(QueryDesc *queryDesc, int eflags) MemoryContextSwitchTo(oldcxt); } } + + return plan_valid; } /* diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 362d222f63..74d359f61b 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -329,7 +329,8 @@ static PlannedStmt *pgss_planner(Query *parse, const char *query_string, int cursorOptions, ParamListInfo boundParams); -static void pgss_ExecutorStart(QueryDesc *queryDesc, int eflags); +static bool pgss_ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, + int eflags); static void pgss_ExecutorRun(QueryDesc *queryDesc, ScanDirection direction, uint64 count, bool execute_once); @@ -984,13 +985,15 @@ pgss_planner(Query *parse, /* * ExecutorStart hook: start up tracking if needed */ -static void -pgss_ExecutorStart(QueryDesc *queryDesc, int eflags) +static bool +pgss_ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags) { + bool plan_valid; + if (prev_ExecutorStart) - prev_ExecutorStart(queryDesc, eflags); + plan_valid = prev_ExecutorStart(queryDesc, cplan, eflags); else - standard_ExecutorStart(queryDesc, eflags); + plan_valid = standard_ExecutorStart(queryDesc, cplan, eflags); /* * If query has queryId zero, don't track it. This prevents double @@ -1013,6 +1016,8 @@ pgss_ExecutorStart(QueryDesc *queryDesc, int eflags) MemoryContextSwitchTo(oldcxt); } } + + return plan_valid; } /* diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index fc65d81e21..e7080f8953 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -2137,7 +2137,11 @@ postgresEndForeignModify(EState *estate, { PgFdwModifyState *fmstate = (PgFdwModifyState *) resultRelInfo->ri_FdwState; - /* If fmstate is NULL, we are in EXPLAIN; nothing to do */ + /* + * fmstate could be NULL under two conditions: during an EXPLAIN + * operation, or if BeginForeignModify() hasn't been invoked. + * In either case, no action is required. + */ if (fmstate == NULL) return; @@ -2671,7 +2675,11 @@ postgresBeginDirectModify(ForeignScanState *node, int eflags) /* Get info about foreign table. */ rtindex = node->resultRelInfo->ri_RangeTableIndex; if (fsplan->scan.scanrelid == 0) + { dmstate->rel = ExecOpenScanRelation(estate, rtindex, eflags); + if (unlikely(dmstate->rel == NULL || !ExecPlanStillValid(estate))) + return; + } else dmstate->rel = node->ss.ss_currentRelation; table = GetForeignTable(RelationGetRelid(dmstate->rel)); diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c index eb1d3d8fbb..e88c3a6760 100644 --- a/src/backend/commands/copyto.c +++ b/src/backend/commands/copyto.c @@ -561,8 +561,11 @@ BeginCopyTo(ParseState *pstate, * Call ExecutorStart to prepare the plan for execution. * * ExecutorStart computes a result tupdesc for us + * + * Plan can't become invalid, because there's no CachedPlan. */ - ExecutorStart(cstate->queryDesc, 0); + if (!ExecutorStart(cstate->queryDesc, NULL, 0)) + elog(ERROR, "unexpected failure running ExecutorStart()"); tupDesc = cstate->queryDesc->tupDesc; } diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c index 0b629b1f79..720bc1c72f 100644 --- a/src/backend/commands/createas.c +++ b/src/backend/commands/createas.c @@ -328,8 +328,13 @@ ExecCreateTableAs(ParseState *pstate, CreateTableAsStmt *stmt, GetActiveSnapshot(), InvalidSnapshot, dest, params, queryEnv, 0); - /* call ExecutorStart to prepare the plan for execution */ - ExecutorStart(queryDesc, GetIntoRelEFlags(into)); + /* + * call ExecutorStart to prepare the plan for execution + * + * Plan can't become invalid, because there's no CachedPlan. + */ + if (!ExecutorStart(queryDesc, NULL, GetIntoRelEFlags(into))) + elog(ERROR, "unexpected failure running ExecutorStart()"); /* run the plan to completion */ ExecutorRun(queryDesc, ForwardScanDirection, 0, true); diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c index 5771aabf40..d2de259062 100644 --- a/src/backend/commands/explain.c +++ b/src/backend/commands/explain.c @@ -506,10 +506,11 @@ standard_ExplainOneQuery(Query *query, int cursorOptions, BufferUsageAccumDiff(&bufusage, &pgBufferUsage, &bufusage_start); } - /* run it (if needed) and produce output */ - ExplainOnePlan(plan, into, es, queryString, params, queryEnv, - &planduration, (es->buffers ? &bufusage : NULL), - es->memory ? &mem_counters : NULL); + /* run it (if needed) and produce output; no CachedPlan, no replanning! */ + if (!ExplainOnePlan(plan, NULL, into, es, queryString, params, queryEnv, + &planduration, (es->buffers ? &bufusage : NULL), + es->memory ? &mem_counters : NULL)) + elog(ERROR, "unexpected failure to finish ExplainOnePlan()"); } /* @@ -613,9 +614,13 @@ ExplainOneUtility(Node *utilityStmt, IntoClause *into, ExplainState *es, * This is exported because it's called back from prepare.c in the * EXPLAIN EXECUTE case, and because an index advisor plugin would need * to call it. + * + * Returns true if execution succeeds, false otherwise. Latter only possible + * if cplan != NULL and gets invalidated during ExecutorStart(). */ -void -ExplainOnePlan(PlannedStmt *plannedstmt, IntoClause *into, ExplainState *es, +bool +ExplainOnePlan(PlannedStmt *plannedstmt, CachedPlan *cplan, + IntoClause *into, ExplainState *es, const char *queryString, ParamListInfo params, QueryEnvironment *queryEnv, const instr_time *planduration, const BufferUsage *bufusage, @@ -685,8 +690,16 @@ ExplainOnePlan(PlannedStmt *plannedstmt, IntoClause *into, ExplainState *es, if (into) eflags |= GetIntoRelEFlags(into); - /* call ExecutorStart to prepare the plan for execution */ - ExecutorStart(queryDesc, eflags); + /* + * Call TryExecutorStart to prepare the plan for execution. A cached plan + * may get invalidated during plan intialization. + */ + if (!TryExecutorStart(queryDesc, cplan, eflags)) + { + /* Clean up. */ + PopActiveSnapshot(); + return false; + } /* Execute the plan for statistics if asked for */ if (es->analyze) @@ -798,6 +811,8 @@ ExplainOnePlan(PlannedStmt *plannedstmt, IntoClause *into, ExplainState *es, es); ExplainCloseGroup("Query", NULL, true, es); + + return true; } /* @@ -5194,6 +5209,17 @@ ExplainDummyGroup(const char *objtype, const char *labelname, ExplainState *es) } } +/* + * Discard output buffer for a fresh restart. + */ +void +ExplainResetOutput(ExplainState *es) +{ + Assert(es->str); + resetStringInfo(es->str); + ExplainBeginOutput(es); +} + /* * Emit the start-of-output boilerplate. * diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c index 1643c8c69a..c3003ae1c6 100644 --- a/src/backend/commands/extension.c +++ b/src/backend/commands/extension.c @@ -802,7 +802,11 @@ execute_sql_string(const char *sql) GetActiveSnapshot(), NULL, dest, NULL, NULL, 0); - ExecutorStart(qdesc, 0); + /* + * Plan can't become invalid, because there's no CachedPlan. + */ + if (!ExecutorStart(qdesc, NULL, 0)) + elog(ERROR, "unexpected failure running ExecutorStart()"); ExecutorRun(qdesc, ForwardScanDirection, 0, true); ExecutorFinish(qdesc); ExecutorEnd(qdesc); diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c index 91f0fd6ea3..ac4dfa9a71 100644 --- a/src/backend/commands/matview.c +++ b/src/backend/commands/matview.c @@ -442,8 +442,14 @@ refresh_matview_datafill(DestReceiver *dest, Query *query, GetActiveSnapshot(), InvalidSnapshot, dest, NULL, NULL, 0); - /* call ExecutorStart to prepare the plan for execution */ - ExecutorStart(queryDesc, 0); + /* + * call ExecutorStart to prepare the plan for execution + * + * OK to ignore the return value; plan can't become invalid, + * because there's no CachedPlan. + */ + if (!ExecutorStart(queryDesc, NULL, 0)) + elog(ERROR, "unexpected failure running ExecutorStart()"); /* run the plan */ ExecutorRun(queryDesc, ForwardScanDirection, 0, true); diff --git a/src/backend/commands/portalcmds.c b/src/backend/commands/portalcmds.c index 4f6acf6719..cea3e8eca4 100644 --- a/src/backend/commands/portalcmds.c +++ b/src/backend/commands/portalcmds.c @@ -142,9 +142,11 @@ PerformCursorOpen(ParseState *pstate, DeclareCursorStmt *cstmt, ParamListInfo pa /* * Start execution, inserting parameters if any. + * + * Plan can't become invalid here, because there's no CachedPlan. */ - PortalStart(portal, params, 0, GetActiveSnapshot()); - + if (!PortalStart(portal, params, 0, GetActiveSnapshot(), NULL)) + elog(ERROR, "unexpected failure running PortalStart()"); Assert(portal->strategy == PORTAL_ONE_SELECT); /* diff --git a/src/backend/commands/prepare.c b/src/backend/commands/prepare.c index 07257d4db9..bf4917f22f 100644 --- a/src/backend/commands/prepare.c +++ b/src/backend/commands/prepare.c @@ -180,6 +180,7 @@ ExecuteQuery(ParseState *pstate, paramLI = EvaluateParams(pstate, entry, stmt->params, estate); } +replan: /* Create a new portal to run the query in */ portal = CreateNewPortal(); /* Don't display the portal in pg_cursors, it is for internal use only */ @@ -248,9 +249,16 @@ ExecuteQuery(ParseState *pstate, } /* - * Run the portal as appropriate. + * Run the portal as appropriate. If the portal has a cached plan and + * it's found to be invalidated during the initialization of its plan + * trees, the plan must be regenerated. */ - PortalStart(portal, paramLI, eflags, GetActiveSnapshot()); + if (!PortalStart(portal, paramLI, eflags, GetActiveSnapshot(), cplan)) + { + Assert(cplan != NULL); + PortalDrop(portal, false); + goto replan; + } (void) PortalRun(portal, count, false, true, dest, dest, qc); @@ -571,7 +579,7 @@ ExplainExecuteQuery(ExecuteStmt *execstmt, IntoClause *into, ExplainState *es, { PreparedStatement *entry; const char *query_string; - CachedPlan *cplan; + CachedPlan *cplan = NULL; List *plan_list; ListCell *p; ParamListInfo paramLI = NULL; @@ -628,6 +636,7 @@ ExplainExecuteQuery(ExecuteStmt *execstmt, IntoClause *into, ExplainState *es, } /* Replan if needed, and acquire a transient refcount */ +replan: cplan = GetCachedPlan(entry->plansource, paramLI, CurrentResourceOwner, queryEnv); @@ -655,9 +664,18 @@ ExplainExecuteQuery(ExecuteStmt *execstmt, IntoClause *into, ExplainState *es, PlannedStmt *pstmt = lfirst_node(PlannedStmt, p); if (pstmt->commandType != CMD_UTILITY) - ExplainOnePlan(pstmt, into, es, query_string, paramLI, queryEnv, - &planduration, (es->buffers ? &bufusage : NULL), - es->memory ? &mem_counters : NULL); + { + if (!ExplainOnePlan(pstmt, cplan, into, es, query_string, paramLI, + queryEnv, &planduration, + (es->buffers ? &bufusage : NULL), + es->memory ? &mem_counters : NULL)) + { + Assert(cplan != NULL); + ExplainResetOutput(es); + ReleaseCachedPlan(cplan, CurrentResourceOwner); + goto replan; + } + } else ExplainOneUtility(pstmt->utilityStmt, into, es, query_string, paramLI, queryEnv); diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 170360edda..bb410d7313 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -5023,6 +5023,19 @@ AfterTriggerBeginQuery(void) afterTriggers.query_depth++; } +/* ---------- + * AfterTriggerCancelQuery() + * + * Called from ExecutorEnd() if the query execution was canceled. + * ---------- + */ +void +AfterTriggerCancelQuery(void) +{ + /* Set to a value denoting that no query is active. */ + afterTriggers.query_depth = -1; +} + /* ---------- * AfterTriggerEndQuery() diff --git a/src/backend/executor/README b/src/backend/executor/README index 642d63be61..6cd840d3a7 100644 --- a/src/backend/executor/README +++ b/src/backend/executor/README @@ -280,6 +280,34 @@ are typically reset to empty once per tuple. Per-tuple contexts are usually associated with ExprContexts, and commonly each PlanState node has its own ExprContext to evaluate its qual and targetlist expressions in. +Relation Locking +---------------- + +Typically, when the executor initializes a plan tree for execution, it doesn't +lock non-index relations if the plan tree is freshly generated and not derived +from a CachedPlan. This is because such locks have already been established +during the query's parsing, rewriting, and planning phases. However, with a +cached plan tree, there can be relations that remain unlocked. The function +GetCachedPlan() locks relations existing in the query's range table pre-planning +but doesn't account for those added during the planning phase. Consequently, +inheritance child tables, introduced to the query's range table during planning, +won't be locked when the cached plan reaches the executor. + +The decision to defer locking child tables with GetCachedPlan() arises from the +fact that not all might be accessed during plan execution. For instance, if +child tables are partitions, some might be omitted due to pruning at +execution-initialization-time. Thus, the responsibility of locking these child +tables is pushed to execution-initialization-time, taking place in ExecInitNode() +for plan nodes encompassing these tables. + +This approach opens a window where a cached plan tree with child tables could +become outdated if another backend modifies these tables before ExecInitNode() +locks them. Given this, the executor has the added duty to confirm the plan +tree's validity whenever it locks a child table post execution-initialization- +pruning. This validation is done by checking the CachedPlan.is_valid attribute +of the CachedPlan provided. If the plan tree is outdated (is_valid=false), the +executor halts any further initialization and alerts the caller that they should +retry execution with another freshly created plan tree. Query Processing Control Flow ----------------------------- @@ -316,7 +344,13 @@ This is a sketch of control flow for full query processing: FreeQueryDesc -Per above comments, it's not really critical for ExecEndNode to free any +As mentioned in the "Relation Locking" section, if the plan tree is found to +be stale during one of the recursive calls of ExecInitNode() after taking a +lock on a child table, the control is immmediately returned to the caller of +ExecutorStart(), which must redo the steps from CreateQueryDesc with a new +plan tree. + +Per above comments, it's not really critical for ExecEndPlan to free any memory; it'll all go away in FreeExecutorState anyway. However, we do need to be careful to close relations, drop buffer pins, etc, so we do need to scan the plan state tree to find these sorts of resources. diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 5e1b8a42e8..cf059cb850 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -58,6 +58,7 @@ #include "utils/backend_status.h" #include "utils/lsyscache.h" #include "utils/partcache.h" +#include "utils/plancache.h" #include "utils/rls.h" #include "utils/snapmgr.h" @@ -72,7 +73,7 @@ ExecutorEnd_hook_type ExecutorEnd_hook = NULL; ExecutorCheckPerms_hook_type ExecutorCheckPerms_hook = NULL; /* decls for local routines only used within this module */ -static void InitPlan(QueryDesc *queryDesc, int eflags); +static bool InitPlan(QueryDesc *queryDesc, CachedPlan *cplan, int eflags); static void CheckValidRowMarkRel(Relation rel, RowMarkType markType); static void ExecPostprocessPlan(EState *estate); static void ExecEndPlan(PlanState *planstate, EState *estate); @@ -112,6 +113,13 @@ static void EvalPlanQualStart(EPQState *epqstate, Plan *planTree); * * eflags contains flag bits as described in executor.h. * + * Plan initialization may fail if the input plan tree is found to have been + * invalidated, which can happen if it comes from a CachedPlan ('cplan'). + * + * Returns true if plan was successfully initialized and false otherwise. If + * the latter, the caller must call ExecutorEnd() on 'queryDesc' to clean up + * after failed plan initialization. + * * NB: the CurrentMemoryContext when this is called will become the parent * of the per-query context used for this Executor invocation. * @@ -121,8 +129,8 @@ static void EvalPlanQualStart(EPQState *epqstate, Plan *planTree); * * ---------------------------------------------------------------- */ -void -ExecutorStart(QueryDesc *queryDesc, int eflags) +bool +ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags) { /* * In some cases (e.g. an EXECUTE statement) a query execution will skip @@ -133,14 +141,34 @@ ExecutorStart(QueryDesc *queryDesc, int eflags) pgstat_report_query_id(queryDesc->plannedstmt->queryId, false); if (ExecutorStart_hook) - (*ExecutorStart_hook) (queryDesc, eflags); - else - standard_ExecutorStart(queryDesc, eflags); + return (*ExecutorStart_hook) (queryDesc, cplan, eflags); + + return standard_ExecutorStart(queryDesc, cplan, eflags); } -void -standard_ExecutorStart(QueryDesc *queryDesc, int eflags) +/* + * Variant of ExecutorStart() that handles cleaning up if the input CachedPlan + * becomes invalid due to locks being taken during ExecutorStart(). + */ +bool +TryExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags) { + bool plan_valid = ExecutorStart(queryDesc, cplan, eflags); + + if (!plan_valid) + { + Assert(cplan != NULL); + ExecutorEnd(queryDesc); + FreeQueryDesc(queryDesc); + } + + return plan_valid; +} + +bool +standard_ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags) +{ + bool plan_valid; EState *estate; MemoryContext oldcontext; @@ -259,9 +287,14 @@ standard_ExecutorStart(QueryDesc *queryDesc, int eflags) /* * Initialize the plan state tree */ - InitPlan(queryDesc, eflags); + plan_valid = InitPlan(queryDesc, cplan, eflags); + + /* Mark execution as canceled if plan won't be executed. */ + estate->es_canceled = !plan_valid; MemoryContextSwitchTo(oldcontext); + + return plan_valid; } /* ---------------------------------------------------------------- @@ -321,6 +354,7 @@ standard_ExecutorRun(QueryDesc *queryDesc, estate = queryDesc->estate; Assert(estate != NULL); + Assert(!estate->es_canceled); Assert(!(estate->es_top_eflags & EXEC_FLAG_EXPLAIN_ONLY)); /* caller must ensure the query's snapshot is active */ @@ -428,7 +462,7 @@ standard_ExecutorFinish(QueryDesc *queryDesc) Assert(!(estate->es_top_eflags & EXEC_FLAG_EXPLAIN_ONLY)); /* This should be run once and only once per Executor instance */ - Assert(!estate->es_finished); + Assert(!estate->es_finished && !estate->es_canceled); /* Switch into per-query memory context */ oldcontext = MemoryContextSwitchTo(estate->es_query_cxt); @@ -487,11 +521,11 @@ standard_ExecutorEnd(QueryDesc *queryDesc) Assert(estate != NULL); /* - * Check that ExecutorFinish was called, unless in EXPLAIN-only mode. This - * Assert is needed because ExecutorFinish is new as of 9.1, and callers - * might forget to call it. + * Check that ExecutorFinish was called, unless in EXPLAIN-only mode or if + * execution was canceled. This Assert is needed because ExecutorFinish is + * new as of 9.1, and callers might forget to call it. */ - Assert(estate->es_finished || + Assert(estate->es_finished || estate->es_canceled || (estate->es_top_eflags & EXEC_FLAG_EXPLAIN_ONLY)); /* @@ -505,6 +539,14 @@ standard_ExecutorEnd(QueryDesc *queryDesc) UnregisterSnapshot(estate->es_snapshot); UnregisterSnapshot(estate->es_crosscheck_snapshot); + /* + * Cancel trigger execution too if the query execution was canceled. + */ + if (estate->es_canceled && + !(estate->es_top_eflags & + (EXEC_FLAG_SKIP_TRIGGERS | EXEC_FLAG_EXPLAIN_ONLY))) + AfterTriggerCancelQuery(); + /* * Must switch out of context before destroying it */ @@ -834,24 +876,55 @@ ExecCheckXactReadOnly(PlannedStmt *plannedstmt) PreventCommandIfParallelMode(CreateCommandName((Node *) plannedstmt)); } +/* Lock the relations found in PlannedStmt.elidedAppendPartRels. */ +static void +ExecLockElidedAppendPartRels(EState *estate, List *elidedAppendPartRels) +{ + ListCell *lc; + + foreach(lc, elidedAppendPartRels) + { + Bitmapset *partrelids = castNode(Bitmapset, lfirst(lc)); + int rti = -1; + + while ((rti = bms_next_member(partrelids, rti)) > 0) + { + RangeTblEntry *rte = exec_rt_fetch(rti, estate); + + /* + * Don't lock any partitioned tables mentioned in the query, + * because they would already have been locked before entering the + * executor. + */ + if (!rte->inFromCl) + LockRelationOid(rte->relid, rte->rellockmode); + else + Assert(CheckRelationOidLockedByMe(rte->relid, rte->rellockmode, true)); + } + } +} /* ---------------------------------------------------------------- * InitPlan * * Initializes the query plan: open files, allocate storage * and start up the rule manager + * + * Returns true if the plan tree is successfully initialized for execution, + * false otherwise. The latter case may occur if the CachedPlan that provides + * the plan tree ('cplan') got invalidated during the initialization. * ---------------------------------------------------------------- */ -static void -InitPlan(QueryDesc *queryDesc, int eflags) +static bool +InitPlan(QueryDesc *queryDesc, CachedPlan *cplan, int eflags) { CmdType operation = queryDesc->operation; PlannedStmt *plannedstmt = queryDesc->plannedstmt; Plan *plan = plannedstmt->planTree; List *rangeTable = plannedstmt->rtable; EState *estate = queryDesc->estate; - PlanState *planstate; - TupleDesc tupType; + PlanState *planstate = NULL; + TupleDesc tupType = NULL; ListCell *l; int i; @@ -865,7 +938,16 @@ InitPlan(QueryDesc *queryDesc, int eflags) */ ExecInitRangeTable(estate, rangeTable, plannedstmt->permInfos); + /* + * With range table in place, lock partitioned tables whose + * Append/MergeAppend nodes have been removed by the planner. + */ + if (cplan != NULL) + ExecLockElidedAppendPartRels(estate, + plannedstmt->elidedAppendPartRels); + estate->es_plannedstmt = plannedstmt; + estate->es_cachedplan = cplan; /* * Next, build the ExecRowMark array from the PlanRowMark(s), if any. @@ -897,6 +979,9 @@ InitPlan(QueryDesc *queryDesc, int eflags) case ROW_MARK_KEYSHARE: case ROW_MARK_REFERENCE: relation = ExecGetRangeTableRelation(estate, rc->rti); + if (unlikely(relation == NULL || + !ExecPlanStillValid(estate))) + return false; break; case ROW_MARK_COPY: /* no physical table access is required */ @@ -967,6 +1052,8 @@ InitPlan(QueryDesc *queryDesc, int eflags) estate->es_subplanstates = lappend(estate->es_subplanstates, subplanstate); + if (unlikely(!ExecPlanStillValid(estate))) + return false; i++; } @@ -977,6 +1064,8 @@ InitPlan(QueryDesc *queryDesc, int eflags) * processing tuples. */ planstate = ExecInitNode(plan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return false; /* * Get the tuple descriptor describing the type of tuples to return. @@ -1018,8 +1107,12 @@ InitPlan(QueryDesc *queryDesc, int eflags) } } + Assert(queryDesc->tupDesc == NULL); queryDesc->tupDesc = tupType; + Assert(queryDesc->planstate == NULL); queryDesc->planstate = planstate; + + return true; } /* @@ -2847,7 +2940,8 @@ EvalPlanQualStart(EPQState *epqstate, Plan *planTree) * Child EPQ EStates share the parent's copy of unchanging state such as * the snapshot, rangetable, and external Param info. They need their own * copies of local state, including a tuple table, es_param_exec_vals, - * result-rel info, etc. + * result-rel info, etc. Also, we don't pass the parent's copy of the + * CachedPlan, because no new locks will be taken for EvalPlanQual(). */ rcestate->es_direction = ForwardScanDirection; rcestate->es_snapshot = parentestate->es_snapshot; @@ -2936,6 +3030,14 @@ EvalPlanQualStart(EPQState *epqstate, Plan *planTree) subplanstate = ExecInitNode(subplan, rcestate, 0); rcestate->es_subplanstates = lappend(rcestate->es_subplanstates, subplanstate); + + /* + * All the necessary locks must already have been taken when + * initializing the parent's copy of subplanstate, so the CachedPlan, + * if any, should not have become invalid during ExecInitNode(). + */ + if (!ExecPlanStillValid(rcestate)) + elog(ERROR, "unexpected failure to initialize subplan in EvalPlanQualStart()"); } /* @@ -2977,6 +3079,10 @@ EvalPlanQualStart(EPQState *epqstate, Plan *planTree) */ epqstate->recheckplanstate = ExecInitNode(planTree, rcestate, 0); + /* See the comment above. */ + if (!ExecPlanStillValid(rcestate)) + elog(ERROR, "unexpected failure to initialize main plantree in EvalPlanQualStart()"); + MemoryContextSwitchTo(oldcontext); } diff --git a/src/backend/executor/execParallel.c b/src/backend/executor/execParallel.c index f995714d7f..e8ca60d143 100644 --- a/src/backend/executor/execParallel.c +++ b/src/backend/executor/execParallel.c @@ -1439,7 +1439,12 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc) /* Start up the executor */ queryDesc->plannedstmt->jitFlags = fpes->jit_flags; - ExecutorStart(queryDesc, fpes->eflags); + /* + * OK to ignore the return value; plan can't become invalid, + * because there's no CachedPlan. + */ + if (!ExecutorStart(queryDesc, NULL, fpes->eflags)) + elog(ERROR, "unexpected failure running ExecutorStart()"); /* Special executor initialization steps for parallel workers */ queryDesc->planstate->state->es_query_dsa = area; diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c index 7651886229..97a43513ce 100644 --- a/src/backend/executor/execPartition.c +++ b/src/backend/executor/execPartition.c @@ -1935,6 +1935,8 @@ CreatePartitionPruneState(PlanState *planstate, PartitionPruneInfo *pruneinfo) * duration of this executor run. */ partrel = ExecGetRangeTableRelation(estate, pinfo->rtindex); + if (unlikely(partrel == NULL || !ExecPlanStillValid(estate))) + return NULL; partkey = RelationGetPartitionKey(partrel); partdesc = PartitionDirectoryLookup(estate->es_partition_directory, partrel); diff --git a/src/backend/executor/execProcnode.c b/src/backend/executor/execProcnode.c index 34f28dfece..7689d34dd0 100644 --- a/src/backend/executor/execProcnode.c +++ b/src/backend/executor/execProcnode.c @@ -136,6 +136,10 @@ static bool ExecShutdownNode_walker(PlanState *node, void *context); * 'eflags' is a bitwise OR of flag bits described in executor.h * * Returns a PlanState node corresponding to the given Plan node. + * + * Callers should check upon returning that ExecPlanStillValid(estate) + * returns true before continuing further with its processing, because the + * returned PlanState might be only partially valid otherwise. * ------------------------------------------------------------------------ */ PlanState * @@ -388,6 +392,9 @@ ExecInitNode(Plan *node, EState *estate, int eflags) break; } + if (unlikely(!ExecPlanStillValid(estate))) + return result; + ExecSetExecProcNode(result, result->ExecProcNode); /* diff --git a/src/backend/executor/execUtils.c b/src/backend/executor/execUtils.c index 5737f9f4eb..edf1c24e0e 100644 --- a/src/backend/executor/execUtils.c +++ b/src/backend/executor/execUtils.c @@ -146,6 +146,7 @@ CreateExecutorState(void) estate->es_top_eflags = 0; estate->es_instrument = 0; estate->es_finished = false; + estate->es_canceled = false; estate->es_exprcontexts = NIL; @@ -691,6 +692,8 @@ ExecRelationIsTargetRelation(EState *estate, Index scanrelid) * * Open the heap relation to be scanned by a base-level scan plan node. * This should be called during the node's ExecInit routine. + * + * NULL is returned if the relation is found to have been dropped. * ---------------------------------------------------------------- */ Relation @@ -700,6 +703,8 @@ ExecOpenScanRelation(EState *estate, Index scanrelid, int eflags) /* Open the relation. */ rel = ExecGetRangeTableRelation(estate, scanrelid); + if (unlikely(rel == NULL || !ExecPlanStillValid(estate))) + return NULL; /* * Complain if we're attempting a scan of an unscannable relation, except @@ -717,6 +722,26 @@ ExecOpenScanRelation(EState *estate, Index scanrelid, int eflags) return rel; } +/* ---------------------------------------------------------------- + * ExecOpenScanIndexRelation + * + * Open the index relation to be scanned by an index scan plan node. + * This should be called during the node's ExecInit routine. + * ---------------------------------------------------------------- + */ +Relation +ExecOpenScanIndexRelation(EState *estate, Oid indexid, int lockmode) +{ + Relation rel; + + /* Open the index. */ + rel = index_open(indexid, lockmode); + if (unlikely(!ExecPlanStillValid(estate))) + elog(DEBUG2, "CachedPlan invalidated on locking index %u", indexid); + + return rel; +} + /* * ExecInitRangeTable * Set up executor's range-table-related data @@ -757,6 +782,9 @@ ExecInitRangeTable(EState *estate, List *rangeTable, List *permInfos) * Open the Relation for a range table entry, if not already done * * The Relations will be closed again in ExecEndPlan(). + * + * Returned value may be NULL if the relation is a child relation that is not + * already locked. */ Relation ExecGetRangeTableRelation(EState *estate, Index rti) @@ -773,7 +801,31 @@ ExecGetRangeTableRelation(EState *estate, Index rti) Assert(rte->rtekind == RTE_RELATION); - if (!IsParallelWorker()) + if (IsParallelWorker() || + (estate->es_cachedplan != NULL && !rte->inFromCl)) + { + /* + * Take a lock if we are a parallel worker or if this is a child + * table referenced in a cached plan. + * + * Parallel workers need to have their own local lock on the + * relation. This ensures sane behavior in case the parent process + * exits before we do. + * + * When executing a cached plan, child tables must be locked + * here, because plancache.c (GetCachedPlan()) would only have + * locked tables mentioned in the query, that is, tables whose + * RTEs' inFromCl is true. + * + * Note that we use try_table_open() here, because without a lock + * held on the relation, it may have disappeared from under us. + */ + rel = try_table_open(rte->relid, rte->rellockmode); + if (unlikely(!ExecPlanStillValid(estate))) + elog(DEBUG2, "CachedPlan invalidated on locking relation %u", + rte->relid); + } + else { /* * In a normal query, we should already have the appropriate lock, @@ -786,15 +838,6 @@ ExecGetRangeTableRelation(EState *estate, Index rti) Assert(rte->rellockmode == AccessShareLock || CheckRelationLockedByMe(rel, rte->rellockmode, false)); } - else - { - /* - * If we are a parallel worker, we need to obtain our own local - * lock on the relation. This ensures sane behavior in case the - * parent process exits before we do. - */ - rel = table_open(rte->relid, rte->rellockmode); - } estate->es_relations[rti - 1] = rel; } @@ -802,6 +845,38 @@ ExecGetRangeTableRelation(EState *estate, Index rti) return rel; } +/* + * ExecLockAppendPartRels + * Lock non-leaf partitions whose child partitions are scanned by a given + * Append/MergeAppend node + */ +void +ExecLockAppendPartRels(EState *estate, List *allpartrelids) +{ + ListCell *l; + + foreach(l, allpartrelids) + { + Bitmapset *partrelids = lfirst_node(Bitmapset, l); + int rti = -1; + + while ((rti = bms_next_member(partrelids, rti)) > 0) + { + RangeTblEntry *rte = exec_rt_fetch(rti, estate); + + /* + * Don't lock any partitioned tables mentioned in the query, + * because they would already have been locked before entering the + * executor. + */ + if (!rte->inFromCl) + LockRelationOid(rte->relid, rte->rellockmode); + else + Assert(CheckRelationOidLockedByMe(rte->relid, rte->rellockmode, true)); + } + } +} + /* * ExecInitResultRelation * Open relation given by the passed-in RT index and fill its @@ -817,6 +892,9 @@ ExecInitResultRelation(EState *estate, ResultRelInfo *resultRelInfo, Relation resultRelationDesc; resultRelationDesc = ExecGetRangeTableRelation(estate, rti); + if (unlikely(resultRelationDesc == NULL || + !ExecPlanStillValid(estate))) + return; InitResultRelInfo(resultRelInfo, resultRelationDesc, rti, diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c index 692854e2b3..8f65242f33 100644 --- a/src/backend/executor/functions.c +++ b/src/backend/executor/functions.c @@ -864,7 +864,13 @@ postquel_start(execution_state *es, SQLFunctionCachePtr fcache) eflags = EXEC_FLAG_SKIP_TRIGGERS; else eflags = 0; /* default run-to-completion flags */ - ExecutorStart(es->qd, eflags); + + /* + * OK to ignore the return value; plan can't become invalid, + * because there's no CachedPlan. + */ + if (!ExecutorStart(es->qd, NULL, eflags)) + elog(ERROR, "unexpected failure running ExecutorStart()"); } es->status = F_EXEC_RUN; diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.c index 0dfba5ca16..8c40d8c520 100644 --- a/src/backend/executor/nodeAgg.c +++ b/src/backend/executor/nodeAgg.c @@ -3303,6 +3303,8 @@ ExecInitAgg(Agg *node, EState *estate, int eflags) eflags &= ~EXEC_FLAG_REWIND; outerPlan = outerPlan(node); outerPlanState(aggstate) = ExecInitNode(outerPlan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return aggstate; /* * initialize source tuple type. diff --git a/src/backend/executor/nodeAppend.c b/src/backend/executor/nodeAppend.c index 86d75b1a7e..72437f729f 100644 --- a/src/backend/executor/nodeAppend.c +++ b/src/backend/executor/nodeAppend.c @@ -133,6 +133,20 @@ ExecInitAppend(Append *node, EState *estate, int eflags) appendstate->as_syncdone = false; appendstate->as_begun = false; + /* + * Lock non-leaf partitions whose leaf children are present in + * node->appendplans. Only need to do so if executing a cached + * plan, because child tables present in cached plans are not + * locked before execution. + * + * XXX - some of the non-leaf partitions may also be mentioned in + * part_prune_info, which would get locked again in + * ExecInitPartitionPruning() because it calls + * ExecGetRangeTableRelation() which locks child tables. + */ + if (estate->es_cachedplan) + ExecLockAppendPartRels(estate, node->allpartrelids); + /* If run-time partition pruning is enabled, then set that up now */ if (node->part_prune_info != NULL) { @@ -185,8 +199,10 @@ ExecInitAppend(Append *node, EState *estate, int eflags) appendstate->ps.resultopsset = true; appendstate->ps.resultopsfixed = false; - appendplanstates = (PlanState **) palloc(nplans * - sizeof(PlanState *)); + appendplanstates = (PlanState **) palloc0(nplans * + sizeof(PlanState *)); + appendstate->appendplans = appendplanstates; + appendstate->as_nplans = nplans; /* * call ExecInitNode on each of the valid plans to be executed and save @@ -221,11 +237,11 @@ ExecInitAppend(Append *node, EState *estate, int eflags) firstvalid = j; appendplanstates[j++] = ExecInitNode(initNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return appendstate; } appendstate->as_first_partial_plan = firstvalid; - appendstate->appendplans = appendplanstates; - appendstate->as_nplans = nplans; /* Initialize async state */ appendstate->as_asyncplans = asyncplans; diff --git a/src/backend/executor/nodeBitmapAnd.c b/src/backend/executor/nodeBitmapAnd.c index ae391222bf..168c440692 100644 --- a/src/backend/executor/nodeBitmapAnd.c +++ b/src/backend/executor/nodeBitmapAnd.c @@ -89,6 +89,8 @@ ExecInitBitmapAnd(BitmapAnd *node, EState *estate, int eflags) { initNode = (Plan *) lfirst(l); bitmapplanstates[i] = ExecInitNode(initNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return bitmapandstate; i++; } diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c index 19f18ab817..b13cae1cbb 100644 --- a/src/backend/executor/nodeBitmapHeapscan.c +++ b/src/backend/executor/nodeBitmapHeapscan.c @@ -754,11 +754,15 @@ ExecInitBitmapHeapScan(BitmapHeapScan *node, EState *estate, int eflags) * open the scan relation */ currentRelation = ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(currentRelation == NULL || !ExecPlanStillValid(estate))) + return scanstate; /* * initialize child nodes */ outerPlanState(scanstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return scanstate; /* * get the scan type from the relation descriptor. diff --git a/src/backend/executor/nodeBitmapIndexscan.c b/src/backend/executor/nodeBitmapIndexscan.c index 4669e8d0ce..f04a53e9be 100644 --- a/src/backend/executor/nodeBitmapIndexscan.c +++ b/src/backend/executor/nodeBitmapIndexscan.c @@ -252,7 +252,11 @@ ExecInitBitmapIndexScan(BitmapIndexScan *node, EState *estate, int eflags) /* Open the index relation. */ lockmode = exec_rt_fetch(node->scan.scanrelid, estate)->rellockmode; - indexstate->biss_RelationDesc = index_open(node->indexid, lockmode); + indexstate->biss_RelationDesc = ExecOpenScanIndexRelation(estate, + node->indexid, + lockmode); + if (unlikely(!ExecPlanStillValid(estate))) + return indexstate; /* * Initialize index-specific scan state diff --git a/src/backend/executor/nodeBitmapOr.c b/src/backend/executor/nodeBitmapOr.c index de439235d2..980b68dd82 100644 --- a/src/backend/executor/nodeBitmapOr.c +++ b/src/backend/executor/nodeBitmapOr.c @@ -90,6 +90,8 @@ ExecInitBitmapOr(BitmapOr *node, EState *estate, int eflags) { initNode = (Plan *) lfirst(l); bitmapplanstates[i] = ExecInitNode(initNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return bitmaporstate; i++; } diff --git a/src/backend/executor/nodeCustom.c b/src/backend/executor/nodeCustom.c index e559cd2346..2a7c5dccd8 100644 --- a/src/backend/executor/nodeCustom.c +++ b/src/backend/executor/nodeCustom.c @@ -58,6 +58,8 @@ ExecInitCustomScan(CustomScan *cscan, EState *estate, int eflags) if (scanrelid > 0) { scan_rel = ExecOpenScanRelation(estate, scanrelid, eflags); + if (unlikely(scan_rel == NULL || !ExecPlanStillValid(estate))) + return css; css->ss.ss_currentRelation = scan_rel; } diff --git a/src/backend/executor/nodeForeignscan.c b/src/backend/executor/nodeForeignscan.c index 1357ccf3c9..90d5878ae3 100644 --- a/src/backend/executor/nodeForeignscan.c +++ b/src/backend/executor/nodeForeignscan.c @@ -172,6 +172,8 @@ ExecInitForeignScan(ForeignScan *node, EState *estate, int eflags) if (scanrelid > 0) { currentRelation = ExecOpenScanRelation(estate, scanrelid, eflags); + if (unlikely(currentRelation == NULL || !ExecPlanStillValid(estate))) + return scanstate; scanstate->ss.ss_currentRelation = currentRelation; fdwroutine = GetFdwRoutineForRelation(currentRelation, true); } @@ -263,6 +265,8 @@ ExecInitForeignScan(ForeignScan *node, EState *estate, int eflags) if (outerPlan(node)) outerPlanState(scanstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return scanstate; /* * Tell the FDW to initialize the scan. diff --git a/src/backend/executor/nodeGather.c b/src/backend/executor/nodeGather.c index cae5ea1f92..67548aa7ba 100644 --- a/src/backend/executor/nodeGather.c +++ b/src/backend/executor/nodeGather.c @@ -84,6 +84,8 @@ ExecInitGather(Gather *node, EState *estate, int eflags) */ outerNode = outerPlan(node); outerPlanState(gatherstate) = ExecInitNode(outerNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return gatherstate; tupDesc = ExecGetResultType(outerPlanState(gatherstate)); /* diff --git a/src/backend/executor/nodeGatherMerge.c b/src/backend/executor/nodeGatherMerge.c index b36cd89e7d..cf0e074359 100644 --- a/src/backend/executor/nodeGatherMerge.c +++ b/src/backend/executor/nodeGatherMerge.c @@ -103,6 +103,8 @@ ExecInitGatherMerge(GatherMerge *node, EState *estate, int eflags) */ outerNode = outerPlan(node); outerPlanState(gm_state) = ExecInitNode(outerNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return gm_state; /* * Leader may access ExecProcNode result directly (if diff --git a/src/backend/executor/nodeGroup.c b/src/backend/executor/nodeGroup.c index 807429e504..6d0fd9e7b4 100644 --- a/src/backend/executor/nodeGroup.c +++ b/src/backend/executor/nodeGroup.c @@ -184,6 +184,8 @@ ExecInitGroup(Group *node, EState *estate, int eflags) * initialize child nodes */ outerPlanState(grpstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return grpstate; /* * Initialize scan slot and type. diff --git a/src/backend/executor/nodeHash.c b/src/backend/executor/nodeHash.c index dbf4920363..df55e697c0 100644 --- a/src/backend/executor/nodeHash.c +++ b/src/backend/executor/nodeHash.c @@ -385,6 +385,8 @@ ExecInitHash(Hash *node, EState *estate, int eflags) * initialize child nodes */ outerPlanState(hashstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return hashstate; /* * initialize our result slot and type. No need to build projection diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c index 592c098b9f..5e11975702 100644 --- a/src/backend/executor/nodeHashjoin.c +++ b/src/backend/executor/nodeHashjoin.c @@ -760,8 +760,12 @@ ExecInitHashJoin(HashJoin *node, EState *estate, int eflags) hashNode = (Hash *) innerPlan(node); outerPlanState(hjstate) = ExecInitNode(outerNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return hjstate; outerDesc = ExecGetResultType(outerPlanState(hjstate)); innerPlanState(hjstate) = ExecInitNode((Plan *) hashNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return hjstate; innerDesc = ExecGetResultType(innerPlanState(hjstate)); /* diff --git a/src/backend/executor/nodeIncrementalSort.c b/src/backend/executor/nodeIncrementalSort.c index 010bcfafa8..af723ea755 100644 --- a/src/backend/executor/nodeIncrementalSort.c +++ b/src/backend/executor/nodeIncrementalSort.c @@ -1040,6 +1040,8 @@ ExecInitIncrementalSort(IncrementalSort *node, EState *estate, int eflags) * nodes may be able to do something more useful. */ outerPlanState(incrsortstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return incrsortstate; /* * Initialize scan slot and type. diff --git a/src/backend/executor/nodeIndexonlyscan.c b/src/backend/executor/nodeIndexonlyscan.c index 481d479760..109a90fe74 100644 --- a/src/backend/executor/nodeIndexonlyscan.c +++ b/src/backend/executor/nodeIndexonlyscan.c @@ -531,6 +531,8 @@ ExecInitIndexOnlyScan(IndexOnlyScan *node, EState *estate, int eflags) * open the scan relation */ currentRelation = ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(currentRelation == NULL || !ExecPlanStillValid(estate))) + return indexstate; indexstate->ss.ss_currentRelation = currentRelation; indexstate->ss.ss_currentScanDesc = NULL; /* no heap scan here */ @@ -583,7 +585,9 @@ ExecInitIndexOnlyScan(IndexOnlyScan *node, EState *estate, int eflags) /* Open the index relation. */ lockmode = exec_rt_fetch(node->scan.scanrelid, estate)->rellockmode; - indexRelation = index_open(node->indexid, lockmode); + indexRelation = ExecOpenScanIndexRelation(estate, node->indexid, lockmode); + if (unlikely(!ExecPlanStillValid(estate))) + return indexstate; indexstate->ioss_RelationDesc = indexRelation; /* diff --git a/src/backend/executor/nodeIndexscan.c b/src/backend/executor/nodeIndexscan.c index a8172d8b82..db28aeb3d6 100644 --- a/src/backend/executor/nodeIndexscan.c +++ b/src/backend/executor/nodeIndexscan.c @@ -907,6 +907,8 @@ ExecInitIndexScan(IndexScan *node, EState *estate, int eflags) * open the scan relation */ currentRelation = ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(currentRelation == NULL || !ExecPlanStillValid(estate))) + return indexstate; indexstate->ss.ss_currentRelation = currentRelation; indexstate->ss.ss_currentScanDesc = NULL; /* no heap scan here */ @@ -951,7 +953,11 @@ ExecInitIndexScan(IndexScan *node, EState *estate, int eflags) /* Open the index relation. */ lockmode = exec_rt_fetch(node->scan.scanrelid, estate)->rellockmode; - indexstate->iss_RelationDesc = index_open(node->indexid, lockmode); + indexstate->iss_RelationDesc = ExecOpenScanIndexRelation(estate, + node->indexid, + lockmode); + if (unlikely(!ExecPlanStillValid(estate))) + return indexstate; /* * Initialize index-specific scan state diff --git a/src/backend/executor/nodeLimit.c b/src/backend/executor/nodeLimit.c index eb7b6e52be..369c904577 100644 --- a/src/backend/executor/nodeLimit.c +++ b/src/backend/executor/nodeLimit.c @@ -475,6 +475,8 @@ ExecInitLimit(Limit *node, EState *estate, int eflags) */ outerPlan = outerPlan(node); outerPlanState(limitstate) = ExecInitNode(outerPlan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return limitstate; /* * initialize child expressions diff --git a/src/backend/executor/nodeLockRows.c b/src/backend/executor/nodeLockRows.c index 0d3489195b..9077858413 100644 --- a/src/backend/executor/nodeLockRows.c +++ b/src/backend/executor/nodeLockRows.c @@ -322,6 +322,8 @@ ExecInitLockRows(LockRows *node, EState *estate, int eflags) * then initialize outer plan */ outerPlanState(lrstate) = ExecInitNode(outerPlan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return lrstate; /* node returns unmodified slots from the outer plan */ lrstate->ps.resultopsset = true; diff --git a/src/backend/executor/nodeMaterial.c b/src/backend/executor/nodeMaterial.c index 883e3f3933..972962d44d 100644 --- a/src/backend/executor/nodeMaterial.c +++ b/src/backend/executor/nodeMaterial.c @@ -214,6 +214,8 @@ ExecInitMaterial(Material *node, EState *estate, int eflags) outerPlan = outerPlan(node); outerPlanState(matstate) = ExecInitNode(outerPlan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return matstate; /* * Initialize result type and slot. No need to initialize projection info diff --git a/src/backend/executor/nodeMemoize.c b/src/backend/executor/nodeMemoize.c index 690dee1daa..6aaab743b5 100644 --- a/src/backend/executor/nodeMemoize.c +++ b/src/backend/executor/nodeMemoize.c @@ -973,6 +973,8 @@ ExecInitMemoize(Memoize *node, EState *estate, int eflags) outerNode = outerPlan(node); outerPlanState(mstate) = ExecInitNode(outerNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return mstate; /* * Initialize return slot and type. No need to initialize projection info diff --git a/src/backend/executor/nodeMergeAppend.c b/src/backend/executor/nodeMergeAppend.c index 3236444cf1..6e00c90916 100644 --- a/src/backend/executor/nodeMergeAppend.c +++ b/src/backend/executor/nodeMergeAppend.c @@ -81,6 +81,20 @@ ExecInitMergeAppend(MergeAppend *node, EState *estate, int eflags) mergestate->ps.state = estate; mergestate->ps.ExecProcNode = ExecMergeAppend; + /* + * Lock non-leaf partitions whose leaf children are present in + * node->mergeplans. Only need to do so if executing a cached + * plan, because child tables present in cached plans are not + * locked before execution. + * + * XXX - some of the non-leaf partitions may also be mentioned in + * part_prune_info, which would get locked again in + * ExecInitPartitionPruning() because it calls + * ExecGetRangeTableRelation() which locks child tables. + */ + if (estate->es_cachedplan) + ExecLockAppendPartRels(estate, node->allpartrelids); + /* If run-time partition pruning is enabled, then set that up now */ if (node->part_prune_info != NULL) { @@ -120,7 +134,7 @@ ExecInitMergeAppend(MergeAppend *node, EState *estate, int eflags) mergestate->ms_prune_state = NULL; } - mergeplanstates = (PlanState **) palloc(nplans * sizeof(PlanState *)); + mergeplanstates = (PlanState **) palloc0(nplans * sizeof(PlanState *)); mergestate->mergeplans = mergeplanstates; mergestate->ms_nplans = nplans; @@ -151,6 +165,8 @@ ExecInitMergeAppend(MergeAppend *node, EState *estate, int eflags) Plan *initNode = (Plan *) list_nth(node->mergeplans, i); mergeplanstates[j++] = ExecInitNode(initNode, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return mergestate; } mergestate->ps.ps_ProjInfo = NULL; diff --git a/src/backend/executor/nodeMergejoin.c b/src/backend/executor/nodeMergejoin.c index 926e631d88..53cb1ff207 100644 --- a/src/backend/executor/nodeMergejoin.c +++ b/src/backend/executor/nodeMergejoin.c @@ -1490,11 +1490,15 @@ ExecInitMergeJoin(MergeJoin *node, EState *estate, int eflags) mergestate->mj_SkipMarkRestore = node->skip_mark_restore; outerPlanState(mergestate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return mergestate; outerDesc = ExecGetResultType(outerPlanState(mergestate)); innerPlanState(mergestate) = ExecInitNode(innerPlan(node), estate, mergestate->mj_SkipMarkRestore ? eflags : (eflags | EXEC_FLAG_MARK)); + if (unlikely(!ExecPlanStillValid(estate))) + return mergestate; innerDesc = ExecGetResultType(innerPlanState(mergestate)); /* diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c index 062a780f29..aff089799d 100644 --- a/src/backend/executor/nodeModifyTable.c +++ b/src/backend/executor/nodeModifyTable.c @@ -4274,6 +4274,13 @@ ExecInitModifyTable(ModifyTable *node, EState *estate, int eflags) linitial_int(node->resultRelations)); } + /* + * ExecInitResultRelation() may have returned without initializing + * rootResultRelInfo if the plan got invalidated, so check. + */ + if (unlikely(!ExecPlanStillValid(estate))) + return mtstate; + /* set up epqstate with dummy subplan data for the moment */ EvalPlanQualInit(&mtstate->mt_epqstate, estate, NULL, NIL, node->epqParam, node->resultRelations); @@ -4306,6 +4313,10 @@ ExecInitModifyTable(ModifyTable *node, EState *estate, int eflags) { ExecInitResultRelation(estate, resultRelInfo, resultRelation); + /* See the comment above. */ + if (unlikely(!ExecPlanStillValid(estate))) + return mtstate; + /* * For child result relations, store the root result relation * pointer. We do so for the convenience of places that want to @@ -4332,6 +4343,8 @@ ExecInitModifyTable(ModifyTable *node, EState *estate, int eflags) * Now we may initialize the subplan. */ outerPlanState(mtstate) = ExecInitNode(subplan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return mtstate; /* * Do additional per-result-relation initialization. diff --git a/src/backend/executor/nodeNestloop.c b/src/backend/executor/nodeNestloop.c index 01f3d56a3b..34eafbb6e0 100644 --- a/src/backend/executor/nodeNestloop.c +++ b/src/backend/executor/nodeNestloop.c @@ -294,11 +294,15 @@ ExecInitNestLoop(NestLoop *node, EState *estate, int eflags) * values. */ outerPlanState(nlstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return nlstate; if (node->nestParams == NIL) eflags |= EXEC_FLAG_REWIND; else eflags &= ~EXEC_FLAG_REWIND; innerPlanState(nlstate) = ExecInitNode(innerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return nlstate; /* * Initialize result slot, type and projection. diff --git a/src/backend/executor/nodeProjectSet.c b/src/backend/executor/nodeProjectSet.c index ca9a5e2ed2..f834499479 100644 --- a/src/backend/executor/nodeProjectSet.c +++ b/src/backend/executor/nodeProjectSet.c @@ -254,6 +254,8 @@ ExecInitProjectSet(ProjectSet *node, EState *estate, int eflags) * initialize child nodes */ outerPlanState(state) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return state; /* * we don't use inner plan diff --git a/src/backend/executor/nodeRecursiveunion.c b/src/backend/executor/nodeRecursiveunion.c index 7680142c7b..5dd3285c41 100644 --- a/src/backend/executor/nodeRecursiveunion.c +++ b/src/backend/executor/nodeRecursiveunion.c @@ -244,7 +244,11 @@ ExecInitRecursiveUnion(RecursiveUnion *node, EState *estate, int eflags) * initialize child nodes */ outerPlanState(rustate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return rustate; innerPlanState(rustate) = ExecInitNode(innerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return rustate; /* * If hashing, precompute fmgr lookup data for inner loop, and create the diff --git a/src/backend/executor/nodeResult.c b/src/backend/executor/nodeResult.c index e3cfc9b772..7d7c2aa786 100644 --- a/src/backend/executor/nodeResult.c +++ b/src/backend/executor/nodeResult.c @@ -207,6 +207,8 @@ ExecInitResult(Result *node, EState *estate, int eflags) * initialize child nodes */ outerPlanState(resstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return resstate; /* * we don't use inner plan diff --git a/src/backend/executor/nodeSamplescan.c b/src/backend/executor/nodeSamplescan.c index 6ab91001bc..3afdaeecd7 100644 --- a/src/backend/executor/nodeSamplescan.c +++ b/src/backend/executor/nodeSamplescan.c @@ -121,6 +121,9 @@ ExecInitSampleScan(SampleScan *node, EState *estate, int eflags) ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(scanstate->ss.ss_currentRelation == NULL || + !ExecPlanStillValid(estate))) + return scanstate; /* we won't set up the HeapScanDesc till later */ scanstate->ss.ss_currentScanDesc = NULL; diff --git a/src/backend/executor/nodeSeqscan.c b/src/backend/executor/nodeSeqscan.c index b052775e5b..f7fb64a4a2 100644 --- a/src/backend/executor/nodeSeqscan.c +++ b/src/backend/executor/nodeSeqscan.c @@ -153,6 +153,9 @@ ExecInitSeqScan(SeqScan *node, EState *estate, int eflags) ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(scanstate->ss.ss_currentRelation == NULL || + !ExecPlanStillValid(estate))) + return scanstate; /* and create slot with the appropriate rowtype */ ExecInitScanTupleSlot(estate, &scanstate->ss, diff --git a/src/backend/executor/nodeSetOp.c b/src/backend/executor/nodeSetOp.c index fe34b2134f..2231d8b82f 100644 --- a/src/backend/executor/nodeSetOp.c +++ b/src/backend/executor/nodeSetOp.c @@ -528,6 +528,8 @@ ExecInitSetOp(SetOp *node, EState *estate, int eflags) if (node->strategy == SETOP_HASHED) eflags &= ~EXEC_FLAG_REWIND; outerPlanState(setopstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return setopstate; outerDesc = ExecGetResultType(outerPlanState(setopstate)); /* diff --git a/src/backend/executor/nodeSort.c b/src/backend/executor/nodeSort.c index af852464d0..fb76e4c01b 100644 --- a/src/backend/executor/nodeSort.c +++ b/src/backend/executor/nodeSort.c @@ -263,6 +263,8 @@ ExecInitSort(Sort *node, EState *estate, int eflags) eflags &= ~(EXEC_FLAG_REWIND | EXEC_FLAG_BACKWARD | EXEC_FLAG_MARK); outerPlanState(sortstate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return sortstate; /* * Initialize scan slot and type. diff --git a/src/backend/executor/nodeSubqueryscan.c b/src/backend/executor/nodeSubqueryscan.c index 0b2612183a..b5b538fa91 100644 --- a/src/backend/executor/nodeSubqueryscan.c +++ b/src/backend/executor/nodeSubqueryscan.c @@ -124,6 +124,8 @@ ExecInitSubqueryScan(SubqueryScan *node, EState *estate, int eflags) * initialize subquery */ subquerystate->subplan = ExecInitNode(node->subplan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return subquerystate; /* * Initialize scan slot and type (needed by ExecAssignScanProjectionInfo) diff --git a/src/backend/executor/nodeTidrangescan.c b/src/backend/executor/nodeTidrangescan.c index 702ee884d2..a76836d021 100644 --- a/src/backend/executor/nodeTidrangescan.c +++ b/src/backend/executor/nodeTidrangescan.c @@ -377,6 +377,8 @@ ExecInitTidRangeScan(TidRangeScan *node, EState *estate, int eflags) * open the scan relation */ currentRelation = ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(currentRelation == NULL || !ExecPlanStillValid(estate))) + return tidrangestate; tidrangestate->ss.ss_currentRelation = currentRelation; tidrangestate->ss.ss_currentScanDesc = NULL; /* no table scan here */ diff --git a/src/backend/executor/nodeTidscan.c b/src/backend/executor/nodeTidscan.c index f375951699..088babf572 100644 --- a/src/backend/executor/nodeTidscan.c +++ b/src/backend/executor/nodeTidscan.c @@ -522,6 +522,8 @@ ExecInitTidScan(TidScan *node, EState *estate, int eflags) * open the scan relation */ currentRelation = ExecOpenScanRelation(estate, node->scan.scanrelid, eflags); + if (unlikely(currentRelation == NULL || !ExecPlanStillValid(estate))) + return tidstate; tidstate->ss.ss_currentRelation = currentRelation; tidstate->ss.ss_currentScanDesc = NULL; /* no heap scan here */ diff --git a/src/backend/executor/nodeUnique.c b/src/backend/executor/nodeUnique.c index b82d0e9ad5..cb46b2d5d0 100644 --- a/src/backend/executor/nodeUnique.c +++ b/src/backend/executor/nodeUnique.c @@ -135,6 +135,8 @@ ExecInitUnique(Unique *node, EState *estate, int eflags) * then initialize outer plan */ outerPlanState(uniquestate) = ExecInitNode(outerPlan(node), estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return uniquestate; /* * Initialize result slot and type. Unique nodes do no projections, so diff --git a/src/backend/executor/nodeWindowAgg.c b/src/backend/executor/nodeWindowAgg.c index 561d7e731d..1b96f51fe8 100644 --- a/src/backend/executor/nodeWindowAgg.c +++ b/src/backend/executor/nodeWindowAgg.c @@ -2464,6 +2464,8 @@ ExecInitWindowAgg(WindowAgg *node, EState *estate, int eflags) */ outerPlan = outerPlan(node); outerPlanState(winstate) = ExecInitNode(outerPlan, estate, eflags); + if (unlikely(!ExecPlanStillValid(estate))) + return winstate; /* * initialize source tuple type (which is also the tuple type that we'll diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c index d6516b1bca..5885a1d056 100644 --- a/src/backend/executor/spi.c +++ b/src/backend/executor/spi.c @@ -70,7 +70,7 @@ static int _SPI_execute_plan(SPIPlanPtr plan, const SPIExecuteOptions *options, static ParamListInfo _SPI_convert_params(int nargs, Oid *argtypes, Datum *Values, const char *Nulls); -static int _SPI_pquery(QueryDesc *queryDesc, bool fire_triggers, uint64 tcount); +static int _SPI_pquery(QueryDesc *queryDesc, uint64 tcount); static void _SPI_error_callback(void *arg); @@ -1581,6 +1581,7 @@ SPI_cursor_open_internal(const char *name, SPIPlanPtr plan, Snapshot snapshot; MemoryContext oldcontext; Portal portal; + bool plan_valid; SPICallbackArg spicallbackarg; ErrorContextCallback spierrcontext; @@ -1622,6 +1623,7 @@ SPI_cursor_open_internal(const char *name, SPIPlanPtr plan, _SPI_current->processed = 0; _SPI_current->tuptable = NULL; +replan: /* Create the portal */ if (name == NULL || name[0] == '\0') { @@ -1765,15 +1767,24 @@ SPI_cursor_open_internal(const char *name, SPIPlanPtr plan, } /* - * Start portal execution. + * Start portal execution. If the portal contains a cached plan, it must + * be recreated if the cached plan was found to have been invalidated when + * initializing one of the plan trees contained in it. */ - PortalStart(portal, paramLI, 0, snapshot); + plan_valid = PortalStart(portal, paramLI, 0, snapshot, cplan); Assert(portal->strategy != PORTAL_MULTI_QUERY); /* Pop the error context stack */ error_context_stack = spierrcontext.previous; + if (!plan_valid) + { + Assert(cplan != NULL); + PortalDrop(portal, false); + goto replan; + } + /* Pop the SPI stack */ _SPI_end_call(true); @@ -2568,6 +2579,7 @@ _SPI_execute_plan(SPIPlanPtr plan, const SPIExecuteOptions *options, * Replan if needed, and increment plan refcount. If it's a saved * plan, the refcount must be backed by the plan_owner. */ +replan: cplan = GetCachedPlan(plansource, options->params, plan_owner, _SPI_current->queryEnv); @@ -2677,6 +2689,7 @@ _SPI_execute_plan(SPIPlanPtr plan, const SPIExecuteOptions *options, { QueryDesc *qdesc; Snapshot snap; + int eflags; if (ActiveSnapshotSet()) snap = GetActiveSnapshot(); @@ -2690,8 +2703,20 @@ _SPI_execute_plan(SPIPlanPtr plan, const SPIExecuteOptions *options, options->params, _SPI_current->queryEnv, 0); - res = _SPI_pquery(qdesc, fire_triggers, - canSetTag ? options->tcount : 0); + + /* Select execution options */ + if (fire_triggers) + eflags = 0; /* default run-to-completion flags */ + else + eflags = EXEC_FLAG_SKIP_TRIGGERS; + + if (!TryExecutorStart(qdesc, cplan, eflags)) + { + ReleaseCachedPlan(cplan, plan_owner); + goto replan; + } + + res = _SPI_pquery(qdesc, canSetTag ? options->tcount : 0); FreeQueryDesc(qdesc); } else @@ -2865,10 +2890,9 @@ _SPI_convert_params(int nargs, Oid *argtypes, } static int -_SPI_pquery(QueryDesc *queryDesc, bool fire_triggers, uint64 tcount) +_SPI_pquery(QueryDesc *queryDesc, uint64 tcount) { int operation = queryDesc->operation; - int eflags; int res; switch (operation) @@ -2915,14 +2939,6 @@ _SPI_pquery(QueryDesc *queryDesc, bool fire_triggers, uint64 tcount) ResetUsage(); #endif - /* Select execution options */ - if (fire_triggers) - eflags = 0; /* default run-to-completion flags */ - else - eflags = EXEC_FLAG_SKIP_TRIGGERS; - - ExecutorStart(queryDesc, eflags); - ExecutorRun(queryDesc, ForwardScanDirection, tcount, true); _SPI_current->processed = queryDesc->estate->es_processed; diff --git a/src/backend/optimizer/util/inherit.c b/src/backend/optimizer/util/inherit.c index 4797312ae5..be6e4ddfdf 100644 --- a/src/backend/optimizer/util/inherit.c +++ b/src/backend/optimizer/util/inherit.c @@ -493,6 +493,13 @@ expand_single_inheritance_child(PlannerInfo *root, RangeTblEntry *parentrte, } else childrte->inh = false; + + /* + * Flag child tables as indirectly referenced in the query. This is to + * allow ExecGetRangeTableRelation() recognize them as inheritance + * child tables. + */ + childrte->inFromCl = false; childrte->securityQuals = NIL; /* No permission checking for child RTEs. */ diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c index e901203424..fe7ad7b82f 100644 --- a/src/backend/parser/analyze.c +++ b/src/backend/parser/analyze.c @@ -3327,10 +3327,9 @@ transformLockingClause(ParseState *pstate, Query *qry, LockingClause *lc, /* * Lock all regular tables used in query and its subqueries. We * examine inFromCl to exclude auto-added RTEs, particularly NEW/OLD - * in rules. This is a bit of an abuse of a mostly-obsolete flag, but - * it's convenient. We can't rely on the namespace mechanism that has - * largely replaced inFromCl, since for example we need to lock - * base-relation RTEs even if they are masked by upper joins. + * in rules. We can't rely on the namespace mechanism since for + * example we need to lock base-relation RTEs even if they are masked + * by upper joins. */ i = 0; foreach(rt, qry->rtable) diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 8bc6bea113..4f2196aaaf 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -1241,8 +1241,11 @@ exec_simple_query(const char *query_string) /* * Start the portal. No parameters here. + * + * Plan can't become invalid here, because there's no CachedPlan. */ - PortalStart(portal, NULL, 0, InvalidSnapshot); + if (!PortalStart(portal, NULL, 0, InvalidSnapshot, NULL)) + elog(ERROR, "unexpected failure running PortalStart()"); /* * Select the appropriate output format: text unless we are doing a @@ -1747,6 +1750,7 @@ exec_bind_message(StringInfo input_message) "commands ignored until end of transaction block"), errdetail_abort())); +replan: /* * Create the portal. Allow silent replacement of an existing portal only * if the unnamed portal is specified. @@ -2034,9 +2038,16 @@ exec_bind_message(StringInfo input_message) PopActiveSnapshot(); /* - * And we're ready to start portal execution. + * Start portal execution. If the portal contains a cached plan, it must + * be recreated if the cached plan was found to have been invalidated when + * initializing one of the plan trees contained in it. */ - PortalStart(portal, params, 0, InvalidSnapshot); + if (!PortalStart(portal, params, 0, InvalidSnapshot, cplan)) + { + Assert(cplan != NULL); + PortalDrop(portal, false); + goto replan; + } /* * Apply the result format requests to the portal. diff --git a/src/backend/tcop/pquery.c b/src/backend/tcop/pquery.c index a1f8d03db1..ea33da4c2a 100644 --- a/src/backend/tcop/pquery.c +++ b/src/backend/tcop/pquery.c @@ -19,6 +19,7 @@ #include "access/xact.h" #include "commands/prepare.h" +#include "executor/execdesc.h" #include "executor/tstoreReceiver.h" #include "miscadmin.h" #include "pg_trace.h" @@ -34,8 +35,7 @@ */ Portal ActivePortal = NULL; - -static void ProcessQuery(PlannedStmt *plan, +static void ProcessQuery(QueryDesc *queryDesc, const char *sourceText, ParamListInfo params, QueryEnvironment *queryEnv, @@ -115,13 +115,12 @@ FreeQueryDesc(QueryDesc *qdesc) pfree(qdesc); } - /* * ProcessQuery * Execute a single plannable query within a PORTAL_MULTI_QUERY, * PORTAL_ONE_RETURNING, or PORTAL_ONE_MOD_WITH portal * - * plan: the plan tree for the query + * queryDesc: QueryDesc created in PortalStart() * sourceText: the source text of the query * params: any parameters needed * dest: where to send results @@ -133,26 +132,14 @@ FreeQueryDesc(QueryDesc *qdesc) * error; otherwise the executor's memory usage will be leaked. */ static void -ProcessQuery(PlannedStmt *plan, +ProcessQuery(QueryDesc *queryDesc, const char *sourceText, ParamListInfo params, QueryEnvironment *queryEnv, DestReceiver *dest, QueryCompletion *qc) { - QueryDesc *queryDesc; - - /* - * Create the QueryDesc object - */ - queryDesc = CreateQueryDesc(plan, sourceText, - GetActiveSnapshot(), InvalidSnapshot, - dest, params, queryEnv, 0); - - /* - * Call ExecutorStart to prepare the plan for execution - */ - ExecutorStart(queryDesc, 0); + queryDesc->dest = dest; /* * Run the plan to completion. @@ -426,19 +413,22 @@ FetchStatementTargetList(Node *stmt) * presently ignored for non-PORTAL_ONE_SELECT portals (it's only intended * to be used for cursors). * - * On return, portal is ready to accept PortalRun() calls, and the result - * tupdesc (if any) is known. + * True is returned if portal is ready to accept PortalRun() calls, and the + * result tupdesc (if any) is known. False if the plan tree is no longer + * valid, in which case, the caller must retry after generating a new + * CachedPlan. */ -void +bool PortalStart(Portal portal, ParamListInfo params, - int eflags, Snapshot snapshot) + int eflags, Snapshot snapshot, + CachedPlan *cplan) { Portal saveActivePortal; ResourceOwner saveResourceOwner; - MemoryContext savePortalContext; MemoryContext oldContext; QueryDesc *queryDesc; - int myeflags; + int myeflags = 0; + bool plan_valid = true; Assert(PortalIsValid(portal)); Assert(portal->status == PORTAL_DEFINED); @@ -448,15 +438,13 @@ PortalStart(Portal portal, ParamListInfo params, */ saveActivePortal = ActivePortal; saveResourceOwner = CurrentResourceOwner; - savePortalContext = PortalContext; PG_TRY(); { ActivePortal = portal; if (portal->resowner) CurrentResourceOwner = portal->resowner; - PortalContext = portal->portalContext; - oldContext = MemoryContextSwitchTo(PortalContext); + oldContext = MemoryContextSwitchTo(portal->queryContext); /* Must remember portal param list, if any */ portal->portalParams = params; @@ -472,6 +460,8 @@ PortalStart(Portal portal, ParamListInfo params, switch (portal->strategy) { case PORTAL_ONE_SELECT: + case PORTAL_ONE_RETURNING: + case PORTAL_ONE_MOD_WITH: /* Must set snapshot before starting executor. */ if (snapshot) @@ -489,8 +479,8 @@ PortalStart(Portal portal, ParamListInfo params, */ /* - * Create QueryDesc in portal's context; for the moment, set - * the destination to DestNone. + * Create QueryDesc in portal->queryContext; for the moment, + * set the destination to DestNone. */ queryDesc = CreateQueryDesc(linitial_node(PlannedStmt, portal->stmts), portal->sourceText, @@ -501,30 +491,49 @@ PortalStart(Portal portal, ParamListInfo params, portal->queryEnv, 0); + /* Remember for PortalRunMulti(). */ + if (portal->strategy == PORTAL_ONE_RETURNING || + portal->strategy == PORTAL_ONE_MOD_WITH) + portal->qdescs = list_make1(queryDesc); + /* * If it's a scrollable cursor, executor needs to support * REWIND and backwards scan, as well as whatever the caller * might've asked for. */ - if (portal->cursorOptions & CURSOR_OPT_SCROLL) + if (portal->strategy == PORTAL_ONE_SELECT && + (portal->cursorOptions & CURSOR_OPT_SCROLL)) myeflags = eflags | EXEC_FLAG_REWIND | EXEC_FLAG_BACKWARD; else myeflags = eflags; /* - * Call ExecutorStart to prepare the plan for execution + * Call TryExecutorStart to prepare the plan for execution. A + * cached plan may get invalidated during plan intialization. */ - ExecutorStart(queryDesc, myeflags); + if (!TryExecutorStart(queryDesc, cplan, myeflags)) + { + PopActiveSnapshot(); + plan_valid = false; + goto plan_init_failed; + } /* - * This tells PortalCleanup to shut down the executor + * This tells PortalCleanup to shut down the executor, though + * not needed for queries handled by PortalRunMulti(). */ - portal->queryDesc = queryDesc; + if (portal->strategy == PORTAL_ONE_SELECT) + portal->queryDesc = queryDesc; /* - * Remember tuple descriptor (computed by ExecutorStart) + * Remember tuple descriptor (computed by ExecutorStart), + * though make it independent of QueryDesc for queries handled + * by PortalRunMulti(). */ - portal->tupDesc = queryDesc->tupDesc; + if (portal->strategy != PORTAL_ONE_SELECT) + portal->tupDesc = CreateTupleDescCopy(queryDesc->tupDesc); + else + portal->tupDesc = queryDesc->tupDesc; /* * Reset cursor position data to "start of query" @@ -536,29 +545,6 @@ PortalStart(Portal portal, ParamListInfo params, PopActiveSnapshot(); break; - case PORTAL_ONE_RETURNING: - case PORTAL_ONE_MOD_WITH: - - /* - * We don't start the executor until we are told to run the - * portal. We do need to set up the result tupdesc. - */ - { - PlannedStmt *pstmt; - - pstmt = PortalGetPrimaryStmt(portal); - portal->tupDesc = - ExecCleanTypeFromTL(pstmt->planTree->targetlist); - } - - /* - * Reset cursor position data to "start of query" - */ - portal->atStart = true; - portal->atEnd = false; /* allow fetches */ - portal->portalPos = 0; - break; - case PORTAL_UTIL_SELECT: /* @@ -581,7 +567,79 @@ PortalStart(Portal portal, ParamListInfo params, break; case PORTAL_MULTI_QUERY: - /* Need do nothing now */ + { + ListCell *lc; + bool first = true; + + myeflags = eflags; + foreach(lc, portal->stmts) + { + PlannedStmt *plan = lfirst_node(PlannedStmt, lc); + bool is_utility = (plan->utilityStmt != NULL); + + /* + * Push the snapshot to be used by the executor. + */ + if (!is_utility) + { + /* + * Must copy the snapshot for all statements + * except thec first as we'll need to update its + * command ID. + */ + if (!first) + PushCopiedSnapshot(GetTransactionSnapshot()); + else + PushActiveSnapshot(GetTransactionSnapshot()); + } + + /* + * From the 2nd statement onwards, update the command + * ID and the snapshot to match. + */ + if (!first) + { + CommandCounterIncrement(); + UpdateActiveSnapshotCommandId(); + } + + first = false; + + /* + * Create the QueryDesc. DestReceiver will be set in + * PortalRunMulti() before calling ExecutorRun(). + */ + queryDesc = CreateQueryDesc(plan, + portal->sourceText, + !is_utility ? + GetActiveSnapshot() : + InvalidSnapshot, + InvalidSnapshot, + NULL, + params, + portal->queryEnv, 0); + + /* Remember for PortalRunMulti() */ + portal->qdescs = lappend(portal->qdescs, queryDesc); + + if (is_utility) + continue; + + /* + * Call ExecutorStart to prepare the plan for + * execution. A cached plan may get invalidated + * during plan intialization. + */ + if (!ExecutorStart(queryDesc, cplan, myeflags)) + { + PopActiveSnapshot(); + plan_valid = false; + goto plan_init_failed; + } + PopActiveSnapshot(); + } + } + portal->tupDesc = NULL; break; } @@ -594,19 +652,20 @@ PortalStart(Portal portal, ParamListInfo params, /* Restore global vars and propagate error */ ActivePortal = saveActivePortal; CurrentResourceOwner = saveResourceOwner; - PortalContext = savePortalContext; PG_RE_THROW(); } PG_END_TRY(); + portal->status = PORTAL_READY; + +plan_init_failed: MemoryContextSwitchTo(oldContext); ActivePortal = saveActivePortal; CurrentResourceOwner = saveResourceOwner; - PortalContext = savePortalContext; - portal->status = PORTAL_READY; + return plan_valid; } /* @@ -1193,8 +1252,8 @@ PortalRunMulti(Portal portal, DestReceiver *dest, DestReceiver *altdest, QueryCompletion *qc) { - bool active_snapshot_set = false; - ListCell *stmtlist_item; + bool holdSnapshotSet = false; + ListCell *qdesc_item; /* * If the destination is DestRemoteExecute, change to DestNone. The @@ -1215,9 +1274,10 @@ PortalRunMulti(Portal portal, * Loop to handle the individual queries generated from a single parsetree * by analysis and rewrite. */ - foreach(stmtlist_item, portal->stmts) + foreach(qdesc_item, portal->qdescs) { - PlannedStmt *pstmt = lfirst_node(PlannedStmt, stmtlist_item); + QueryDesc *qdesc = (QueryDesc *) lfirst(qdesc_item); + PlannedStmt *pstmt = qdesc->plannedstmt; /* * If we got a cancel signal in prior command, quit @@ -1234,48 +1294,33 @@ PortalRunMulti(Portal portal, if (log_executor_stats) ResetUsage(); + /* Push the snapshot for plannable queries. */ + PushActiveSnapshot(qdesc->snapshot); + /* - * Must always have a snapshot for plannable queries. First time - * through, take a new snapshot; for subsequent queries in the - * same portal, just update the snapshot's copy of the command - * counter. + * If told to, register the snapshot and save in portal + * + * Note that the command ID of qdesc->snapshot for 2nd query + * onwards would have been updated in PortalStart() to account + * for CCI() done between queries, but it's okay for the command + * ID of the active snapshot to diverge from what holdSnapshot + * has. */ - if (!active_snapshot_set) + if (setHoldSnapshot && !holdSnapshotSet) { - Snapshot snapshot = GetTransactionSnapshot(); - - /* If told to, register the snapshot and save in portal */ - if (setHoldSnapshot) - { - snapshot = RegisterSnapshot(snapshot); - portal->holdSnapshot = snapshot; - } - - /* - * We can't have the holdSnapshot also be the active one, - * because UpdateActiveSnapshotCommandId would complain. So - * force an extra snapshot copy. Plain PushActiveSnapshot - * would have copied the transaction snapshot anyway, so this - * only adds a copy step when setHoldSnapshot is true. (It's - * okay for the command ID of the active snapshot to diverge - * from what holdSnapshot has.) - */ - PushCopiedSnapshot(snapshot); - - /* - * As for PORTAL_ONE_SELECT portals, it does not seem - * necessary to maintain portal->portalSnapshot here. - */ - - active_snapshot_set = true; + portal->holdSnapshot = RegisterSnapshot(qdesc->snapshot); + holdSnapshotSet = true; } - else - UpdateActiveSnapshotCommandId(); + + /* + * As for PORTAL_ONE_SELECT portals, it does not seem + * necessary to maintain portal->portalSnapshot here. + */ if (pstmt->canSetTag) { /* statement can set tag string */ - ProcessQuery(pstmt, + ProcessQuery(qdesc, portal->sourceText, portal->portalParams, portal->queryEnv, @@ -1284,13 +1329,15 @@ PortalRunMulti(Portal portal, else { /* stmt added by rewrite cannot set tag */ - ProcessQuery(pstmt, + ProcessQuery(qdesc, portal->sourceText, portal->portalParams, portal->queryEnv, altdest, NULL); } + PopActiveSnapshot(); + if (log_executor_stats) ShowUsage("EXECUTOR STATISTICS"); @@ -1311,7 +1358,6 @@ PortalRunMulti(Portal portal, */ if (pstmt->canSetTag) { - Assert(!active_snapshot_set); /* statement can set tag string */ PortalRunUtility(portal, pstmt, isTopLevel, false, dest, qc); @@ -1342,19 +1388,8 @@ PortalRunMulti(Portal portal, */ if (portal->stmts == NIL) break; - - /* - * Increment command counter between queries, but not after the last - * one. - */ - if (lnext(portal->stmts, stmtlist_item) != NULL) - CommandCounterIncrement(); } - /* Pop the snapshot if we pushed one. */ - if (active_snapshot_set) - PopActiveSnapshot(); - /* * If a query completion data was supplied, use it. Otherwise use the * portal's query completion data. diff --git a/src/backend/utils/mmgr/portalmem.c b/src/backend/utils/mmgr/portalmem.c index 4a24613537..2d5ba638f7 100644 --- a/src/backend/utils/mmgr/portalmem.c +++ b/src/backend/utils/mmgr/portalmem.c @@ -200,6 +200,13 @@ CreatePortal(const char *name, bool allowDup, bool dupSilent) portal->portalContext = AllocSetContextCreate(TopPortalContext, "PortalContext", ALLOCSET_SMALL_SIZES); + /* + * initialize portal's query context to store QueryDescs created during + * PortalStart() and then used in PortalRun(). + */ + portal->queryContext = AllocSetContextCreate(TopPortalContext, + "PortalQueryContext", + ALLOCSET_SMALL_SIZES); /* create a resource owner for the portal */ portal->resowner = ResourceOwnerCreate(CurTransactionResourceOwner, @@ -223,6 +230,7 @@ CreatePortal(const char *name, bool allowDup, bool dupSilent) /* for named portals reuse portal->name copy */ MemoryContextSetIdentifier(portal->portalContext, portal->name[0] ? portal->name : ""); + MemoryContextSetIdentifier(portal->queryContext, portal->name[0] ? portal->name : ""); return portal; } @@ -593,6 +601,7 @@ PortalDrop(Portal portal, bool isTopCommit) /* release subsidiary storage */ MemoryContextDelete(portal->portalContext); + MemoryContextDelete(portal->queryContext); /* release portal struct (it's in TopPortalContext) */ pfree(portal); diff --git a/src/include/commands/explain.h b/src/include/commands/explain.h index 9b8b351d9a..78292c69f9 100644 --- a/src/include/commands/explain.h +++ b/src/include/commands/explain.h @@ -101,7 +101,8 @@ extern void ExplainOneUtility(Node *utilityStmt, IntoClause *into, ExplainState *es, const char *queryString, ParamListInfo params, QueryEnvironment *queryEnv); -extern void ExplainOnePlan(PlannedStmt *plannedstmt, IntoClause *into, +extern bool ExplainOnePlan(PlannedStmt *stmt, CachedPlan *cplan, + IntoClause *into, ExplainState *es, const char *queryString, ParamListInfo params, QueryEnvironment *queryEnv, const instr_time *planduration, @@ -118,6 +119,7 @@ extern void ExplainQueryParameters(ExplainState *es, ParamListInfo params, int m extern void ExplainBeginOutput(ExplainState *es); extern void ExplainEndOutput(ExplainState *es); +extern void ExplainResetOutput(ExplainState *es); extern void ExplainSeparatePlans(ExplainState *es); extern void ExplainPropertyList(const char *qlabel, List *data, diff --git a/src/include/commands/trigger.h b/src/include/commands/trigger.h index 8a5a9fe642..d3e6cf24cb 100644 --- a/src/include/commands/trigger.h +++ b/src/include/commands/trigger.h @@ -257,6 +257,7 @@ extern void ExecASTruncateTriggers(EState *estate, extern void AfterTriggerBeginXact(void); extern void AfterTriggerBeginQuery(void); +extern void AfterTriggerCancelQuery(void); extern void AfterTriggerEndQuery(EState *estate); extern void AfterTriggerFireDeferred(void); extern void AfterTriggerEndXact(bool isCommit); diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index 9770752ea3..1dbc0997ae 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -19,6 +19,7 @@ #include "nodes/lockoptions.h" #include "nodes/parsenodes.h" #include "utils/memutils.h" +#include "utils/plancache.h" /* @@ -72,7 +73,8 @@ /* Hook for plugins to get control in ExecutorStart() */ -typedef void (*ExecutorStart_hook_type) (QueryDesc *queryDesc, int eflags); +typedef bool (*ExecutorStart_hook_type) (QueryDesc *queryDesc, CachedPlan *cplan, + int eflags); extern PGDLLIMPORT ExecutorStart_hook_type ExecutorStart_hook; /* Hook for plugins to get control in ExecutorRun() */ @@ -197,8 +199,10 @@ ExecGetJunkAttribute(TupleTableSlot *slot, AttrNumber attno, bool *isNull) /* * prototypes from functions in execMain.c */ -extern void ExecutorStart(QueryDesc *queryDesc, int eflags); -extern void standard_ExecutorStart(QueryDesc *queryDesc, int eflags); +extern bool ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags); +extern bool TryExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, int eflags); +extern bool standard_ExecutorStart(QueryDesc *queryDesc, CachedPlan *cplan, + int eflags); extern void ExecutorRun(QueryDesc *queryDesc, ScanDirection direction, uint64 count, bool execute_once); extern void standard_ExecutorRun(QueryDesc *queryDesc, @@ -257,6 +261,15 @@ extern void ExecEndNode(PlanState *node); extern void ExecShutdownNode(PlanState *node); extern void ExecSetTupleBound(int64 tuples_needed, PlanState *child_node); +/* + * Is the CachedPlan in es_cachedplan still valid? + */ +static inline bool +ExecPlanStillValid(EState *estate) +{ + return estate->es_cachedplan == NULL ? true : + CachedPlanStillValid(estate->es_cachedplan); +} /* ---------------------------------------------------------------- * ExecProcNode @@ -578,6 +591,7 @@ extern void ExecCreateScanSlotFromOuterPlan(EState *estate, extern bool ExecRelationIsTargetRelation(EState *estate, Index scanrelid); extern Relation ExecOpenScanRelation(EState *estate, Index scanrelid, int eflags); +extern Relation ExecOpenScanIndexRelation(EState *estate, Oid indexid, int lockmode); extern void ExecInitRangeTable(EState *estate, List *rangeTable, List *permInfos); extern void ExecCloseRangeTableRelations(EState *estate); @@ -590,6 +604,7 @@ exec_rt_fetch(Index rti, EState *estate) } extern Relation ExecGetRangeTableRelation(EState *estate, Index rti); +extern void ExecLockAppendPartRels(EState *estate, List *allpartrelids); extern void ExecInitResultRelation(EState *estate, ResultRelInfo *resultRelInfo, Index rti); diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index c3670f7158..4bc6d9d461 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -631,6 +631,8 @@ typedef struct EState * ExecRowMarks, or NULL if none */ List *es_rteperminfos; /* List of RTEPermissionInfo */ PlannedStmt *es_plannedstmt; /* link to top of plan tree */ + struct CachedPlan *es_cachedplan; /* CachedPlan if plannedstmt is from + * one, or NULL if not */ const char *es_sourceText; /* Source text from QueryDesc */ JunkFilter *es_junkFilter; /* top-level junk filter, if any */ @@ -676,6 +678,9 @@ typedef struct EState int es_top_eflags; /* eflags passed to ExecutorStart */ int es_instrument; /* OR of InstrumentOption flags */ bool es_finished; /* true when ExecutorFinish is done */ + bool es_canceled; /* true when execution was canceled + * upon encountering that plan was invalided + * during ExecInitNode() */ List *es_exprcontexts; /* List of ExprContexts within EState */ diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h index 85a62b538e..e8f14982c0 100644 --- a/src/include/nodes/parsenodes.h +++ b/src/include/nodes/parsenodes.h @@ -1009,11 +1009,15 @@ typedef struct PartitionCmd * * inFromCl marks those range variables that are listed in the FROM clause. * It's false for RTEs that are added to a query behind the scenes, such - * as the NEW and OLD variables for a rule, or the subqueries of a UNION. + * as the NEW and OLD variables for a rule, or the subqueries of a UNION, + * or the RTEs of inheritance child tables that are added by the planner. * This flag is not used during parsing (except in transformLockingClause, * q.v.); the parser now uses a separate "namespace" data structure to * control visibility. But it is needed by ruleutils.c to determine - * whether RTEs should be shown in decompiled queries. + * whether RTEs should be shown in decompiled queries. The executor uses + * this to ascertain if an RTE_RELATION entry is for a table explicitly + * named in the query or a child table added by the planner. This + * distinction is vital when child tables in a plan must be locked. * * securityQuals is a list of security barrier quals (boolean expressions), * to be tested in the listed order before returning a row from the diff --git a/src/include/tcop/pquery.h b/src/include/tcop/pquery.h index 073fb323bc..274510598f 100644 --- a/src/include/tcop/pquery.h +++ b/src/include/tcop/pquery.h @@ -29,8 +29,9 @@ extern List *FetchPortalTargetList(Portal portal); extern List *FetchStatementTargetList(Node *stmt); -extern void PortalStart(Portal portal, ParamListInfo params, - int eflags, Snapshot snapshot); +extern bool PortalStart(Portal portal, ParamListInfo params, + int eflags, Snapshot snapshot, + CachedPlan *cplan); extern void PortalSetResultFormat(Portal portal, int nFormats, int16 *formats); diff --git a/src/include/utils/plancache.h b/src/include/utils/plancache.h index a90dfdf906..f88e2abad2 100644 --- a/src/include/utils/plancache.h +++ b/src/include/utils/plancache.h @@ -223,6 +223,20 @@ extern CachedPlan *GetCachedPlan(CachedPlanSource *plansource, ParamListInfo boundParams, ResourceOwner owner, QueryEnvironment *queryEnv); + +/* + * CachedPlanStillValid + * Returns if a cached generic plan is still valid + * + * Invoked by the executor for each relation lock acquired during the + * initialization of the plan tree within the CachedPlan. + */ +static inline bool +CachedPlanStillValid(CachedPlan *cplan) +{ + return cplan->is_valid; +} + extern void ReleaseCachedPlan(CachedPlan *plan, ResourceOwner owner); extern bool CachedPlanAllowsSimpleValidityCheck(CachedPlanSource *plansource, diff --git a/src/include/utils/portal.h b/src/include/utils/portal.h index 29f49829f2..c0707c4876 100644 --- a/src/include/utils/portal.h +++ b/src/include/utils/portal.h @@ -138,6 +138,8 @@ typedef struct PortalData QueryCompletion qc; /* command completion data for executed query */ List *stmts; /* list of PlannedStmts */ CachedPlan *cplan; /* CachedPlan, if stmts are from one */ + List *qdescs; /* list of QueryDescs */ + MemoryContext queryContext; /* memory for QueryDescs and children */ ParamListInfo portalParams; /* params to pass to query */ QueryEnvironment *queryEnv; /* environment for query */ -- 2.43.0