public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Langote <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Rahila Syed <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert
Date: Fri, 16 Jan 2026 14:52:49 +0900
Message-ID: <CA+HiwqHSSqUDLrPcBtydSdMuX+KPt7ROhDDLaN_XyeqG8vi99w@mail.gmail.com> (raw)
In-Reply-To: <CA+HiwqG7uO2+c0AV8CWt7qG1izzN3PjdKDtgMqK9a0tiNvzHnw@mail.gmail.com>
References: <CA+HiwqHzTpLH9q3XHSiXndCgVYi8CvaeOcMgu7ZoYS2XOYqtiA@mail.gmail.com>
	<[email protected]>
	<CA+HiwqG7uO2+c0AV8CWt7qG1izzN3PjdKDtgMqK9a0tiNvzHnw@mail.gmail.com>

Hi Álvaro,

On Wed, Jan 14, 2026 at 10:56 PM Amit Langote <[email protected]> wrote:
> On Wed, Jan 14, 2026 at 6:36 PM Álvaro Herrera <[email protected]> wrote
> > I would add an Assert(num_held_lwlocks == 0) at the
> > end of LWLockReleaseAll(), to make it clear that it's idempotent (which
> > is important for the case where ProcKill will call it again shortly
> > after).
>
> Makes sense.  Will do.

Done and pushed.  I struggled to write a comment to describe the Assert though.

-- 
Thanks, Amit Langote

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Segmentation fault on proc exit after dshash_find_or_insert
  In-Reply-To: <CA+HiwqHSSqUDLrPcBtydSdMuX+KPt7ROhDDLaN_XyeqG8vi99w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox