MIME-Version: 1.0
References: <20230408191007.7lysd42euafwl74f@awork3.anarazel.de>
 <3611416.1680982220@sss.pgh.pa.us> <CA+TgmobY5DO3CX_kzjyFKEYg7vTdvoFJd=Y0qLabd8K3eAdf6Q@mail.gmail.com>
 <4179373.1681145767@sss.pgh.pa.us> <CA+TgmoZwJ09Aw_igiLV7J-OPikii5PyW_iJyXCFtS1MdcY7hJQ@mail.gmail.com>
In-Reply-To: <CA+TgmoZwJ09Aw_igiLV7J-OPikii5PyW_iJyXCFtS1MdcY7hJQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 10 Apr 2023 19:55:35 +0100
Message-ID: <CA+OCxoxCZ2Q4vz0oznYqDgU4aZYv0GXO4TytkD070OjUp0OJeQ@mail.gmail.com>
Subject: Re: When to drop src/tools/msvc support
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Amit Kapila <amit.kapila16@gmail.com>, 
	Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, 
	"Jonathan S. Katz" <jkatz@postgresql.org>, Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>, 
	pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000314d1505f8ffec3f"
Archived-At: <https://www.postgresql.org/message-id/CA%2BOCxoxCZ2Q4vz0oznYqDgU4aZYv0GXO4TytkD070OjUp0OJeQ%40mail.gmail.com>
Precedence: bulk

--000000000000314d1505f8ffec3f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 10 Apr 2023 at 18:34, Robert Haas <robertmhaas@gmail.com> wrote:

> On Mon, Apr 10, 2023 at 12:56=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
> > Robert Haas <robertmhaas@gmail.com> writes:
> > > However, if this is the direction we're going, we probably need to
> > > give pgsql-packagers a heads up ASAP, because anybody who is still
> > > relying on the MSVC system to build Windows binaries is presumably
> > > going to need some time to adjust. If we rip out the build system
> > > somebody is using a couple of weeks before beta, that might make it
> > > difficult for that person to get the beta out promptly. And I think
> > > there's probably more than just EDB who would be in that situation.
> >
> > Oh ... that's a good point.  Is there anyone besides EDB shipping
> > MSVC-built executables?  Would it even be practical to switch to
> > meson with a month-or-so notice?  Seems kind of tight, and it's
> > not like the packagers volunteered to make this switch.
>
> I can't really speak to those questions with confidence.
>
> Perhaps instead of telling pgsql-packagers what we're doing, we could
> instead ask them if it would work for them if we did XYZ. Then we
> could use that information to inform our decision-making.


Projects other than the EDB installers use the MSVC build system - e.g.
pgAdmin uses it=E2=80=99s own builds of libpq and other tools (psql, pg_dum=
p etc)
that are pretty heavily baked into a fully automated build system (even the
build servers and all their requirements are baked into Ansible).

Changing that lot would be non-trivial, though certainly possible, and I
suspect we=E2=80=99re not the only ones doing that sort of thing.

--=20
--=20
Dave Page
https://pgsnake.blogspot.com

EDB Postgres
https://www.enterprisedb.com

--000000000000314d1505f8ffec3f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><br></div><div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">On Mon, 10 Apr 2023 at 18:34, Robert Haas &lt;<a href=3D"ma=
ilto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rg=
b(204,204,204)" dir=3D"auto">On Mon, Apr 10, 2023 at 12:56=E2=80=AFPM Tom L=
ane &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us" target=3D"_blank">tgl@sss.pgh.=
pa.us</a>&gt; wrote:<br>
&gt; Robert Haas &lt;<a href=3D"mailto:robertmhaas@gmail.com" target=3D"_bl=
ank">robertmhaas@gmail.com</a>&gt; writes:<br>
&gt; &gt; However, if this is the direction we&#39;re going, we probably ne=
ed to<br>
&gt; &gt; give pgsql-packagers a heads up ASAP, because anybody who is stil=
l<br>
&gt; &gt; relying on the MSVC system to build Windows binaries is presumabl=
y<br>
&gt; &gt; going to need some time to adjust. If we rip out the build system=
<br>
&gt; &gt; somebody is using a couple of weeks before beta, that might make =
it<br>
&gt; &gt; difficult for that person to get the beta out promptly. And I thi=
nk<br>
&gt; &gt; there&#39;s probably more than just EDB who would be in that situ=
ation.<br>
&gt;<br>
&gt; Oh ... that&#39;s a good point.=C2=A0 Is there anyone besides EDB ship=
ping<br>
&gt; MSVC-built executables?=C2=A0 Would it even be practical to switch to<=
br>
&gt; meson with a month-or-so notice?=C2=A0 Seems kind of tight, and it&#39=
;s<br>
&gt; not like the packagers volunteered to make this switch.<br>
<br>
I can&#39;t really speak to those questions with confidence.<br>
<br>
Perhaps instead of telling pgsql-packagers what we&#39;re doing, we could<b=
r>
instead ask them if it would work for them if we did XYZ. Then we<br>
could use that information to inform our decision-making.</blockquote><div =
dir=3D"auto"><br></div><div dir=3D"auto">Projects other than the EDB instal=
lers use the MSVC build system - e.g. pgAdmin uses it=E2=80=99s own builds =
of libpq and other tools (psql, pg_dump etc) that are pretty heavily baked =
into a fully automated build system (even the build servers and all their r=
equirements are baked into Ansible).=C2=A0</div><div dir=3D"auto"><br></div=
><div dir=3D"auto">Changing that lot would be non-trivial, though certainly=
 possible, and I suspect we=E2=80=99re not the only ones doing that sort of=
 thing.</div><div dir=3D"auto"><br></div></div></div><span class=3D"gmail_s=
ignature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature" d=
ata-smartmail=3D"gmail_signature">-- <br>Dave Page<br><a href=3D"https://pg=
snake.blogspot.com">https://pgsnake.blogspot.com</a><br><br>EDB Postgres<br=
><a href=3D"https://www.enterprisedb.com">https://www.enterprisedb.com</a><=
/div>

--000000000000314d1505f8ffec3f--