MIME-Version: 1.0
References: <TY3PR01MB118912125614599641CA881B782522@TY3PR01MB11891.jpnprd01.prod.outlook.com>
 <CABwTF4WczBfnRcqPpF+bfGbBXnv69TtauScokDSRYUvEHSSKDw@mail.gmail.com> <CA+Tgmoa_kC1T5PR0C7K0cGo1OEPx2c4zQ13ziwqm=pz7K_367g@mail.gmail.com>
In-Reply-To: <CA+Tgmoa_kC1T5PR0C7K0cGo1OEPx2c4zQ13ziwqm=pz7K_367g@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 5 Nov 2024 15:27:03 +0000
Message-ID: <CA+OCxoywke+6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg@mail.gmail.com>
Subject: Re: doc: pgevent.dll location
To: Robert Haas <robertmhaas@gmail.com>
Cc: Gurjeet Singh <gurjeet@singh.im>, 
	"Ryohei Takahashi (Fujitsu)" <r.takahashi_2@fujitsu.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000275c8a06262c09c1"
Archived-At: <https://www.postgresql.org/message-id/CA%2BOCxoywke%2B6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg%40mail.gmail.com>
Precedence: bulk

--000000000000275c8a06262c09c1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 5 Nov 2024 at 15:10, Robert Haas <robertmhaas@gmail.com> wrote:

> On Tue, Nov 5, 2024 at 1:00=E2=80=AFAM Gurjeet Singh <gurjeet@singh.im> w=
rote:
> > I'm unable to confirm the veracity of the claim that the pgevent.dll
> > file on Windows is now placed in a different directory, and that this
> > is a result of meson builds. But the patch looks good to me; it
> > applies cleanly to REL_17_STABLE and main branches.
>
> I think we will need to find someone who can confirm whether or not
> the claim is correct.
>

It is correct. In v16, it was in lib/, in v17, bin/.

However, on Windows I think it probably makes (marginally) more sense to
include it in bin/ - we already have other libraries in there that are
linked at compile time. pgevent is something of a special case, but it's
probably more similar to those libraries than the extensions etc. that are
in lib/.

Related sidenote: I got a complaint today that pg_regress.exe is no longer
part of the Windows installation footprint - and indeed, it's not installed
at all with Meson builds, which is problematic for those doing CI/CD
testing of extensions.

--=20
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org

--000000000000275c8a06262c09c1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, 5 Nov 2024 at 15:10, Robert H=
aas &lt;<a href=3D"mailto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>&=
gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-colo=
r:rgb(204,204,204);padding-left:1ex">On Tue, Nov 5, 2024 at 1:00=E2=80=AFAM=
 Gurjeet Singh &lt;<a href=3D"mailto:gurjeet@singh.im" target=3D"_blank">gu=
rjeet@singh.im</a>&gt; wrote:<br>
&gt; I&#39;m unable to confirm the veracity of the claim that the pgevent.d=
ll<br>
&gt; file on Windows is now placed in a different directory, and that this<=
br>
&gt; is a result of meson builds. But the patch looks good to me; it<br>
&gt; applies cleanly to REL_17_STABLE and main branches.<br>
<br>
I think we will need to find someone who can confirm whether or not<br>
the claim is correct.<br></blockquote><div><br></div><div>It is correct. In=
 v16, it was in lib/, in v17, bin/.</div><div><br></div><div>However, on Wi=
ndows I think it probably makes (marginally) more sense to include it in bi=
n/ - we already have other libraries in there that are linked at compile ti=
me. pgevent is something of a special case, but it&#39;s probably more simi=
lar to those libraries than the extensions etc. that are in lib/.</div><div=
><br></div><div>Related sidenote: I got a complaint=C2=A0today that pg_regr=
ess.exe is no longer part of the Windows installation footprint - and indee=
d, it&#39;s not installed at all with Meson builds, which is problematic fo=
r those doing CI/CD testing of extensions.</div><div>=C2=A0</div></div><spa=
n class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"=
gmail_signature"><div dir=3D"ltr">Dave Page<div>pgAdmin: <a href=3D"https:/=
/www.pgadmin.org" target=3D"_blank">https://www.pgadmin.org</a></div><div>P=
ostgreSQL: <a href=3D"https://www.postgresql.org" target=3D"_blank">https:/=
/www.postgresql.org</a><div></div><div><br></div></div></div></div></div>

--000000000000275c8a06262c09c1--