MIME-Version: 1.0
References: <CAHut+Pt52ueOEAO-G5qeZiiPv1p9pBT_W5Vj3BTYfC8sD8LFxw@mail.gmail.com>
In-Reply-To: <CAHut+Pt52ueOEAO-G5qeZiiPv1p9pBT_W5Vj3BTYfC8sD8LFxw@mail.gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Wed, 5 Apr 2023 08:59:12 -0400
Message-ID: <CA+TgmoY4=Te5m4SrrPEZQYk+CZUjGLda-O4bEeSHksMBp8-LRA@mail.gmail.com>
Subject: Re: Comment typo in recent push
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoY4%3DTe5m4SrrPEZQYk%2BCZUjGLda-O4bEeSHksMBp8-LRA%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 4, 2023 at 8:29=E2=80=AFPM Peter Smith <smithpb2250@gmail.com> =
wrote:
> There seems to be a comment typo in the recent commit "Perform logical
> replication actions as the table owner" [1].
>
> /*
>  * Switch back to the original user ID.
>  *
>  * If we created a new GUC nest level, also role back any changes that we=
re
>  * made within it.
>  */
>
>
> /role back/rollback/
>
> ~~
>
> PSA a tiny patch to fix that.

Good catch, but I think it should be roll back (a verb) not rollback (a nou=
n).

--=20
Robert Haas
EDB: http://www.enterprisedb.com