MIME-Version: 1.0
References: <TY3PR01MB118912125614599641CA881B782522@TY3PR01MB11891.jpnprd01.prod.outlook.com>
 <CABwTF4WczBfnRcqPpF+bfGbBXnv69TtauScokDSRYUvEHSSKDw@mail.gmail.com>
 <CA+Tgmoa_kC1T5PR0C7K0cGo1OEPx2c4zQ13ziwqm=pz7K_367g@mail.gmail.com>
 <CA+OCxoywke+6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg@mail.gmail.com>
 <TY3PR01MB118914759E215A415D418B42B82532@TY3PR01MB11891.jpnprd01.prod.outlook.com>
 <c03e069d-7220-453d-9c5d-9fcc74518be0@eisentraut.org> <CA+TgmoZ+yTDsL7-u62O1F=YXag8WXqBNDdxy22kfJq_avyKEtg@mail.gmail.com>
 <130a8a66-c5eb-49d4-bba9-8ff473c4a0c2@eisentraut.org>
In-Reply-To: <130a8a66-c5eb-49d4-bba9-8ff473c4a0c2@eisentraut.org>
From: Robert Haas <robertmhaas@gmail.com>
Date: Tue, 12 Nov 2024 12:27:37 -0500
Message-ID: <CA+TgmoY9f+rapcAGHMeFvXhG6S9j9rmRvxsTiMCk5g=dFXuTdw@mail.gmail.com>
Subject: Re: doc: pgevent.dll location
To: Peter Eisentraut <peter@eisentraut.org>
Cc: "Ryohei Takahashi (Fujitsu)" <r.takahashi_2@fujitsu.com>, Dave Page <dpage@pgadmin.org>, 
	Gurjeet Singh <gurjeet@singh.im>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoY9f%2BrapcAGHMeFvXhG6S9j9rmRvxsTiMCk5g%3DdFXuTdw%40mail.gmail.com>
Precedence: bulk

On Tue, Nov 12, 2024 at 11:52=E2=80=AFAM Peter Eisentraut <peter@eisentraut=
.org> wrote:
> So the most straightforward way to "make it work like it used to" would
> be to change src/bin/pgevent/meson.build to use shared_module() instead
> of shared_library().
>
> Based on the explanation in the documentation, this file is really more
> of a plugin and less a shared library, so I think that approach would be
> more correct than not.

I don't understand what the difference is between a shared module and
a shared library, so I find it odd that meson treats them differently.
However, if the consensus is that moving it back to lib is better than
updating the documentation, that's fine with me.

--=20
Robert Haas
EDB: http://www.enterprisedb.com