MIME-Version: 1.0
References: <1661334672.728714027@f473.i.mail.ru> <CAPvVvKCHJ_QthWsYM3SDc6Xr3PBTcOq0EOgD+y7dwbtFCz2buw@mail.gmail.com>
 <485cf2a2-d504-fb5f-6751-1085ccf614ec@mail.ru> <4530546a-3216-eaa9-4c92-92d33290a211@mail.ru>
 <6b48c746-9704-46dc-b9be-01fe4137c824@iki.fi>
In-Reply-To: <6b48c746-9704-46dc-b9be-01fe4137c824@iki.fi>
From: Robert Haas <robertmhaas@gmail.com>
Date: Fri, 5 Jan 2024 12:23:25 -0500
Message-ID: <CA+TgmoYQvB0fWJcD1DwBXgRnRFtSyRCepCTH4K3Pf7Bg0FJtKg@mail.gmail.com>
Subject: Re: Stack overflow issue
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Egor Chindyaskin <kyzevan23@mail.ru>, Sascha Kuhl <yogidabanli@gmail.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoYQvB0fWJcD1DwBXgRnRFtSyRCepCTH4K3Pf7Bg0FJtKg%40mail.gmail.com>
Precedence: bulk

On Fri, Nov 24, 2023 at 10:47=E2=80=AFAM Heikki Linnakangas <hlinnaka@iki.f=
i> wrote:
> What do you think?

At least for 0001 and 0002, I think we should just add the stack depth chec=
ks.

With regard to 0001, CommitTransactionCommand() and friends are hard
enough to understand as it is; they need "goto" like I need an extra
hole in my head.

With regard to 0002, this function isn't sufficiently important to
justify adding special-case code for an extremely rare event. We
should just handle it the way we do in general.

I agree that in the memory-context case it might be worth expending
some more code to be more clever. But I probably wouldn't do that for
MemoryContextStats(); check_stack_depth() seems fine for that one.

In general, I think we should try to keep the number of places that
handle stack overflow in "special" ways as small as possible.

--=20
Robert Haas
EDB: http://www.enterprisedb.com