Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wZzXZ-001SGQ-1t for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jun 2026 23:19:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wZzXX-0088Df-2J for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jun 2026 23:19:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wZzXX-0088DW-1M for pgsql-hackers@lists.postgresql.org; Wed, 17 Jun 2026 23:19:23 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wZzXU-00000000zg1-4BtT for pgsql-hackers@postgresql.org; Wed, 17 Jun 2026 23:19:23 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-c074142cf6dso54606866b.0 for ; Wed, 17 Jun 2026 16:19:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781738358; cv=none; d=google.com; s=arc-20240605; b=fW+/Ybsrm0ren9O2tN4a0ri+ss+aMgXuezCZtEwyJYBjH8lqU+3cemUwpt/Qa3vut4 Rj+uyFXu0XfCseDC62cxja4+JZ8agkz5k1Fpqwipqk1hU3sN2g3eTUQYyKL3Hu9VYq9j qrgMDoyiMK8OytBDJXtnHjNfNfLgfVX2AXWepgMl6YB+aP/frcwvimWu2+tbg+6ZRwyG rnDSqnlBFfimn5Xd9ynWIPwpOE1DMmzNcn1F+/EAfKL+zRx3cTAr1dkn0VO3jhtmSfKD R7ISSYW2AQlcrQase8oLRvfpddQ90igWpbjQRrpMHFwK/z5QLPtP3R2NymBuudiMuvBi K2Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=h1pLJ4a/AXz5qk58VfzRwtIQIM7ZfZTKwMUjIqN3000=; fh=K4e11y3H18CbQaj7QrW3R27qE7riDb8ZU58KHSxgKQA=; b=ArtYl1g48QrEIDTPFaYEVzA4AF8yVc0jI5+9HXHghwhGOR6u5tcqaJ0Ll8+wkAEkaC gV/1J2eztC9UoKy9fSMEAkS/YIqYcs7uMVjsE9LF++3Ulu71L8PxppcCGgBcHYbz2ukX bnt7XzNP7k+IXMWubXFbH78cYpFiqGivuLXpLRLioiVb2JL6uMFO7sEdYspWObr5XIug voV7+1jzAX+SlTf9xODuDtbdJP+pbuquKG53bWiBB2Qv7H5PgI4JlhNMh9UIzF7PSb9l FR80uIuQd0gtJOIXOQsSONQ7cCgymi9rTNTXHxnMad/ZasnIApRSTlfeXYF2N7tP3kze 7skQ==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781738358; x=1782343158; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h1pLJ4a/AXz5qk58VfzRwtIQIM7ZfZTKwMUjIqN3000=; b=L5UgmvmBZuHvNnMF7xcL1HiaWqstfWML/zatVcQ+KBcV23uphs7F2813k9bYJ9Gxwz rBi2HK14JILXsg1zOK2yD4MZHNNcMcJCcAb0xMel/nLOTxC5mc6YzRaCOKWIMO11BuOC 8WvQZxoD/C8xXDjetWJ3PHnIakjCDh9WR8aSJKXWZ0Zh4rdKVOS6Jj9EIfhNpf3Y+q4U otv5qkKDIcaWOkLabvkCLs3DPu29wTZIdK4nVW0p3IHVyrr7Fv8jercz5BR8sVLmaTnQ BIXXb1Dna9g4ob+WayOWd9Z6MbefvFE7IfexxxF1B1LL5LKMPoMpjs489ug0BAj5yI07 p96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781738358; x=1782343158; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h1pLJ4a/AXz5qk58VfzRwtIQIM7ZfZTKwMUjIqN3000=; b=r1vO4gz0sx+pGHTLZm+v8dKR2sCEyv01CHZ9t2t+KZbxu/mmYhZ92Zu6eUoERj1GC2 maTsIruQNAHfsdxJYD0djCFr3dVU+Rrh2ApnXL1g2F+beL98OwQetXL8l8LTDj7qGxjd tZksIyw0SvkekU60XcW+ahw09EOdWRiUA9Z1DcdmH+kKIOALTGesQsfAqLsXdkI/aMfP WX7wjkmntDAjahLk5Y8YhX1ozQ/3fvDycLea/klp/P+sP8wqX505eXbMkLVuylS2FsVl TZqL4UWadaI6XATEy3iGndP8WTkvTDZaW+hhhWFmkOu41H2IsMyxK0z7Rwc+L5JMnQ3S Qa1A== X-Forwarded-Encrypted: i=1; AFNElJ+YCqgWTNY/wngS4n6+cwxtnoAVpoeihVfh4OhvEu2mFo7oqTa5kCgBUNUr+NByHINwBgxf76FaVbteXImk@postgresql.org X-Gm-Message-State: AOJu0Yw1sUFzCG7vpJpK1b8vf+mOCRlmE0dyKN4KorPsRWbkR0P7a1wu kHd5HUbvVqS0awx/8dAYLUuVuNmDZ85AHGNpdWm357OAgbxX6u4zMyDiTCR/QV3zYEXzRFW7K6D gZqnVm0lZTBhoAHQaBJWkZZkYpTeUVPo= X-Gm-Gg: AfdE7ckuVcIkfiVt8Sop1bDxeQlVwKuOg9o4xeItRBHEf8wK17Gzm3AtKQnpf0d8Lcb b63eWBfnxm7FuQRyCwHBleBdxi4QPkYcG8tLBjqVFr7WbtayKHrvwEVVHid/s/eFVN3VVQwMCrH GeDKal6me+ImAqc1PGkd30BFbBUosujp6Ru58sj+mMuhcK76j20SWHwTe2DTTOY1RnKz/qGUsJD QWGP7hXoYSDJc7YawVIWCqKDTJqK68nM9CwDAboynIu9/TXt9d7rgfytqpycz9Lz4Kr9HlJPULy bhc7/qT0tQGPMsph2p2kqC/vPloD X-Received: by 2002:a17:906:f59a:b0:bf2:cd2b:dc47 with SMTP id a640c23a62f3a-c07339a29bcmr78123566b.21.1781738358115; Wed, 17 Jun 2026 16:19:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robert Haas Date: Wed, 17 Jun 2026 19:19:05 -0400 X-Gm-Features: AVVi8Cf96C-RzOavOYlBhuXyF85n3SoITHJlyvwcp925td4FKMdhksXIox2Hed8 Message-ID: Subject: Re: use of SPI by postgresImportForeignStatistics To: Corey Huinker Cc: Etsuro Fujita , "pgsql-hackers@postgresql.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jun 17, 2026 at 12:03=E2=80=AFPM Corey Huinker wrote: > I had assumed we wanted a generic C API to these two functions, but if we= want something that is specific to FDWs, that might change where the funct= ions land in the header files. It's an easy change to make if we change our= minds, but it would be good to know if we do or do not want something spec= ific to FDWs. Personally, I think FDWs will be 90-95% of the usages outside= of the existing SQL-defined functions, but 95% is not 100%, so I'd be incl= ined to leave them in a statistics/stats utils header. I don't want it to be specific to FDWs, just convenient for FDWs. Agree they should stay in a statistics header. --=20 Robert Haas EDB: http://www.enterprisedb.com