MIME-Version: 1.0
References: <ZLgn3Ou4YpgP8Z8l@telsasoft.com> <202402011550.sfszd46247zi@alvherre.pgsql>
In-Reply-To: <202402011550.sfszd46247zi@alvherre.pgsql>
From: Robert Haas <robertmhaas@gmail.com>
Date: Fri, 2 Feb 2024 12:04:47 -0500
Message-ID: <CA+TgmoZ-t+_Wy2vsaTwqZUSOLhqjT_S9=c5Ku0ih+uTUdUV8hg@mail.gmail.com>
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Michael Paquier <michael@paquier.xyz>, 
	Soumyadeep Chakraborty <soumyadeep2007@gmail.com>, Zhihong Yu <zyu@yugabyte.com>, 
	pgsql-hackers@postgresql.org, Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoZ-t%2B_Wy2vsaTwqZUSOLhqjT_S9%3Dc5Ku0ih%2BuTUdUV8hg%40mail.gmail.com>
Precedence: bulk

On Thu, Feb 1, 2024 at 10:51=E2=80=AFAM Alvaro Herrera <alvherre@alvh.no-ip=
.org> wrote:
> I think this works similarly but not identically to tablespace defaults,
> and the difference could be confusing.  You seem to have made it so that
> the partitioned table _always_ have a table AM, so the partitions can
> always inherit from it.  I think it would be more sensible to _allow_
> partitioned tables to have one, but not mandatory; if they don't have
> it, then a partition created from it would use default_table_access_metho=
d.

I agree that we don't want this feature to invent any new behavior. If
it's clearly and fully parallel to what we do for tablespaces, then I
think it's probably OK, but anything less than that would be a cause
for concern for me.

--=20
Robert Haas
EDB: http://www.enterprisedb.com