MIME-Version: 1.0
References: 
 <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
 <20220326162156.GI28503@telsasoft.com>
In-Reply-To: <20220326162156.GI28503@telsasoft.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Sun, 27 Mar 2022 10:13:00 -0400
Message-ID: 
 <CA+TgmoZJyx7anpGsZbOgpcP6RmyJ1-kWoKuuCYJsNohRVbOmGQ@mail.gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Georgios <gkokolatos@protonmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Rachel Heaton <rachelmheaton@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmoZJyx7anpGsZbOgpcP6RmyJ1-kWoKuuCYJsNohRVbOmGQ%40mail.gmail.com>
Precedence: bulk

On Sat, Mar 26, 2022 at 12:22 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> 0002: I wonder if you're able to re-use any of the basebackup parsing stuff
> from commit ffd53659c.  You're passing both the compression method *and* level.
> I think there should be a structure which includes both.  In the future, that
> can also handle additional options.  I hope to re-use these same things for
> wal_compression=method:level.

Yeah, we should really try to use that infrastructure instead of
inventing a bunch of different ways to do it. It might require some
renaming here and there, and I'm not sure whether we really want to
try to rush all this into the current release, but I think we should
find a way to get it done.

-- 
Robert Haas
EDB: http://www.enterprisedb.com