MIME-Version: 1.0
References: 
 <CA+TgmoZ-Jh1T6QyWoCODMVQdhTUPYkaZjWztzP1En4=ZHoKPzw@mail.gmail.com>
 <CAKZiRmxtJAFG7e1+Vs9B8ngON=AOzJbuws+1ZeH4LsbJh5AzoQ@mail.gmail.com>
 <CA+TgmoY9Ne_Sh10u6LSPc3wvOQPLp3kF9nBp3nqJEG2JGF2QiA@mail.gmail.com>
 <CA+Tgmoa57S6mP=aTOXH2-gDAL4TMO1WbGgrHSg0s6J4zUH=04g@mail.gmail.com>
 <DEB1SAGVDX7S.JMV96X4R0RCS@gmail.com>
 <CA+Tgmoaf__2B0BUL+vrg28P+3buX=Ti-kybqkHiLTtFrrCfzuA@mail.gmail.com>
 <CA+TgmoYpcLNOuypOTdgCSLW7FuA=t6BtB3meTARHX2-Dj_81xQ@mail.gmail.com>
 <DEFNP3WX7BLX.1X7DS1P9X6JIF@nmfay.com>
 <CA+TgmoZjv9OyFu1Gkt78w0vWEti8S33w8trYHmErf-GMmGSi=w@mail.gmail.com>
 <DELPC4B56Y5A.3OBZ3WCH3T4VX@nmfay.com>
 <CA+TgmoaOSBQD9Ux4eG40w723ZN=c0J7p-+oX4+J8urUeyLMo5w@mail.gmail.com>
 <CAOYmi+=g+MMoOpWkk2weXWKJcKH0eKey8gKHHdH0dF4Tiawrhw@mail.gmail.com>
 <CA+TgmobwaT=PXPDDrgDup+jA8KHBbkxigtziD-zNzAKKkQYVgQ@mail.gmail.com>
 <CAOYmi+mOmEW=amDRQMfw6-Fb3ZmDEQFaJzwk8Bc8W8DzaP85XQ@mail.gmail.com>
 <CA+TgmoaX2AMW4cdFM3OngBJxmxpkdmzF33R7-CWhvRLfucbFMg@mail.gmail.com>
 <CA+TgmoZ0x3ym_oueXRWzbM_=6ucKoPZVGj3rRMLBDC_FnetXDw@mail.gmail.com>
 <CAP53Pkycc=7N2bLzVT3x+qE1JamvRZWev5tFjdLJ1+-AV3Di+Q@mail.gmail.com>
 <CA+TgmoaKhuD91RnazbRyGkmP7--JdNq8oNDC3UcgTZSWbMxC7w@mail.gmail.com>
 <CAP53Pkw5-wMEeDJXFmqo_RTyL_spzCXb7HHKrbSnQqokVoZcNQ@mail.gmail.com>
 <CA+Tgmob-69bzbdi3U_QtebqAf6u1y8js=5=oNK639csVe1VbhA@mail.gmail.com>
 <CA+TgmoaZMOikxK=LqS+Jn+835h9S139JLGk-3LyETVXw5W5j=w@mail.gmail.com>
 <1136161.1769654478@sss.pgh.pa.us>
 <CAP53PkwZ1ZTMARKg6iEfAw9qzBhkjBitj-9gr_Jvy7k2AwGgWA@mail.gmail.com>
 <CAMbWs4--NuEUFE_xTo991TRXaZryE29jarJPDnVxoaQOYdt7tA@mail.gmail.com>
 <CA+TgmobzR+XMGbRosVPbjHbSo4+cgJn=qZK6w05aF1sbj=C+9Q@mail.gmail.com>
 <CA+TgmoawzvCoZAwFS85tE5+c8vBkqgcS8ZstQ_ohjXQ9wGT9sw@mail.gmail.com>
 <CA+TgmoYS4ZCVAF2jTce=bMP0Oq_db_srocR4cZyO0OBp9oUoGg@mail.gmail.com>
 <CAK98qZ2RzbgCHrSg4zLkvpzyBam_X6te-KF8w1+_vON9BAVMEw@mail.gmail.com>
 <CA+TgmoaCdsuvNn6T6SfQ_0YD2Hh2+hgTXh9fTGHQhPg1zvy2rQ@mail.gmail.com>
 <CA+Tgmob7ozJAs5SU6bD2RfAt4w_AmsMGz-aaVA6WeLXHkBypOg@mail.gmail.com>
 <CAK98qZ1J42RoAsHnYWGPPmHziZmzmqE=Lp_O6WJ-9aKK2qjikA@mail.gmail.com>
 <CA+TgmoYjcBA6dw3nwiyfDzPXTCrxTZPXDMrc2TrDJcL1cPK6iA@mail.gmail.com>
 <CA+TgmoYru-vxoTKfwjQby30r2OkTXfb18Km_=VLs6qk8Akr0-g@mail.gmail.com>
 <CA+Tgmoau7yJtvbeH-0kPt1Q=Gt_ezRdgM35Q1=LT665U_86Etg@mail.gmail.com>
 <1057602.1773866674@sss.pgh.pa.us>
In-Reply-To: <1057602.1773866674@sss.pgh.pa.us>
From: Robert Haas <robertmhaas@gmail.com>
Date: Wed, 18 Mar 2026 18:19:31 -0400
Message-ID: 
 <CA+TgmoZLPif34wgRunPpJYD_AFf5ob0PB+8b7rOmokiMwSqxuQ@mail.gmail.com>
Subject: Re: pg_plan_advice
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000004fbe21064d53d903"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmoZLPif34wgRunPpJYD_AFf5ob0PB%2B8b7rOmokiMwSqxuQ%40mail.gmail.com>
Precedence: bulk

--0000000000004fbe21064d53d903
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 18, 2026 at 4:44=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Don't know if you noticed yet, but avocet has shown [1] that one
> pg_plan_advice test case is unstable under debug_discard_caches =3D 1:

I had not. Thanks for the pointer.

> It looks like the appearance of "Supplied Plan Advice:" depends
> on whether the prepared query's plan got regenerated or not.
> I'm not sure if this represents a bug (ie undesirable behavior) or
> it's just that the test is being insufficiently careful about
> being reproducible.

Well, that's embarrassing: it's a copy-and-paste error. The test
prepares and executes pt1, then prepares and executes pt2, then
prepares pt3 and executes pt1, then prepares pt4 and execute p2. pt3
and pt4 are never used for anything. Also there's a related typo in a
comment. See attached.

--=20
Robert Haas
EDB: http://www.enterprisedb.com

--0000000000004fbe21064d53d903
Content-Type: application/octet-stream;
	name="v1-0001-pg_plan_advice-Fix-multiple-copy-and-paste-errors.nocfbot"
Content-Disposition: attachment;
	filename="v1-0001-pg_plan_advice-Fix-multiple-copy-and-paste-errors.nocfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mmwls28y0>
X-Attachment-Id: f_mmwls28y0

RnJvbSBhOTM0OTBhMzRjZTc4YWY5ZGVkOTE5Nzk3NDA3NmQzZDQ3MjliYjQ5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSGFhcyA8cmhhYXNAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IFdlZCwgMTggTWFyIDIwMjYgMTg6MTU6MzYgLTA0MDAKU3ViamVjdDogW1BBVENIIHYxXSBw
Z19wbGFuX2FkdmljZTogRml4IG11bHRpcGxlIGNvcHktYW5kLXBhc3RlLWVycm9ycyBpbiB0ZXN0
CiBjYXNlLgoKVGhlIHNlY29uZCBoYWxmIG9mIHRoaXMgZmlsZSBpcyBtZWFudCB0byB0ZXN0IGZl
ZWRiYWNrLCBub3QKZ2VuZXJhdGVkIGFkdmljZSwgYW5kIGlzIG1lYW50IHRvIHVzZSB0aGUgc3Rh
dGVtZW50cyB0aGF0IGl0CnByZXBhcmVzLCBub3QgbGVmdG92ZXIgcHJlcGFyZWQgc3RhdGVtZW50
cyBmcm9tIGVhcmxpZXIgaW4gdGhlCmZpbGUuCgpSZXBvcnRlZC1ieTogVG9tIExhbmUgPHRnbEBz
c3MucGdoLnBhLnVzPiAocGVyIEJGIG1lbWJlciBhdm9jZXQpCi0tLQogY29udHJpYi9wZ19wbGFu
X2FkdmljZS9leHBlY3RlZC9wcmVwYXJlZC5vdXQgfCAxNCArKysrKysrKy0tLS0tLQogY29udHJp
Yi9wZ19wbGFuX2FkdmljZS9zcWwvcHJlcGFyZWQuc3FsICAgICAgfCAgNiArKystLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9jb250cmliL3BnX3BsYW5fYWR2aWNlL2V4cGVjdGVkL3ByZXBhcmVkLm91dCBiL2NvbnRyaWIv
cGdfcGxhbl9hZHZpY2UvZXhwZWN0ZWQvcHJlcGFyZWQub3V0CmluZGV4IGZhOTFhN2QzZWZkLi5i
Y2FiMjhmMDNiZSAxMDA2NDQKLS0tIGEvY29udHJpYi9wZ19wbGFuX2FkdmljZS9leHBlY3RlZC9w
cmVwYXJlZC5vdXQKKysrIGIvY29udHJpYi9wZ19wbGFuX2FkdmljZS9leHBlY3RlZC9wcmVwYXJl
ZC5vdXQKQEAgLTQ1LDkgKzQ1LDkgQEAgU0VMRUNUICogRlJPTSBwdGFiOwogICAgU0VRX1NDQU4o
cHRhYikgLyogbWF0Y2hlZCAqLwogKDMgcm93cykKIAotLS0gUHJlcGFyZWQsIHNvIGFkdmljZSBz
aG91bGQgbm90IGJlIGdlbmVyYXRlZC4KKy0tIFByZXBhcmVkLCBzbyBmZWVkYmFjayBzaG91bGQg
bm90IGJlIGdlbmVyYXRlZC4KIFBSRVBBUkUgcHQzIEFTIFNFTEVDVCAqIEZST00gcHRhYjsKLUVY
UExBSU4gKENPU1RTIE9GRikgRVhFQ1VURSBwdDE7CitFWFBMQUlOIChDT1NUUyBPRkYpIEVYRUNV
VEUgcHQzOwogICAgIFFVRVJZIFBMQU4gICAgCiAtLS0tLS0tLS0tLS0tLS0tLS0KICBTZXEgU2Nh
biBvbiBwdGFiCkBAIC01NiwxMiArNTYsMTQgQEAgRVhQTEFJTiAoQ09TVFMgT0ZGKSBFWEVDVVRF
IHB0MTsKIFNFVCBwZ19wbGFuX2FkdmljZS5hbHdheXNfc3RvcmVfYWR2aWNlX2RldGFpbHMgPSB0
cnVlOwogLS0gUHJlcGFyZWQsIGJ1dCBhbHdheXNfc3RvcmVfYWR2aWNlX2RldGFpbHMgPSB0cnVl
LCBzbyBzaG91bGQgc2hvdyBmZWVkYmFjay4KIFBSRVBBUkUgcHQ0IEFTIFNFTEVDVCAqIEZST00g
cHRhYjsKLUVYUExBSU4gKENPU1RTIE9GRiwgUExBTl9BRFZJQ0UpIEVYRUNVVEUgcHQyOwotICAg
ICAgIFFVRVJZIFBMQU4gICAgICAgCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK0VYUExBSU4g
KENPU1RTIE9GRiwgUExBTl9BRFZJQ0UpIEVYRUNVVEUgcHQ0OworICAgICAgICAgICBRVUVSWSBQ
TEFOICAgICAgICAgICAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAgU2VxIFNj
YW4gb24gcHRhYgorIFN1cHBsaWVkIFBsYW4gQWR2aWNlOgorICAgU0VRX1NDQU4ocHRhYikgLyog
bWF0Y2hlZCAqLwogIEdlbmVyYXRlZCBQbGFuIEFkdmljZToKICAgIFNFUV9TQ0FOKHB0YWIpCiAg
ICBOT19HQVRIRVIocHRhYikKLSg0IHJvd3MpCisoNiByb3dzKQogCmRpZmYgLS1naXQgYS9jb250
cmliL3BnX3BsYW5fYWR2aWNlL3NxbC9wcmVwYXJlZC5zcWwgYi9jb250cmliL3BnX3BsYW5fYWR2
aWNlL3NxbC9wcmVwYXJlZC5zcWwKaW5kZXggNjQzZGZmMmUyN2MuLjZmZjRmMDNlNmM1IDEwMDY0
NAotLS0gYS9jb250cmliL3BnX3BsYW5fYWR2aWNlL3NxbC9wcmVwYXJlZC5zcWwKKysrIGIvY29u
dHJpYi9wZ19wbGFuX2FkdmljZS9zcWwvcHJlcGFyZWQuc3FsCkBAIC0yNSwxMiArMjUsMTIgQEAg
U0VUIHBnX3BsYW5fYWR2aWNlLmFkdmljZSA9ICdTRVFfU0NBTihwdGFiKSc7CiBFWFBMQUlOIChD
T1NUUyBPRkYpCiBTRUxFQ1QgKiBGUk9NIHB0YWI7CiAKLS0tIFByZXBhcmVkLCBzbyBhZHZpY2Ug
c2hvdWxkIG5vdCBiZSBnZW5lcmF0ZWQuCistLSBQcmVwYXJlZCwgc28gZmVlZGJhY2sgc2hvdWxk
IG5vdCBiZSBnZW5lcmF0ZWQuCiBQUkVQQVJFIHB0MyBBUyBTRUxFQ1QgKiBGUk9NIHB0YWI7Ci1F
WFBMQUlOIChDT1NUUyBPRkYpIEVYRUNVVEUgcHQxOworRVhQTEFJTiAoQ09TVFMgT0ZGKSBFWEVD
VVRFIHB0MzsKIAogU0VUIHBnX3BsYW5fYWR2aWNlLmFsd2F5c19zdG9yZV9hZHZpY2VfZGV0YWls
cyA9IHRydWU7CiAKIC0tIFByZXBhcmVkLCBidXQgYWx3YXlzX3N0b3JlX2FkdmljZV9kZXRhaWxz
ID0gdHJ1ZSwgc28gc2hvdWxkIHNob3cgZmVlZGJhY2suCiBQUkVQQVJFIHB0NCBBUyBTRUxFQ1Qg
KiBGUk9NIHB0YWI7Ci1FWFBMQUlOIChDT1NUUyBPRkYsIFBMQU5fQURWSUNFKSBFWEVDVVRFIHB0
MjsKK0VYUExBSU4gKENPU1RTIE9GRiwgUExBTl9BRFZJQ0UpIEVYRUNVVEUgcHQ0OwotLSAKMi41
MS4wCgo=
--0000000000004fbe21064d53d903--