MIME-Version: 1.0
References: <CANbhV-E4pTWeF-DsdaGsOrjJNFWPaR+Dstjrnkqvf9JFFgOKKQ@mail.gmail.com>
 <f781f8f198567cee9e3776487bab3e41a7b91b82.camel@j-davis.com>
 <20220512034010.4oqa76pasrulkw32@alap3.anarazel.de> <CANbhV-G7SfdRLR6r7sxY0uL=TRU0S=cxkWJGWyTdss3u8LFK=g@mail.gmail.com>
 <20220512234207.pwwp6q33f72byet2@alap3.anarazel.de> <CANbhV-FFgAFeNZ=qNc7Fr991Asym+sfj=R5hb02XeRE6067=hg@mail.gmail.com>
 <CABm2Ma7v4=W-1vH=kiA4M352F=Nd-Nvd_QBZufJ6EMGsS7Q-_A@mail.gmail.com>
 <0892cd00635c8bcd458de6d43d31cf61953da1b2.camel@j-davis.com>
 <CABm2Ma5Hi9PU_wWP0f=YFu9aDDdeSdX2+JFDL_oDH-QHgexsgg@mail.gmail.com>
 <727b0f3b48aec2a4f968bf11c6fa8ca6382b6cca.camel@j-davis.com>
 <CABm2Ma6avU5hkk7dd+G2oRNJZJtLOT=Yzeq6fb0v2rf7_YYp7g@mail.gmail.com>
 <beb9c43d6492ffc273d236e4b93270dfad035f2f.camel@j-davis.com>
 <CABm2Ma5Ww9M8DgFTCcASnMiPPVYU8cd_wGhHZ5YnoK5im6wT2g@mail.gmail.com>
 <22e756affaad88b77a52d67cb532ed2a544f2e36.camel@j-davis.com>
 <CA+TgmoZxvVXx809WhOcLNbUgAYYiLY+Y-o_gDpay6uTLwaJVyA@mail.gmail.com> <1e2256b744836aeb485c61954e9d8272f80141a0.camel@j-davis.com>
In-Reply-To: <1e2256b744836aeb485c61954e9d8272f80141a0.camel@j-davis.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Fri, 17 May 2024 16:25:15 -0400
Message-ID: <CA+TgmoZS++BBdyWxFv6k-UhzX=MGsqd8mu_80Z646-T=jYgW2g@mail.gmail.com>
Subject: Re: Comments on Custom RMGRs
To: Jeff Davis <pgsql@j-davis.com>
Cc: Danil Anisimow <anisimow.d@gmail.com>, Andres Freund <andres@anarazel.de>, 
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoZS%2B%2BBBdyWxFv6k-UhzX%3DMGsqd8mu_80Z646-T%3DjYgW2g%40mail.gmail.com>
Precedence: bulk

On Fri, May 17, 2024 at 4:20=E2=80=AFPM Jeff Davis <pgsql@j-davis.com> wrot=
e:
> Regarding this particular change: the checkpointing hook seems more
> like a table AM feature, so I agree with you that we should have a good
> idea how a real table AM might use this, rather than only
> pg_stat_statements.

I would even be OK with a pg_stat_statements example that is fully
working and fully explained. I just don't want to have no example at
all. The original proposal has been changed twice because of
complaints that the hook wasn't quite useful enough, but I think that
only proves that v3 is closer to being useful than v1. If v1 is 40% of
the way to useful and v3 is 120% of the way to useful, wonderful! But
if v1 is 20% of the way to being useful and v3 is 60% of the way to
being useful, it's not time to commit anything yet. I don't know which
is the case, and I think if someone wants this to be committed, they
need to explain clearly why it's the first and not the second.

--=20
Robert Haas
EDB: http://www.enterprisedb.com