MIME-Version: 1.0
References: <CA+TgmobE6rRs-tMArr733y9VucgNA5Nd9_qYgEVWjJDwHBwP-Q@mail.gmail.com>
 <3907196.1675957889@sss.pgh.pa.us> <CA+TgmoY6xxDdZ1YJjMb27Ei7qgFcbu=__WtDX_cOd3GQ5uvxWw@mail.gmail.com>
 <20230209192952.jvx56yuutlxuvjjf@awork3.anarazel.de> <CA+TgmobQ5iWVCoPokW1jBrRb3V_x0PUXD05vvgS3FqQecvXHMw@mail.gmail.com>
 <20230216163254.nktnbbb2b7wlpzwy@awork3.anarazel.de> <CA+TgmoamQWK3JYkYtf7GPuzh9en2bDPTzw9c3BF+cHZDt0y7AQ@mail.gmail.com>
 <20230218211522.grbzg75vzjtqafzf@awork3.anarazel.de> <CA+TgmoaLCxrdHPSnRLD1j1FQQx4k7QSJq-ybVOYj2aEF34sQLQ@mail.gmail.com>
 <20230225190031.e3vesk22q5wpmmhc@awork3.anarazel.de> <20230301042919.GC1453450@nathanxps13>
In-Reply-To: <20230301042919.GC1453450@nathanxps13>
From: Robert Haas <robertmhaas@gmail.com>
Date: Wed, 1 Mar 2023 12:44:51 -0500
Message-ID: <CA+TgmoZSW1VK8kHHuLWDTf2dZjL6qzzk1RSYx4WoYnkbprPqTQ@mail.gmail.com>
Subject: Re: Weird failure with latches in curculio on v15
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Michael Paquier <michael@paquier.xyz>, Thomas Munro <thomas.munro@gmail.com>, 
	Fujii Masao <fujii@postgresql.org>, 
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoZSW1VK8kHHuLWDTf2dZjL6qzzk1RSYx4WoYnkbprPqTQ%40mail.gmail.com>
Precedence: bulk

On Tue, Feb 28, 2023 at 11:29=E2=80=AFPM Nathan Bossart
<nathandbossart@gmail.com> wrote:
> On Sat, Feb 25, 2023 at 11:00:31AM -0800, Andres Freund wrote:
> > TBH, I think the current archive and restore module APIs aren't useful.=
 I
> > think it was a mistake to add archive modules without having demonstrat=
ed that
> > one can do something useful with them that the restore_command didn't a=
lready
> > do. If anything, archive modules have made it harder to improve archivi=
ng
> > performance via concurrency.
>
> I must respectfully disagree that this work is useless.  Besides the
> performance and security benefits of not shelling out for every WAL file,
> I've found it very useful to be able to use the standard module framework
> to develop archive modules.  It's relatively easy to make use of GUCs,
> background workers, compression, etc.  Of course, there is room for
> improvement in areas like concurrency support as you rightly point out, b=
ut
> I don't think that makes the current state worthless.

I also disagree with Andres. The status quo ante was that we did not
provide any way of doing archiving correctly even to a directory on
the local machine. We could only recommend silly things like 'cp' that
are incorrect in multiple ways. basic_archive isn't the most wonderful
thing ever, and its deficiencies are more obvious to me now than they
were when I committed it. But it's better than recommending a shell
command that doesn't even work.

--=20
Robert Haas
EDB: http://www.enterprisedb.com