public inbox for [email protected]
help / color / mirror / Atom feedFrom: Robert Haas <[email protected]>
To: Tender Wang <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Lukas Fittl <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: heikki.linnakangas <[email protected]>
Subject: Re: pg_plan_advice
Date: Wed, 15 Apr 2026 15:46:58 -0400
Message-ID: <CA+TgmoZWK_nN9Z+Ac2+GvfhfGJGgeFAvqJWsmin_N04CWYYhXQ@mail.gmail.com> (raw)
In-Reply-To: <CAHewXNnzQJ0DofXtM3d8Ztym9ZLQ4m6MV8EezkGBG3=txS_qmw@mail.gmail.com>
References: <CA+TgmoYuWmN-00Ec5pY7zAcpSFQUQLbgAdVWGR9kOR-HM-fHrA@mail.gmail.com>
<CAP53Pkzn_wZ-R-cPdD9XSQ9+myPUUsPMMqVBPNG3XWXhgfm1-Q@mail.gmail.com>
<CA+Tgmobxbju8PrY_NULtPr7b7UShp4+Jqibm2Bou8TVS69gObQ@mail.gmail.com>
<[email protected]>
<CA+Tgmoad!kuOMJjvYe2h6aznHFeePprGEQ8CgUpRK=47sB6DMAg@mail.gmail.com>
<[email protected]>
<CA+TgmoY+g1u-fN=3igXG-8u0Ho3V4u-ooWXCj-FQ9DA=uGek9g@mail.gmail.com>
<[email protected]>
<CA+TgmobOOmmXSJz3e+cjTY-bA1+W0dqVDqzxUBEvGtW62whYGg@mail.gmail.com>
<[email protected]>
<adZq3Rlxq3v916aG@nathan>
<CAAKRu_Yaarv2+SJ8qoNfMG4FCLve6KrewX_KFe1vRzk2+4d9bg@mail.gmail.com>
<CA+TgmoaEk5nBCHCWa8epb1Fff4BwroLkdYLfqisKk49qdHGVYw@mail.gmail.com>
<[email protected]>
<CAHewXNnzQJ0DofXtM3d8Ztym9ZLQ4m6MV8EezkGBG3=txS_qmw@mail.gmail.com>
On Wed, Apr 15, 2026 at 6:30 AM Tender Wang <[email protected]> wrote:
> In the plan_showdown phase, in pgpa_qf_add_plan_rtis(), we can add 7,
> 5, and 3 to qf->relids.
> It seems difficult to add "6" to qf->relids when walking through the
> plan tree.(Maybe have an easy way, I don't know too much
> pg_plan_advice related code).
Thanks for looking through this. sj_unique_rtis is actually not set
from the plan tree walk, but based on the calls to
pgpa_join_path_setup that occur during planning, so it makes sense
that the join RTI crept in there. I'm guessing that this is another
place that needs a call to pgpa_filter_out_join_relids -- I've had a
few of those bugs already.
--
Robert Haas
EDB: http://www.enterprisedb.com
view thread (184+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_plan_advice
In-Reply-To: <CA+TgmoZWK_nN9Z+Ac2+GvfhfGJGgeFAvqJWsmin_N04CWYYhXQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox