public inbox for [email protected]
help / color / mirror / Atom feedFrom: Robert Haas <[email protected]>
To: Amul Sul <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Jakub Wartak <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
Date: Sat, 7 Feb 2026 08:04:32 -0500
Message-ID: <CA+TgmoZtUFDefYG5FPB8wUQn4BDwh1aQGmE-duQghPM2M+iJbA@mail.gmail.com> (raw)
In-Reply-To: <CAAJ_b95evCRK2DSWFcTF6rpo3ku-qS=rCwUcNyFjY_4muc3suw@mail.gmail.com>
References: <CAAJ_b94bqdWN3h2J-PzzzQ2Npbwct5ZQHggn_QoYGhC2rn-=WQ@mail.gmail.com>
<CAAJ_b97PQjE4kFD8Qk6UvtLrfPMixw1nxBz0OP5Z2WB2B-uMxQ@mail.gmail.com>
<CAAJ_b97JA8ehy_UDddrnGwDt9HG5NmJq8ATtmeMqo7YD-=tLyQ@mail.gmail.com>
<CA+TgmoZjhWDG_AR1i+L1yss-wbuWvxrdRwSdVUUUnVPrJV2CnQ@mail.gmail.com>
<CAAJ_b94Uh+b41LQG45bZFK+i62EVvv972LiGWWWuR64=-64rTQ@mail.gmail.com>
<CA+TgmobF5c7ZcZHdEhqwNxGDZzWG2bDtpRaDtoVELWX_VHs_1A@mail.gmail.com>
<CAAJ_b94gK1np8d1h-2c1YoCccGXr4zspTa-FC7X_bfXZNz=-DA@mail.gmail.com>
<CA+TgmoayDY5b+bP1vRRN7A3xOP-=+tK13B2C1g-Xm1j4WTrT9Q@mail.gmail.com>
<CAAJ_b97JAF+Zuoh2FBO79hVwLeaBPwsbXw-fY+313a7LfRQ-Bg@mail.gmail.com>
<CA+Tgmoardk4VuthHc23vov+AVkhq7eT0mFUs-2ctAnP1uiTaog@mail.gmail.com>
<CAAJ_b959x5VjmLJFmN78r_QohQuuj=fde11VbbAOHn5TzgEzng@mail.gmail.com>
<CAAJ_b97_N+0sipFyq80n0jX-nKcjcQEMOSTVg8DsqkHR8dW_Sw@mail.gmail.com>
<CAKZiRmyDk5KqovS9Ez3iFHd+p-TChSt2QTtWkwJ5Ya-+4gg21g@mail.gmail.com>
<CAAJ_b956a+e8-HNEpeJ60ByFv7XJRqECPu3B0dozv0ChMRTPbQ@mail.gmail.com>
<CAAJ_b94f6sUDWiZY90O-t7SWWeSK0nMWT7AsydKkpAL90m0oMQ@mail.gmail.com>
<[email protected]>
<CAAJ_b94SEcBVJcsp0Y1-YvLqZWBHPQH4FhRzSJfaH_ah_eL_FQ@mail.gmail.com>
<CAAJ_b97nn9denP2SAjuXyjwbd3is-VnZVSkiRMJ-5YNiKfO9MA@mail.gmail.com>
<CA+Tgmob_DB9QHDOxnP7a5Y0yJdeGqY8YNi+uK_811y7cN4mxYA@mail.gmail.com>
<CAAJ_b97VUiP-DbLNe-ddq64J_RiB4ZcPgAjHkJH-0dbzgjR++A@mail.gmail.com>
<CA+TgmoYMtcZBaqy9r59eDapaDy3WOdepkFFURu9MV-x-kxEbKg@mail.gmail.com>
<CAAJ_b95FOeW38gw-3BLmpdnTWHFimopTvf=eTObYUbTOC0x8qg@mail.gmail.com>
<CA+Tgmob=3POOO8st-v-fCjKCKREQ=+gs5_PBQnoFeNBdERfuEg@mail.gmail.com>
<CAAJ_b94=gtCeUKkGPUmPj_2SwHV+PiXQ8Mx-1RqfYj3pP3OwpA@mail.gmail.com>
<[email protected]>
<CAAJ_b95evCRK2DSWFcTF6rpo3ku-qS=rCwUcNyFjY_4muc3suw@mail.gmail.com>
On Wed, Feb 4, 2026 at 8:53 AM Amul Sul <[email protected]> wrote:
> > 0008. I'm concerned about this patch. It is breaking backward compatibility if
> > you are using a long option (--wal-directory). Your proposal is a generic word
> > that represents both cases (file and directory). I agree. However, I wouldn't
> > remove --wal-directory from the tool. Instead, I would keep it with the same
> > short option ('w') but add a sentence saying this long option is deprecated and
> > will be removed in the future or even remove any traces of this long option
> > from the help and documentation but silently accept the old long option. I
> > prefer the latter because it is not a required argument so a deprecation
> > warning is not necessary IMO.
>
> Yeah, that was discussed with Robert offline and we believe that it is
> better to make it more generalized; since we can now use the same
> option to accept both wal-directory and wal-archived. pg_waldump has
> much more generic options for the same, such as -- path=PATH.
Of course, the fact that we discussed it doesn't mean that the issue
is completely settled. However, I don't think there would be general
support from other people on the project for the idea of getting rid
of the long option entirely, or even just the documentation for it. We
have long options for almost all short options these days, and I agree
with that as a general practice. Sometimes we have ONLY a long option,
but we very rarely have ONLY a short option, which is good because
sometimes we have tools with too many options for it to be viable to
give everything a short option, and the long options really help to
make things more self-documenting.
What I would consider a more viable option is to not do the rename and
leave this as --wal-directory even though the argument could really be
a directory or a file. That would avoid the backward compatibility
break that is troubling Euler. And, you could argue that a tar file is
enough like a directory that it won't really cause much confusion.
Personally, I favor renaming it. I think the number of people using
pg_waldump is fairly small, and the number of those people who are
using the long form of the option is very small. Hence, I don't
believe think the rename will inconvenience many users, and I think it
will improve clarity for future users. But, Euler (or someone else)
might take the opposite viewpoint.
--
Robert Haas
EDB: http://www.enterprisedb.com
view thread (8+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
In-Reply-To: <CA+TgmoZtUFDefYG5FPB8wUQn4BDwh1aQGmE-duQghPM2M+iJbA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox