public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Andres Freund <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Michael Harris <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: FileFallocate misbehaving on XFS
Date: Mon, 16 Dec 2024 18:23:45 -0500
Message-ID: <CA+TgmoZv7G57yRhHH4cdRPBnqkOrg6T-FZgExtwz263MpVRZHA@mail.gmail.com> (raw)
In-Reply-To: <coyrqea4ty53rknmxn4jjmok6f7vrvvia6s4stt6ys5l6fch4s@6tnxdtybqia3>
References: <CA+Tgmoa2fQihhhtvOD7BnTofmDa8OkDccFHB0i5NeyP-MZCs0A@mail.gmail.com>
	<[email protected]>
	<coyrqea4ty53rknmxn4jjmok6f7vrvvia6s4stt6ys5l6fch4s@6tnxdtybqia3>

On Mon, Dec 16, 2024 at 12:52 PM Andres Freund <[email protected]> wrote:
> I don't see what we gain by requiring guesswork (what does allocating vs
> zeroing mean, zeroing also allocates disk space after all) to interpret the
> main error message. My experience is that it's often harder to get the DETAIL
> than the actual error message (grepping becomes harder due to separate line,
> terse verbosity is commonly used).

I feel like the normal way that we do this is basically:

could not {name of system call} file "\%s\": %m

e.g.

could not read file \"%s\": %m

I don't know why we should do anything else in this type of case.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: FileFallocate misbehaving on XFS
  In-Reply-To: <CA+TgmoZv7G57yRhHH4cdRPBnqkOrg6T-FZgExtwz263MpVRZHA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox