MIME-Version: 1.0
References: <xjjx7r4xa7beixuu4qtkdhnwdbchrrpo3gaeb3jsbinvvdiat5@cwjw55mna5of> <1682220.1732638956@sss.pgh.pa.us>
In-Reply-To: <1682220.1732638956@sss.pgh.pa.us>
From: Robert Haas <robertmhaas@gmail.com>
Date: Tue, 26 Nov 2024 13:09:16 -0500
Message-ID: <CA+TgmoZzYhZSetBc6eY=AqVo0a28FUkzmggbVZ2j0Tju_nB+Sw@mail.gmail.com>
Subject: Re: Misleading "epoll_create1 failed: Too many open files"
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoZzYhZSetBc6eY%3DAqVo0a28FUkzmggbVZ2j0Tju_nB%2BSw%40mail.gmail.com>
Precedence: bulk

On Tue, Nov 26, 2024 at 11:36=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote=
:
> I think the idea was that this mechanism is equivalent to an EMFILE
> limit.  But if you feel a need to make a distinction, this seems fine:

I think we should never, ever confuse an error return from a system
call with any other kind of problem that can happen. Not even write()
returns 0 =3D> ENOSPC.

AFAIK, the rationale for conflating failure cases like this is that
either both failures are unlikely or, at least, the case where errno
wasn't actually set is unlikely. But the problem is that when
something weird happens, that's exactly when you need a clear and
unambiguous error report. I've had multiple extremely painful support
experiences that were made painful precisely because I couldn't
determine exactly what really happened. Did a system call really
return an unlikely error code? Or was it the
not-a-real-error-code-but-we-faked-one case which is also not supposed
to happen?

I find this kind of thing maddening every time it happens, and it
happens to me more often than you might think, because it often
happens that other people are able to answer the normal questions and
they send me the weird ones. Let's say twice a year I spend a couple
of days sweating blood trying to determine the root cause of some
bizarre malfunction because the person who wrote the code couldn't be
bothered to take 2 minutes to make the errors distinguishable.

--=20
Robert Haas
EDB: http://www.enterprisedb.com