MIME-Version: 1.0
References: <DHCYFNC0WIF4.3T1M8AUK0DG7T@gmail.com>
 <CA+Tgmob-0W8306mvrJX5Urtqt1AAasu8pi4yLrZ1XfwZU-Uj1w@mail.gmail.com>
 <CA+TgmoYUdeCdGfk8H6Ni2obXVixLvYaDkRGtxKLEmaCVNffsVA@mail.gmail.com>
 <DHHB7U2PSFYG.1A0WVPTX5LNOD@gmail.com>
 <CA+TgmoacOujCREMtQwURTSokB+ks-eLgaQ5vBMdWG959XzFcrA@mail.gmail.com>
 <CAP53PkwsnhmoLXJaUMKWc76S21GzYOX06qKyZdVZhGGW0rCWKw@mail.gmail.com>
In-Reply-To: 
 <CAP53PkwsnhmoLXJaUMKWc76S21GzYOX06qKyZdVZhGGW0rCWKw@mail.gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Mon, 6 Apr 2026 15:30:49 -0400
Message-ID: 
 <CA+TgmoaGDHbys0UUzn8hPe9XQJK+HhjsWtqAxpvYJCs6MS1_6g@mail.gmail.com>
Subject: Re: Add custom EXPLAIN options support to auto_explain
To: Lukas Fittl <lukas@fittl.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>,
 pgsql-hackers@lists.postgresql.org,
	Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmoaGDHbys0UUzn8hPe9XQJK%2BHhjsWtqAxpvYJCs6MS1_6g%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 3, 2026 at 10:09=E2=80=AFPM Lukas Fittl <lukas@fittl.com> wrote=
:
> Per src/backend/utils/misc/README, "extra is initialized to NULL
> before call, so it can be ignored if not needed." - so we don't have
> to set extra here.

Fair enough, but it's not an uncommon practice. See, e.g.
check_synchronous_standby_names(), check_backtrace_functions().

> You note in a separate comment that we're using a subset of the main
> parser, but maybe its worth calling out integer values in particular,
> since things like "100_000" are not supported (since we're not using
> pg_strtoint64_safe + deal with the complexity of that in the scanning
> logic). I think this could be a code comment for now.

OK, done.

> I think this function probably has the most complexity due to its
> hand-rolled parsing, so it might be good if someone else takes another
> close look at it.

Agreed, but I've committed this for now. If someone finds a problem
later, it can be revised or reverted.

--=20
Robert Haas
EDB: http://www.enterprisedb.com