Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCKYL-001sZc-2o for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Apr 2026 16:54:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wCKYK-007zEA-0R for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Apr 2026 16:54:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCKYJ-007zDx-2k for pgsql-hackers@lists.postgresql.org; Mon, 13 Apr 2026 16:54:24 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wCKYI-00000000pUY-2uYe for pgsql-hackers@postgresql.org; Mon, 13 Apr 2026 16:54:23 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-b79f8f7ea43so865989766b.2 for ; Mon, 13 Apr 2026 09:54:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776099262; cv=none; d=google.com; s=arc-20240605; b=Q2p2zmPaAz7VxnXDnE3ZBudWlqBbBajv+uSj/qbhGUVfJHz++7nG2osL2y9D92dbuD OB+ivJ311zDCGGrOUxdNcWPkgq58sLXRuw7Kong2KjiSIVYUHOXJDZ/Lrud0lAvHpSJJ BpXncvKiDXHpT00S/ha0Cp9CzV+gPXnhoOJV6GovqpvBHZCWCEodaUtY4Gx8ydG5rSPM Ic5IIgy6P/2eZT5HgORw1XICs5VvQyus+6X0IjQn5yvimYEKc+F+uDl4vjGWU9UeKrXh 4Pzl/6btIRwCL/DCrofEb01OZNYSFqKWqQR5rb5XYGDkuSaY/V7M/OA7WodpZnvt8tM0 3Kaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=QJAOtco6K3hXvs/A5b041I1MsLrBoSDGr1Y5mitgDhw=; fh=Sq9/O3usMLefP8JP8SRdSAW/N7aiRpXpsvI5kpnwvh4=; b=DQKq6Di9mWOXHh57VBBFZLmlXgxUwmACS5J44DHXsB1WRWHWwfAWmrpgGTDqfGKXJb ZS72Io98jb70Xbq40zHegQC6FiCOUrDA1r4wSF2xWuZE0gLw8xpWW1OqTvh20z0Bkb8G EH29AZDUzBcg7B6HhcNw7Tinfm/2yCREunVkD9I1xkPES6iTX1j2eHZkJlfxFSa/XLJ6 xeTbk3y6eb91kCkcOuoHj3zOPy9rTOa6kV3M6CXRmZJG1KBX8voKP+Rc1BXN5J67QQPm LeaTHuAChVvBHWR6XzAHGv+QkC2N23WIBfIu8vRrjl/UlxaOIOfGcTpcY3ixXHXgfbHb B8hQ==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776099262; x=1776704062; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QJAOtco6K3hXvs/A5b041I1MsLrBoSDGr1Y5mitgDhw=; b=lck7piTrCx3tfCdf41dqBRevRGMIySxyzdjRMMKGer734NlIvWYSo88FdpWwlgbHbn +PdMz5IqnwXX7qG9tgY4aIkNglUAhGmHdte1TJWgQfiPkJG+ukizl50tLV9Qg9U0UwMG uy2AwFjwy9aR5PO/1Kb56LKKN6yT68ykefPhC4/zVQbgGyiVxrYIneNzFnnZF6BNMOuh c5Ohh3cjhmBiUMLz4YwRlLzZ8YQchnx+rPcQf4wi48wlLyjEF8XDHRZG48Qkann3wicz fnFjKnKPXceaoUa2ZY3D4RsUF0ORQ9y19dXpEUSzkNkUZs9T9Cwfz68BNuuTOUHElAWW 8M+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776099262; x=1776704062; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QJAOtco6K3hXvs/A5b041I1MsLrBoSDGr1Y5mitgDhw=; b=qLLEofsGyLaGUP8E82iodf6kVC+VdmVhxjedEfAiICgeZ+mP7CBHFSQS9n4vyqr7uf uVDG7nM8EBcLPnnHtGU/k/rHCMsV0iyx98ToB10zyTAcInlA80c9uSdENbP2wH5LHU0S sSFlcgaj59wvvSSxbsVtXlVDbAKp2Z5aHekY5i+R19Xxic13+B7+pvgdFe0KButEXmy7 UnFBu2EmFFmlDCKUxsh3d8jEqMKFIOh1e/2vGVS+U1i1NEKh5//PToj4GpueaOv7oLAU SXJG31qgIhR7qESlTYqDYxi799tlw4QOwjYGKz3uZCrOZIojvqES/dEilX702ZzelOEa Uzfw== X-Gm-Message-State: AOJu0YzIXWk/6OKl/x2ealP0BwlQHXKb8jQFhwDFCyri0QLLQE3YsvA4 BEauUaFcCOZ5WR7EZATWfCtq9dTQm2sroDsvyX5mPU7T1/UwUEmP7foTomSA/SMWvEiRqYPnsjq Hj9bvSq+fgNzM+L3BFg9JdFbRgPqRjM4= X-Gm-Gg: AeBDiev5C+ID9RabL6Q2M67ihTuFaqyxevMf0Wl1bPrsUdzxAFQSiab1dh/JoHZDQ3D V/iHZEVvNZ8zu+T4MVaq0j6anEML3zzdW/xN/9MwPgw5/I54hXkm9E6Iw0k43YE0G++WL2Wo+xH nnrwQl1Pm2HNocNV/Z+o6ZwT9vsQyH0VchuSHvTdWj3kWLbBiEsAW8K1gn9RsjzLFiVEvAk0D+q U1nqxFxGOCj1WLhjpmDEHjw3gQ8hGHdfLB56WidGT2D3ypKC2aFR42lC9NVgc/zNSS1Ryk4GYB5 6BLMYnlf0w+cxNxEnL9rC9UFVn7gAX7PezKcyhgA01MY+GipCA== X-Received: by 2002:a17:907:c312:b0:b94:1224:c61e with SMTP id a640c23a62f3a-b9d72792e67mr724164866b.14.1776099261386; Mon, 13 Apr 2026 09:54:21 -0700 (PDT) MIME-Version: 1.0 References: <8912b2e5-ccad-4cbd-ab53-869b0b9ecec5@xs4all.nl> In-Reply-To: From: Robert Haas Date: Mon, 13 Apr 2026 12:54:08 -0400 X-Gm-Features: AQROBzDVk6qvNJL_eVImfvU9S7sgG0NLdv8aKhlQdyFQtOCL0jnBTqXEO6EAP-E Message-ID: Subject: Re: pg_stash_advice doc To: Erik Rijkers Cc: PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Apr 10, 2026 at 11:57=E2=80=AFAM Robert Haas wrote: > On Fri, Apr 10, 2026 at 5:18=E2=80=AFAM Erik Rijkers wrote= : > > "This means both that it is important to be mindful > > of memory consumption when deciding how much plan advice to stash." > > > > It seems to me 'both' should be 'also', or maybe just dropped. > > Oops. That sentence had a second part in the first pg_stash_advice > commit, and the second commit remove the second part of the sentence > without remembering to delete the word "both". I have committed a fix. Thanks again for the report. --=20 Robert Haas EDB: http://www.enterprisedb.com