MIME-Version: 1.0
References: <CAMT0RQR1TNSnSWwd65is=HCDjiP4i25mcDDoctEBEiV8351cMQ@mail.gmail.com>
 <20230814150737.GA1395427@nathanxps13> <d01513e9-8c19-da5-fabc-845f75377f52@mines-paristech.fr>
 <20230815153423.GB2296544@nathanxps13>
In-Reply-To: <20230815153423.GB2296544@nathanxps13>
From: Robert Haas <robertmhaas@gmail.com>
Date: Fri, 2 Feb 2024 15:44:12 -0500
Message-ID: <CA+TgmoaO+ZddJg=rSPra8ufpbufoZVKc-juW=9VDLd7Mam2RvQ@mail.gmail.com>
Subject: Re: pgbench - adding pl/pgsql versions of tests
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Hannu Krosing <hannuk@google.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>, Dimitri Fontaine <dim@tapoueh.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoaO%2BZddJg%3DrSPra8ufpbufoZVKc-juW%3D9VDLd7Mam2RvQ%40mail.gmail.com>
Precedence: bulk

On Tue, Aug 15, 2023 at 11:41=E2=80=AFAM Nathan Bossart
<nathandbossart@gmail.com> wrote:
> Why's that?  I'm not aware of any project policy that prohibits such
> enhancements to pgbench.  It might take some effort to gather consensus o=
n
> a proposal like this, but IMHO that doesn't mean we shouldn't try.  If th=
e
> prevailing wisdom is that we shouldn't add more built-in scripts because
> there is an existing way to provide custom ones, then it's not clear that
> we should proceed with $SUBJECT, anyway.

I don't think there's a policy against adding more built-in scripts to
pgbench, but I'm skeptical of such efforts because I don't see how to
decide which ones are worthy of inclusion and which are not. Adding
everyone's favorite thing will be too cluttered, and adding nothing
forecloses nothing because people can always provide their own. If we
could establish that certain custom scripts are widely used across
many people, then those might be worth adding.

I have a vague recollection of someone proposing something similar to
this in the past, possibly Jeff Davis. If there is in fact a paper
trail showing that the same thing has been proposed more than once by
unrelated people, that would be a point in favor of adding that
particular thing.

--=20
Robert Haas
EDB: http://www.enterprisedb.com