public inbox for [email protected]
help / color / mirror / Atom feedFrom: Robert Haas <[email protected]>
To: Nazir Bilal Yavuz <[email protected]>
Cc: Aidar Imamov <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Subject: Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions
Date: Fri, 11 Apr 2025 07:43:38 -0400
Message-ID: <CA+TgmoaS3Jfaacg5UuPZHPfKOjwBsTyjWfhUG1DSokHH8-nqDQ@mail.gmail.com> (raw)
In-Reply-To: <CAN55FZ2Hi4uAeCcNAE1EH7DzxA0qwqt64SMJanwM0UKSqG6dCA@mail.gmail.com>
References: <CAN55FZ0h_YoSqqutxV6DES1RW8ig6wcA8CR9rJk358YRMxZFmw@mail.gmail.com>
<bbxepmv3w2iapbxehkypzsut545valywzf62qlizsrzkbrdnfy@dzw5ju3itwgs>
<CAN55FZ1Pq_80vcuHZK6dSuTfG-5jBoK0Bd2k1YUSpKT+7hOj6A@mail.gmail.com>
<CAN55FZ2mNTVK81jqsy2NXg9k_ex_LrdU6JmL1wvsW9-GPy9XuA@mail.gmail.com>
<[email protected]>
<CA+Tgmoa-epr=JDyD4rJYc+CCtP6bZPamJuXxtOe2PBt0EXQ9VA@mail.gmail.com>
<CAN55FZ2Hi4uAeCcNAE1EH7DzxA0qwqt64SMJanwM0UKSqG6dCA@mail.gmail.com>
On Fri, Apr 11, 2025 at 4:02 AM Nazir Bilal Yavuz <[email protected]> wrote:
> I understand your point. I did it like that because bufferids start
> from 1 and go to NBuffers inclusive in the pg_buffercache view, so it
> seems more natural to me to implement it like that. I am okay to
> replace these loops with [1] to make it standart everywhere:
>
> [1]
> for (int buf = 0; buf < NBuffers; buf++)
> {
> BufferDesc *desc = GetBufferDescriptor(buf);
I'm more making an observation than asking for a change. If you and
others think it should be changed, that is fine, but I'm uncertain
myself what we ought to be doing here. I just wanted to raise the
issue.
--
Robert Haas
EDB: http://www.enterprisedb.com
view thread (17+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add pg_buffercache_evict_all() and pg_buffercache_mark_dirty[_all]() functions
In-Reply-To: <CA+TgmoaS3Jfaacg5UuPZHPfKOjwBsTyjWfhUG1DSokHH8-nqDQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox