public inbox for [email protected]
help / color / mirror / Atom feedFrom: Robert Haas <[email protected]>
To: Thomas Munro <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Marcel Hofstetter <[email protected]>
Subject: Re: margay fails assertion in stats/dsa/dsm code
Date: Fri, 1 Jul 2022 09:14:51 -0400
Message-ID: <CA+TgmoaZDuUWK4MOb-8-hFFr+=oP9rqTE+bJOLynTxrXtTkQjA@mail.gmail.com> (raw)
In-Reply-To: <CA+hUKGKbpjPUXTWUCK77w9CSg-CBMJZYH8aMBOO5e7jJ+1ef=w@mail.gmail.com>
References: <CA+hUKGKqKrCV5xKWfh9rnm=o=DwZLTLtnsj_XpUi9g5=V+9oyg@mail.gmail.com>
<CA+TgmoYGNgRwN=pVK70GC=CtU8sUXwNC1admiH2H4iUjEC=F3g@mail.gmail.com>
<CA+hUKGL+DNK5d5ARgFuN4kntZrur68E+DWbcm3iyF_NjTZ4DBQ@mail.gmail.com>
<CA+TgmobJ4bSLqxQmtc+8nEAZuwRtMNUdqaTX0ZEKPXi7XwF-fg@mail.gmail.com>
<CA+hUKGKbpjPUXTWUCK77w9CSg-CBMJZYH8aMBOO5e7jJ+1ef=w@mail.gmail.com>
On Thu, Jun 30, 2022 at 10:34 PM Thomas Munro <[email protected]> wrote:
> So... I think we should select a different default
> dynamic_shared_memory_type in initdb.c if defined(__sun__). Which is
> the least terrible? For sysv, it looks like all the relevant sysctls
> that used to be required to use sysv memory became obsolete/automatic
> in Sol 10 (note: Sol 9 is long EOL'd), so it should just work AFAICT,
> whereas for mmap mode your shared memory data is likely to cause file
> I/O because we put the temporary files in your data directory. I'm
> thinking perhaps we should default to dynamic_shared_memory_type=sysv
> for 15+. I don't really want to change it in the back branches, since
> nobody has actually complained about "posix" performance and it might
> upset someone if we change it for newly initdb'd DBs in a major
> release series. But I'm not an expert or even user of this OS, I'm
> just trying to fix the build farm; better ideas welcome.
Boy, relying on DSM for critical stuff sure is a lot of fun! This is
exactly why I hate adding new facilities that have to be implemented
in OS-dependent ways.
Changing the default on certain platforms to 'posix' or 'sysv'
according to what works best on that platform seems reasonable to me.
I agree that defaulting to 'mmap' doesn't seem like a lot of fun,
although I think it could be a reasonable choice on a platform where
everything else is broken. You could alternatively try to fix 'posix'
by adding some kind of code to work around that platform's
deficiencies. Insert handwaving here.
--
Robert Haas
EDB: http://www.enterprisedb.com
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: margay fails assertion in stats/dsa/dsm code
In-Reply-To: <CA+TgmoaZDuUWK4MOb-8-hFFr+=oP9rqTE+bJOLynTxrXtTkQjA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox