MIME-Version: 1.0
References: <CAKz==bJBCWrvN77fmuZ2XqD3jazWEb=E80AA4Yv9C9tQ61YDdQ@mail.gmail.com>
 <170509767861.1131.15083983626399995184.pgcf@coridan.postgresql.org>
 <CAKz==bLJAwDGMMRqJSwA0Y+h10OYff73cd1pNCyzGnwYLq74BA@mail.gmail.com>
 <17c31b30041187a577eb5b45090a58c5fae6418c.camel@crunchydata.com>
 <2c9d3664ff7adc506191f92db031543925abe0df.camel@crunchydata.com> <CABV9wwPc9Afa_mULh-tRLufnUru3HtRhg8AhVRnqySk6sN6GUg@mail.gmail.com>
In-Reply-To: <CABV9wwPc9Afa_mULh-tRLufnUru3HtRhg8AhVRnqySk6sN6GUg@mail.gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Fri, 22 Mar 2024 13:57:53 -0400
Message-ID: <CA+Tgmoadh8PJdnVrGf31O589V6cDRO0YkdHwg_+Z95orLt8OHQ@mail.gmail.com>
Subject: Re: [DOC] Add detail regarding resource consumption wrt max_connections
To: Robert Treat <rob@xzilla.net>
Cc: reid.thompson@crunchydata.com, Roberto Mello <roberto.mello@gmail.com>, 
	Cary Huang <cary.huang@highgo.ca>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmoadh8PJdnVrGf31O589V6cDRO0YkdHwg_%2BZ95orLt8OHQ%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 8, 2024 at 9:52=E2=80=AFAM Robert Treat <rob@xzilla.net> wrote:
> I'm of the opinion that advice suggestingDBA's set things to DEBUG 3
> is unfriendly at best. If you really want to add more, there is an
> existing unfriendly section of the docs at
> https://www.postgresql.org/docs/devel/kernel-resources.html#LINUX-MEMORY-=
OVERCOMMIT
> that mentions this problem, specifically:
>
> "If PostgreSQL itself is the cause of the system running out of
> memory, you can avoid the problem by changing your configuration. In
> some cases, it may help to lower memory-related configuration
> parameters, particularly shared_buffers, work_mem, and
> hash_mem_multiplier. In other cases, the problem may be caused by
> allowing too many connections to the database server itself. In many
> cases, it may be better to reduce max_connections and instead make use
> of external connection-pooling software."
>
> I couldn't really find a spot to add in your additional info, but
> maybe you can find a spot that fits? Or maybe a well written
> walk-through of this would make for a good wiki page in case people
> really want to dig in.
>
> In any case, I think Roberto's original language is an improvement
> over what we have now, so I'd probably recommend just going with that,
> along with a similar note to max_prepared_xacts, and optionally a
> pointer to the shared mem section of the docs.

I agree with this.

I don't agree with Cary's statement that if you increase
max_connections you should increase shared_buffers as well. That seems
situation-dependent to me, and it's also missing Roberto's point,
which is that JUST increasing max_connections without doing anything
else uses more shared memory.

Similarly, I don't think we need to document a detailed testing
procedure, as proposed by Reid. If users want to know exactly how many
additional resources are used, they can test; either using the DEBUG3
approach, or perhaps more simply via the pg_shmem_allocations view.
But I think it's overkill for us to recommend any specific testing
procedure here.

Rather, I think that it's entirely appropriate to do what Roberto
suggested, which is to say, let users know that they're going to use
some extra resources if they increase the setting, and then let them
figure out what if anything they want to do about that.

--=20
Robert Haas
EDB: http://www.enterprisedb.com