Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAxyq-0004yn-LF for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Jul 2022 18:18:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oAxyp-0000mJ-Ej for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Jul 2022 18:17:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAxyp-0000mA-5w for pgsql-hackers@lists.postgresql.org; Mon, 11 Jul 2022 18:17:59 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oAxym-0008Vf-M4 for pgsql-hackers@postgresql.org; Mon, 11 Jul 2022 18:17:58 +0000 Received: by mail-ej1-x634.google.com with SMTP id h23so10175457ejj.12 for ; Mon, 11 Jul 2022 11:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DFdgBSiGtysUgI6Q8dZyPRNCm97p2JWa/HpCFoi8OK8=; b=TVGEOVgAIG5Uk6zfR1e37US6fqjOGgwZ/DPzn+b2s0dY7yjyz1C2QOXTRBVHW5ss1I FFpJSAD/bmPL9XmVkMbAZ6mFTgd1cI3gsEKnHHrVFxK33UhlGlkqQlYZ2y89oLLrhoHg +lm04SoZaI+xCABhx9nRuC+/rboRad3g05KcGJJP5GlSVwZ3lkxVGsWhfKCuwUQNM3JU ge0RMA65ohvdKkfMYoA691tTMm9V2xuftERJQv0gCnWXKtrHhT4W43WaSlU+vAu3JwBy bDFS6h44IQNH15f3RwGXr0VWXahXdjVoE3jODjf1T7tRai2pE8bO8u7q+nt5RuNfuDEF LPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DFdgBSiGtysUgI6Q8dZyPRNCm97p2JWa/HpCFoi8OK8=; b=Zgwx10HP/RMBGDHGL+VU7zyulcJEEkC2qtukR9yW8EGMA7K+xwL1of9o4JEwVsenQz Mv7Vq/QdxTkXqtqlEc7m0tMvYWd2Wa+DK3X9Vbkqz990NJLzFMj4tYV/0wA/JuTMIgpF SbLg5+A0MRPoLxTklMlDgdJ6NBkz4Cu1BRRkNWXt4E/ENJZ5OBc0ox0cujYKF/rBhHks fX1515t0ZVaxUtppIPGO1wjd5IE6u6ZxtjLOl50s5xcYvaiSkwsXrTW86g2QZPuzoFuC kI86uZpbruFefU+wbhX+8nMKkL/ElHL1kjYZjD8sot1l0RJHCg5IVeke4lmasLtsmYaV gk0g== X-Gm-Message-State: AJIora/TmO/03NFGZdW5Xsg5k3CRSCd6Bvyl7V590zZpBomZn8jwtxsT 3OBfNmVirs8WL/NXsZfJRlnaa5qkGZqGDTpyCV4= X-Google-Smtp-Source: AGRyM1vOFtUNPUjSo1CgLaK2HHJxABwX+MC7gdYytxYy+FGuCZMerttnOU1tyo8Jakt9KNtFwsioCgCFlGJ0yFNV0Q8= X-Received: by 2002:a17:907:2704:b0:72a:596f:8b9f with SMTP id w4-20020a170907270400b0072a596f8b9fmr19274472ejk.761.1657563476092; Mon, 11 Jul 2022 11:17:56 -0700 (PDT) MIME-Version: 1.0 References: <1294462.1656875649@sss.pgh.pa.us> <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com> <1593978.1656953960@sss.pgh.pa.us> <2592455.1657140387@sss.pgh.pa.us> <3302658.1657288366@sss.pgh.pa.us> <3488143.1657310625@sss.pgh.pa.us> <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com> <20220710214622.haiektrjzisob6rl@awork3.anarazel.de> <815831.1657494597@sss.pgh.pa.us> <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com> <1116889.1657553859@sss.pgh.pa.us> <1201553.1657562258@sss.pgh.pa.us> In-Reply-To: <1201553.1657562258@sss.pgh.pa.us> From: Robert Haas Date: Mon, 11 Jul 2022 14:17:44 -0400 Message-ID: Subject: Re: automatically generating node support functions To: Tom Lane Cc: Peter Eisentraut , Andres Freund , David Rowley , pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jul 11, 2022 at 1:57 PM Tom Lane wrote: > More generally, I'm having second thoughts about the wisdom of > auto-generating the NodeTag enum at all. With the current setup, > I am absolutely petrified about the risk of silent ABI breakage > thanks to the enum order changing. In particular, if the meson > build fails to use the same input-file order as the makefile build, > then we will get different enum orders from the two builds, causing > an ABI discrepancy that nobody would notice until we had catastrophic > extension-compatibility issues in the field. I think this is a valid concern, but having it be automatically generated is awfully handy, so I think it would be nice to find some way of preserving that. -- Robert Haas EDB: http://www.enterprisedb.com