Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAZyN-007Frl-UA for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Dec 2023 18:16:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rAZyM-005AAd-JW for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Dec 2023 18:16:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAZyM-005AAU-A8 for pgsql-hackers@lists.postgresql.org; Tue, 05 Dec 2023 18:16:42 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rAZyF-00AGA0-37 for pgsql-hackers@postgresql.org; Tue, 05 Dec 2023 18:16:41 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a1ceae92ab6so82080566b.0 for ; Tue, 05 Dec 2023 10:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701800194; x=1702404994; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ymLi/nAqP5mRvzzENGJH2F6FUTYlWc+pdvoX+is3MbY=; b=G2ov8j1rCQhfL7Lw3ky1blGA6jObW6b8BjQMt5YgZ6FZhJX3vfEarxGpkWO0QETvBe H28idLFlPQhBR9+22sMI1V13ZNYmvhKyHeyNbfkiMCjBRW19czWbUOJYVfVIamyDfCi/ ZSIyob4fl+l5cNKTTUltQczwY+tr+vQZ8TSzxcLC02UGJqBYTuPK2eLQV3rgmUn/pd/b dQUx69ijRZtUQaqTaVZ3iOuYAnJ2dRF7SIsEppzvVAkehA9wauJ1+FFtIO7jLKof/33F LOQBLG+DcTEW7hWStPc17g+079zD2RTqs21U/88zM0hENQeyQm9TvVs71gqmX8vwOPSt grcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701800194; x=1702404994; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ymLi/nAqP5mRvzzENGJH2F6FUTYlWc+pdvoX+is3MbY=; b=ZQzKTmvduIQ259nzOv4Tl8HmDJie0qzOebzaDogx73D9mVNdvYyU9h8gMxxQPWDf8D SLjarV0UlkbtuYpreSnmyoW1be8O+DywP1HIdmIgf8ckr6gTXn0Fj7uS8Cnoy92Y4WUh 1OS+GkZSAfDUp1paVeKJr3mGb9paS0fznVY2DFjh1B871P6V0piml/4kCtbFlnq4vlOC rbWOoADTRfrgGIbeDeNVqlvJ232bl+uaEO3dsjZ2kH2Z17CnZ0nb7cZxan4Y2oDsTwBz +/bY8jXhVn/FJYTmmPqWEjUZCXRzn9WPaG11OM5/8ZhiHCtA53PmZ2crugbv346IB5LI YImA== X-Gm-Message-State: AOJu0YwKw97dMLAZlGARr39gCDi03/92+8K+T2GB8ttJp5VQYbJqQCpp OBRKbAh7pYHS56fsXD/2Gy/G7a+exkEkpZBXJVw= X-Google-Smtp-Source: AGHT+IHVDrOcBqGQSToD/VgXQc3iPwelfGrA4wgdTH1YykOu3N17vnv7sgJv2WkIrz1kFrMEXJyBVzl0P6Bd3BUeEHI= X-Received: by 2002:a17:906:3550:b0:a19:a1ba:da70 with SMTP id s16-20020a170906355000b00a19a1bada70mr4846720eja.151.1701800193911; Tue, 05 Dec 2023 10:16:33 -0800 (PST) MIME-Version: 1.0 References: <20231205174034.GA2757816@nathanxps13> In-Reply-To: <20231205174034.GA2757816@nathanxps13> From: Robert Haas Date: Tue, 5 Dec 2023 13:16:22 -0500 Message-ID: Subject: Re: backtrace_on_internal_error To: Nathan Bossart Cc: Peter Eisentraut , pgsql-hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Dec 5, 2023 at 12:40=E2=80=AFPM Nathan Bossart wrote: > On Tue, Dec 05, 2023 at 11:55:05AM +0100, Peter Eisentraut wrote: > > Would others find this useful? > > Yes. I think I would use this pretty frequently. I think we should consider unconditionally emitting a backtrace when an elog() is hit, instead of requiring a GUC. Or at least any elog() that's not at a DEBUGn level. If the extra output annoys anybody, that means they're regularly hitting an elog(), and it ought to be promoted to ereport(). --=20 Robert Haas EDB: http://www.enterprisedb.com