MIME-Version: 1.0
References: 
 <CA+TgmoZ-Jh1T6QyWoCODMVQdhTUPYkaZjWztzP1En4=ZHoKPzw@mail.gmail.com>
 <CA+TgmoaCdsuvNn6T6SfQ_0YD2Hh2+hgTXh9fTGHQhPg1zvy2rQ@mail.gmail.com>
 <CAK98qZ1zWzRB0ABG7ULzTeWKRR5C7-FxLqM-6v8wQDiFM+DNAg@mail.gmail.com>
 <CA+Tgmob7ozJAs5SU6bD2RfAt4w_AmsMGz-aaVA6WeLXHkBypOg@mail.gmail.com>
 <CAK98qZ1J42RoAsHnYWGPPmHziZmzmqE=Lp_O6WJ-9aKK2qjikA@mail.gmail.com>
 <CA+TgmoYjcBA6dw3nwiyfDzPXTCrxTZPXDMrc2TrDJcL1cPK6iA@mail.gmail.com>
 <CA+TgmoYru-vxoTKfwjQby30r2OkTXfb18Km_=VLs6qk8Akr0-g@mail.gmail.com>
 <CAKFQuwYxTMx1e1dvVLd5vs8CO2Xe__YRCW0m4v2UErG=5Lu7kQ@mail.gmail.com>
 <CA+TgmoaPH3rOmH1zw8s10Az3TQKRbDnF3dKYZCAFvx_DgFV5_Q@mail.gmail.com>
 <CAKFQuwZ7CRbvmJ60EjvEUJP8X9hWVCHJz8yJZ0-xRpYwL=fugA@mail.gmail.com>
 <CA+TgmoYsG2pAOG4YYWwnGsaL+QfOZopi_m+f_hZqBZ3meNEkjg@mail.gmail.com>
 <CAKFQuwY4i6xXCRHd=ccrFz0sQOfiWRxhobiBrzyK0rzu1-Y33Q@mail.gmail.com>
 <CA+Tgmobbj_TaCsYmr1grJBTRKaFaxFfotXn1T6LSXs9GQ8_Kyw@mail.gmail.com>
 <CA+TgmoZzM2i+p-Rxdphs4qx7sshn-kzxF91ASQ5duOo0dFRXLQ@mail.gmail.com>
 <a6e6d603-e847-44dc-acd5-879fb4570062@gmail.com>
In-Reply-To: <a6e6d603-e847-44dc-acd5-879fb4570062@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Mon, 16 Mar 2026 13:11:16 -0400
Message-ID: 
 <CA+Tgmob4vZCh2aixNamh7p3JwAY+r-vuP1tTv-KcUH00XguicA@mail.gmail.com>
Subject: Re: pg_plan_advice
To: Alexander Lakhin <exclusion@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003fa86c064d274fcc"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmob4vZCh2aixNamh7p3JwAY%2Br-vuP1tTv-KcUH00XguicA%40mail.gmail.com>
Precedence: bulk

--0000000000003fa86c064d274fcc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 14, 2026 at 8:00=E2=80=AFAM Alexander Lakhin <exclusion@gmail.c=
om> wrote:
> I've found a crash inside pgpa_join_path_setup(), reproduced with:
> echo "geqo_threshold =3D 2" >/tmp/extra.config
> TEMP_CONFIG=3D/tmp/extra.config make -s check -C contrib/pg_plan_advice/
> ...
>
> Could please look at this?

Thanks. Proposed fix attached.

--=20
Robert Haas
EDB: http://www.enterprisedb.com

--0000000000003fa86c064d274fcc
Content-Type: application/octet-stream;
	name="0001-pg_plan_advice-Avoid-a-crash-under-GEQO.nocfbot"
Content-Disposition: attachment;
	filename="0001-pg_plan_advice-Avoid-a-crash-under-GEQO.nocfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mmtfwyfq0>
X-Attachment-Id: f_mmtfwyfq0

RnJvbSA3OThkNmRmM2VmYmVkNWRmYjZjNzg0YWFlYWY5OTgyZGIxMTNkNDg3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSGFhcyA8cmhhYXNAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IE1vbiwgMTYgTWFyIDIwMjYgMTE6NTA6MDAgLTA0MDAKU3ViamVjdDogW1BBVENIIDEvNF0g
cGdfcGxhbl9hZHZpY2U6IEF2b2lkIGEgY3Jhc2ggdW5kZXIgR0VRTy4KClRoZSBwcmV2aW91cyBj
b2RlIGNvdWxkIGFsbG9jYXRlIHBncGFfc2pfdW5pcXVlX3JlbCBvYmplY3RzIGluIGEgY29udGV4
dAp0aGF0IGhhZCB0b28gc2hvcnQgYSBsaWZlc3Bhbi4gRml4IGJ5IGFsbG9jYXRpbmcgdGhlbSAo
YW5kIGFueQphc3NvY2lhdGVkIExpc3QtcmVsYXRlZCBhbGxvY2F0aW9ucykgaW4gdGhlIHNhbWUg
Y29udGV4dCBhcyB0aGUKcGdwYV9wbGFubmVyX3N0YXRlIHRvIHdoaWNoIHRoZXkgYXJlIGF0dGFj
aGVkLgoKUmVwb3J0ZWQtYnk6IEFsZXhhbmRlciBMYWtoaW4gPGV4Y2x1c2lvbkBnbWFpbC5jb20+
CkRpc2N1c3Npb246IGh0dHA6Ly9wb3N0Z3IuZXMvbS9hNmU2ZDYwMy1lODQ3LTQ0ZGMtYWNkNS04
NzlmYjQ1NzAwNjJAZ21haWwuY29tCi0tLQogY29udHJpYi9wZ19wbGFuX2FkdmljZS9wZ3BhX3Bs
YW5uZXIuYyB8IDE1ICsrKysrKysrKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlv
bnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9jb250cmliL3BnX3BsYW5fYWR2aWNl
L3BncGFfcGxhbm5lci5jIGIvY29udHJpYi9wZ19wbGFuX2FkdmljZS9wZ3BhX3BsYW5uZXIuYwpp
bmRleCA1NTA4YjhhZjcwNy4uMDhlNmVjMTk5YjkgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcGdfcGxh
bl9hZHZpY2UvcGdwYV9wbGFubmVyLmMKKysrIGIvY29udHJpYi9wZ19wbGFuX2FkdmljZS9wZ3Bh
X3BsYW5uZXIuYwpAQCAtOTAsNiArOTAsNyBAQCB0eXBlZGVmIGVudW0gcGdwYV9qb19vdXRjb21l
CiAKIHR5cGVkZWYgc3RydWN0IHBncGFfcGxhbm5lcl9zdGF0ZQogeworCU1lbW9yeUNvbnRleHQJ
bWN4dDsKIAlib29sCQlnZW5lcmF0ZV9hZHZpY2VfZmVlZGJhY2s7CiAJYm9vbAkJZ2VuZXJhdGVf
YWR2aWNlX3N0cmluZzsKIAlwZ3BhX3Ryb3ZlICp0cm92ZTsKQEAgLTMyNCwxMCArMzI1LDE4IEBA
IHBncGFfcGxhbm5lcl9zZXR1cChQbGFubmVyR2xvYmFsICpnbG9iLCBRdWVyeSAqcGFyc2UsIGNv
bnN0IGNoYXIgKnF1ZXJ5X3N0cmluZywKIAkgKiBzb21lIHB1cnBvc2UuIFRoYXQgY291bGQgYmUg
KDEpIHJlY29yZGluZyB0aGF0IHdlIHdpbGwgbmVlZCB0byBnZW5lcmF0ZQogCSAqIGFuIGFkdmlj
ZSBzdHJpbmcsICgyKSBzdG9yaW5nIGEgdHJvdmUgb2Ygc3VwcGxpZWQgYWR2aWNlLCBvciAoMykK
IAkgKiBmYWNpbGl0YXRpbmcgZGVidWdnaW5nIGNyb3NzLWNoZWNrcyB3aGVuIGFzc2VydHMgYXJl
IGVuYWJsZWQuCisJICoKKwkgKiBDdXJyZW50bHksIHRoZSBhY3RpdmUgbWVtb3J5IGNvbnRleHQg
c2hvdWxkIGJlIG9uZSB0aGF0IHdpbGwgbGFzdCBmb3IKKwkgKiB0aGUgZW50aXJlIGR1cmF0aW9u
IG9mIHF1ZXJ5IHBsYW5uaW5nLCBidXQgaWYgR0VRTyBpcyBpbiB1c2UsIGl0J3MKKwkgKiBwb3Nz
aWJsZSB0aGF0IHNvbWUgb2Ygb3VyIGNhbGxiYWNrcyBtYXkgYmUgaW52b2tlZCBsYXRlciB3aXRo
CisJICogQ3VycmVudE1lbW9yeUNvbnRleHQgc2V0IHRvIHNvbWUgc2hvcnRlci1saXZlZCBjb250
ZXh0LiBTbywgcmVjb3JkCisJICogdGhlIGNvbnRleHQgdGhhdCBzaG91bGQgYmUgdXNlZCBmb3Ig
YWxsb2NhdGlvbnMgdGhhdCBuZWVkIHRvIGxpdmUKKwkgKiBhcyBsb25nIGFzIHRoZSBwZ3BhX3Bs
YW5uZXJfc3RhdGUgaXRzZWxmLgogCSAqLwogCWlmIChuZWVkc19wcHMpCiAJewogCQlwcHMgPSBw
YWxsb2MwX29iamVjdChwZ3BhX3BsYW5uZXJfc3RhdGUpOworCQlwcHMtPm1jeHQgPSBDdXJyZW50
TWVtb3J5Q29udGV4dDsKIAkJcHBzLT5nZW5lcmF0ZV9hZHZpY2VfZmVlZGJhY2sgPSBnZW5lcmF0
ZV9hZHZpY2VfZmVlZGJhY2s7CiAJCXBwcy0+Z2VuZXJhdGVfYWR2aWNlX3N0cmluZyA9IGdlbmVy
YXRlX2FkdmljZV9zdHJpbmc7CiAJCXBwcy0+dHJvdmUgPSB0cm92ZTsKQEAgLTYxNiwxMSArNjI1
LDE1IEBAIHBncGFfam9pbl9wYXRoX3NldHVwKFBsYW5uZXJJbmZvICpyb290LCBSZWxPcHRJbmZv
ICpqb2lucmVsLAogCQkJLyogSWYgbm90IGEgZHVwbGljYXRlLCBhcHBlbmQgdG8gdGhlIGxpc3Qu
ICovCiAJCQlpZiAoIWZvdW5kKQogCQkJewotCQkJCXBncGFfc2pfdW5pcXVlX3JlbCAqdXIgPSBw
YWxsb2Nfb2JqZWN0KHBncGFfc2pfdW5pcXVlX3JlbCk7CisJCQkJcGdwYV9zal91bmlxdWVfcmVs
ICp1cjsKKwkJCQlNZW1vcnlDb250ZXh0CW9sZGNvbnRleHQ7CiAKKwkJCQlvbGRjb250ZXh0ID0g
TWVtb3J5Q29udGV4dFN3aXRjaFRvKHBwcy0+bWN4dCk7CisJCQkJdXIgPSBwYWxsb2Nfb2JqZWN0
KHBncGFfc2pfdW5pcXVlX3JlbCk7CiAJCQkJdXItPnBsYW5fbmFtZSA9IHJvb3QtPnBsYW5fbmFt
ZTsKIAkJCQl1ci0+cmVsaWRzID0gdW5pcXVlcmVsLT5yZWxpZHM7CiAJCQkJcHBzLT5zal91bmlx
dWVfcmVscyA9IGxhcHBlbmQocHBzLT5zal91bmlxdWVfcmVscywgdXIpOworCQkJCU1lbW9yeUNv
bnRleHRTd2l0Y2hUbyhvbGRjb250ZXh0KTsKIAkJCX0KIAkJfQogCX0KLS0gCjIuNTEuMAoK
--0000000000003fa86c064d274fcc--