Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXM5O-003V5l-4P for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jul 2024 14:38:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sXM5M-00Cv6U-MA for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jul 2024 14:38:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sXM5M-00Cv6M-CL for pgsql-hackers@lists.postgresql.org; Fri, 26 Jul 2024 14:38:20 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sXM5J-001ZI1-NN for pgsql-hackers@lists.postgresql.org; Fri, 26 Jul 2024 14:38:19 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a7ab76558a9so295981266b.1 for ; Fri, 26 Jul 2024 07:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722004696; x=1722609496; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c18tqhfAneqdDFShV44ZynEHU0gYEFV3f+H/3RP1jAY=; b=EAUodGiI06yNw0DNfrcuJkIehXbeEA3+K7TElUqw797oEibWBIXmrJ1nPl5+hrAxPk qbA8PQALJ8QgkJYj67DoHPMK1yqUAJ0Q5Z0sqV15bWnCB1Xv95Sgi8OigJbat/vM1nCV z6fCu4ULdj5rblVYBdsfXbxdQxk5RUTKD6qxKHNh9d7bUXkeiZPMehtPRhqrtHPZD4Hq 3UuUvcAuMoTnJ3G7JZrNL3lLnq5JbiNmgU9IUXh+99QYWb4tGH4wpVjnyYs08KPuAGCx 8sNWjZbPzX/1Ff0u/jaHtR2CopieXw0rk0ted3XlbVFjWNRaLfixLf1UskhavHK5t+XG zd5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722004696; x=1722609496; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c18tqhfAneqdDFShV44ZynEHU0gYEFV3f+H/3RP1jAY=; b=S6Os+1qNm4uJJ99heIqiWZ6SMKCSzQN18URxK3k7JX2aM4eX7CkmiQLmrxQYy2fVKA DHgf7jK/H3slrMZ2X+JPgyJPNkyK0mOJJzk6xDFtJd2NXlSa1s1XfPfJnlUdsh2gmIib JUP2muhaD0ZVC4olz34JD5lWmu8sRiGMt3CRvk53X+sIwr9pjamqehuJSTOtYVSyuPVS Ehs+iovzfjAbtPhs15t8NT96pcyhoMfsdVO4VT+9oE/b5AWkbIKzLZzqHFCn1+T8Ckby VcCnccrf9RkJM7Cokl+nUam6+h9X2KkfcNzcER0lMnnUmayXjN//dEUZmSqLv7WGtt7g 8Ceg== X-Forwarded-Encrypted: i=1; AJvYcCVPrcJcpLhR4gn7g20oWYJqn7Sa0xkNx37cJcnwN1JOSgih41IgVYSHS3ECEWG7JP6msSro882ekskJlRDSRaifIs0qQM6GDTjS9a7l01cpJxCu X-Gm-Message-State: AOJu0YxNF5+wo5RHuq0Zg9A872h0NvKEWxqDoYFSMek+4OLxkHChws5K ZBbnAZfVOEAnRg9D903iva+uiSH8BQJfADMVc4fkSU1VI/q7q9Q4U/uOMKHeXyDmG1RPnUPKI6R +NiNEu9iukwx0HB1xubFkFOvbFPs= X-Google-Smtp-Source: AGHT+IGCM1/5fa2oqhTT67W/5Uwp40BoQuowos+7q0JJXnlXjRAvWkSzl5Ca+Fjyn/GFdW7NUmlGPhBHDn7fKcY47K4= X-Received: by 2002:a17:907:3e21:b0:a7a:1c7b:dc17 with SMTP id a640c23a62f3a-a7ab2feb3a1mr903762466b.22.1722004695609; Fri, 26 Jul 2024 07:38:15 -0700 (PDT) MIME-Version: 1.0 References: <20220922151328.lakwdytvwnyyif3b@awork3.anarazel.de> <8c74cc5e-4b97-4cd7-9aaf-67886822a78c@eisentraut.org> <20240501022412.85@rfd.leadboat.com> <1375614.1715301775@sss.pgh.pa.us> <8635D8B1-45B7-4D67-86C7-D6ECB4F10B11@enterprisedb.com> In-Reply-To: From: Robert Haas Date: Fri, 26 Jul 2024 10:38:03 -0400 Message-ID: Subject: Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. To: Alexander Korotkov Cc: Mark Dilger , Pavel Borisov , Tom Lane , Noah Misch , Peter Eisentraut , Aleksander Alekseev , Postgres hackers , Maxim Orlov , Andres Freund , Greg Stark , Julien Rouhaud , David Steele , Peter Geoghegan , Maxim Orlov , lubennikovaav@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Jul 26, 2024 at 8:10=E2=80=AFAM Alexander Korotkov wrote: > The revised version of 0001 unique checking optimization is attached. > I'm going to push this to v18 if no objections. I have no reason to specifically object to pushing this into 18, but I would like to point out that you're posting here about this but failed to reply to the "64-bit pg_notify page numbers truncated to 32-bit", an open item that was assigned to you but which, since you didn't respond, was eventually fixed by commits from Michael Paquier. I know it's easy to lose track of the open items list and I sometimes forget to check it myself, but it's rather important to stay on top of any open items that get assigned to you. Thanks, --=20 Robert Haas EDB: http://www.enterprisedb.com