MIME-Version: 1.0
References: <c73a1746-0cd0-6bdd-6b23-3ae0b7c0c582@postgrespro.ru>
 <CAPpHfdtTgSdbzfcEz_mgVxh8VSDP=VfQ6r4T1n9SMT_impbDiA@mail.gmail.com>
 <b56918c2-b099-9875-aa4e-8fd405cdb6ab@gmail.com> <dbc8b96c-3cf0-d1ee-860d-0e491da20485@gmail.com>
 <86bfd241-a58c-479a-9a72-2c67a02becf8@postgrespro.ru> <CAMbWs49c_7dT_oiP729b-JPRiDtTuDca3exN_cOZZwjGG-0bMA@mail.gmail.com>
 <b907ce77-c054-4009-a871-4d55cb3f73f9@postgrespro.ru> <fdaa003e-919c-cbc9-4f0c-e4546e96bd65@gmail.com>
 <edfbd846-dcc1-42d1-ac26-715691b687d3@postgrespro.ru> <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <CAPpHfdv1ZkY9cPOqsLvDY9AA-fCYKHM4P07+-Mu+xq5o=daS6w@mail.gmail.com>
 <CA+TgmoYcjL+w2BQzku5iNXKR5fyxJMSP3avQta8xngioTX7D7A@mail.gmail.com>
 <e711faa8-826d-434d-b197-ab51da518fe7@postgrespro.ru> <f79fa76f-de07-b930-0bc7-359d6cbab159@gmail.com>
 <b156efc2-5e6d-4eae-8e60-2d483987b42c@postgrespro.ru> <CAPpHfdv-uR663BO6G2kRuLEQjob+UBHuD3iyXF+qGHXQFRN0-Q@mail.gmail.com>
 <CA+TgmoaWVq0omunhPzwKt=L7fqUFDgJcLiodmZ_ZqBNiPxzY+Q@mail.gmail.com> <7edb8a57-5e50-dd77-7953-454d6686779e@gmail.com>
In-Reply-To: <7edb8a57-5e50-dd77-7953-454d6686779e@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
Date: Mon, 15 Apr 2024 11:38:04 -0400
Message-ID: <CA+Tgmob9s__Qq+wHNRQ28Xe3rxeW3jG-5vsWJ+N45eoAJ47ukQ@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Dmitry Koval <d.koval@postgrespro.ru>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmob9s__Qq%2BwHNRQ28Xe3rxeW3jG-5vsWJ%2BN45eoAJ47ukQ%40mail.gmail.com>
Precedence: bulk

On Mon, Apr 15, 2024 at 11:00=E2=80=AFAM Alexander Lakhin <exclusion@gmail.=
com> wrote:
> Initially I was confused by that message, because of:
> CREATE TABLE t (i int) PARTITION BY RANGE (i);
> CREATE FOREIGN TABLE ftp_0_1 PARTITION OF t
>    FOR VALUES FROM (0) TO (1)
>    SERVER loopback OPTIONS (table_name 'lt_0_1');
> CREATE FOREIGN TABLE ftp_1_2 PARTITION OF t
>    FOR VALUES FROM (1) TO (2)
>    SERVER loopback OPTIONS (table_name 'lt_1_2');
> ALTER TABLE t MERGE PARTITIONS (ftp_0_1, ftp_1_2) INTO ftp_0_2;
> ERROR:  "ftp_0_1" is not a table
> (Isn't a foreign table a table?)

I agree that this can be confusing, but a patch that is about adding
SPLIT and MERGE PARTITION operations cannot decide to also invent a
new error message phraseology and use it only in one place. We need to
maintain consistency across the whole code base.

--=20
Robert Haas
EDB: http://www.enterprisedb.com