Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdj8-00Bg3L-EJ for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Dec 2023 16:29:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rBdj6-009Z1B-7s for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Dec 2023 16:29:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdj5-009Z12-UM for pgsql-hackers@lists.postgresql.org; Fri, 08 Dec 2023 16:29:19 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rBdj2-00AqX3-RC for pgsql-hackers@postgresql.org; Fri, 08 Dec 2023 16:29:18 +0000 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2ca1e6a94a4so29023421fa.0 for ; Fri, 08 Dec 2023 08:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702052956; x=1702657756; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gN41XJXaXUM4IvDUBkWUUSRl6LJU4WTdDANsmRJzS1Q=; b=JLaDBFIZ7fyuB5Ia0BX3ZIRREJMbCDdJ1LKAN0GONGCYMSETIkHxF9ZZCdMy9nRa28 r9NRQuxqUpnHCrF5gmayPnr1ZLQjRR19fxz7aSVaiL1treCTIB0zapXtUq2pBZh3QfVa 2dJDAMW1sltWQlJAZTtWLqUcXOoyyjouIzAOzLR5G44fAMEA3fZh1SrbpOoAYKL3sfHy Lz85P2XQjEk7WxFHjS37fnTT1gurFkCFee+24/cAsNfdS1kWSn5iMLQlQmFH1QPBwjml xp6BC+eJ+Fmp5j3q1YIjmHVr/oLvKjTofsNWIhI/6ffHp8HDVkQHLQMBpO1nbbugvt+7 z7ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702052956; x=1702657756; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gN41XJXaXUM4IvDUBkWUUSRl6LJU4WTdDANsmRJzS1Q=; b=a1vC/Kk/f/K9hQyGRIso2Rxf5djgNr4B9X05/CIqSOZvPTUCj1WWhTTORZGySo0ZSx CHgIFv8TGsYlN5FCVbu1fiIBLpcMw37kkCIfsQMdU0Vex/MwxnKrOckzZdx2t3kaIo6s nEqb5j7e5kOmE+dbvgGsKYlmrfhKkcW+ALTvEKEarYx6uUSZCvhyluX2nVDu21uZclHU bYyxScODSO504ALK1b1XqlIXJGMC0ONoJiule2NufrWk0EEEU/DGtbDzXWqM4nxR2k9K 39UMBrZAb7sG0f2UbBVvKOVbmJ1t5Tayb2T60+P8XJV4x4dbFxEuqkRk9R0vNNbH6y45 qkjA== X-Gm-Message-State: AOJu0YzU5VvrzAg07hsSKTsvg/7r3WOMZ7UT3pun1GhyuI2ACxSjTRR9 jjPClr84ANNJgmrP5O2xDJygOYqfjHzD3SCaV8I= X-Google-Smtp-Source: AGHT+IECYrehQ2gMpOtXrI35LYySYzQtWgUxt/G2Y5Y+7OzlfBNEA0kPYqMuJe4ifEuMSw5q7Dc7InHpzf5Obt/6Iso= X-Received: by 2002:a2e:a1cd:0:b0:2ca:882:f998 with SMTP id c13-20020a2ea1cd000000b002ca0882f998mr98978ljm.42.1702052955417; Fri, 08 Dec 2023 08:29:15 -0800 (PST) MIME-Version: 1.0 References: <20231205180402.GB2757816@nathanxps13> <20231205210141.GA2762421@nathanxps13> In-Reply-To: From: Robert Haas Date: Fri, 8 Dec 2023 11:29:03 -0500 Message-ID: Subject: Re: UBSan pointer overflow in xlogreader.c To: Thomas Munro Cc: Nathan Bossart , pgsql-hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Dec 7, 2023 at 10:18=E2=80=AFPM Thomas Munro wrote: > On Fri, Dec 8, 2023 at 3:57=E2=80=AFAM Robert Haas wrote: > > On Tue, Dec 5, 2023 at 4:01=E2=80=AFPM Nathan Bossart wrote: > > > +1 > > > > So, Thomas ... any chance you could commit this? So that my patch > > stops making cfbot sad? > > Done. Thanks both for the reviews. Thank you! --=20 Robert Haas EDB: http://www.enterprisedb.com